Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-07-16 Thread Roger Quadros
Paul, On 16/07/15 04:47, Paul Walmsley wrote: > Hi Roger > > On Mon, 13 Jul 2015, Roger Quadros wrote: > >> There are quite a few hwmods that don't have sysconfig register and so >> _find_mpu_rt_port(oh) will return NULL thus preventing ready state check >> on those modules after the module is e

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-07-15 Thread Paul Walmsley
Hi Roger On Mon, 13 Jul 2015, Roger Quadros wrote: > There are quite a few hwmods that don't have sysconfig register and so > _find_mpu_rt_port(oh) will return NULL thus preventing ready state check > on those modules after the module is enabled. > > This can potentially cause a bus access error

[PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-07-13 Thread Roger Quadros
There are quite a few hwmods that don't have sysconfig register and so _find_mpu_rt_port(oh) will return NULL thus preventing ready state check on those modules after the module is enabled. This can potentially cause a bus access error if the module is accessed before the module is ready. Get rid

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-01-14 Thread Roger Quadros
On 14/01/15 01:46, Paul Walmsley wrote: > On Wed, 7 Jan 2015, Roger Quadros wrote: > >>> From: Paul Walmsley >>> Date: Mon, 5 Jan 2015 15:49:57 -0700 >>> Subject: [PATCH] Only skip ioremap() if IP block does not have OCP header >>> registers. Experimental. >>> >>> --- >>> arch/arm/mach-omap2/om

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-01-13 Thread Suman Anna
Hi Paul, On 01/13/2015 05:29 PM, Paul Walmsley wrote: > Hi Suman, > > thanks for pitching in on this! > > On Tue, 6 Jan 2015, Suman Anna wrote: > >> You have removed the return from the above block on failure. If any DT >> entry doesn't have the reg property, this will hang the kernel boot. >>

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-01-13 Thread Paul Walmsley
On Wed, 7 Jan 2015, Roger Quadros wrote: > > From: Paul Walmsley > > Date: Mon, 5 Jan 2015 15:49:57 -0700 > > Subject: [PATCH] Only skip ioremap() if IP block does not have OCP header > > registers. Experimental. > > > > --- > > arch/arm/mach-omap2/omap_hwmod.c | 33 +--

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-01-13 Thread Paul Walmsley
Hi Suman On Tue, 6 Jan 2015, Suman Anna wrote: > Looking at your rc3 log @ > http://www.pwsan.com/omap/testlogs/test_v3.19-rc3/20150105224749/boot/4460varsomom/, > I do see a missing reg entry for mailbox, and that's the reason for your > hang because of the missing bail out in your new patch. >

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-01-13 Thread Paul Walmsley
Hi Suman, thanks for pitching in on this! On Tue, 6 Jan 2015, Suman Anna wrote: > You have removed the return from the above block on failure. If any DT > entry doesn't have the reg property, this will hang the kernel boot. > Just remove the "reg" entry from any of the existing DT, and you will

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-01-07 Thread Roger Quadros
On 06/01/15 04:04, Paul Walmsley wrote: > > Roger, Lokesh, could you try this one instead? > > It passes all the basic tests here except it does not boot on the 4460 > VAR-SOM-OM - unclear why at this point - but it would be good to see if it > works on your AM4372 boards, since I don't have th

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-01-06 Thread Suman Anna
On 01/06/2015 11:27 AM, Suman Anna wrote: > Hi Paul, > > On 01/06/2015 11:14 AM, Suman Anna wrote: >> Hi Paul, >> >> On 01/06/2015 02:14 AM, Lokesh Vutla wrote: >>> Hi Paul, >>> On Tuesday 06 January 2015 07:34 AM, Paul Walmsley wrote: Roger, Lokesh, could you try this one instead? >>> Y

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-01-06 Thread Suman Anna
Hi Paul, On 01/06/2015 11:14 AM, Suman Anna wrote: > Hi Paul, > > On 01/06/2015 02:14 AM, Lokesh Vutla wrote: >> Hi Paul, >> On Tuesday 06 January 2015 07:34 AM, Paul Walmsley wrote: >>> >>> Roger, Lokesh, could you try this one instead? >> Yep, the below patch works on AM437x. >> Boot logs here:

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-01-06 Thread Suman Anna
Hi Paul, On 01/06/2015 02:14 AM, Lokesh Vutla wrote: > Hi Paul, > On Tuesday 06 January 2015 07:34 AM, Paul Walmsley wrote: >> >> Roger, Lokesh, could you try this one instead? > Yep, the below patch works on AM437x. > Boot logs here: http://paste.ubuntu.com/9680938/ > > Thanks and regards, > Lok

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-01-06 Thread Lokesh Vutla
Hi Paul, On Tuesday 06 January 2015 07:34 AM, Paul Walmsley wrote: > > Roger, Lokesh, could you try this one instead? Yep, the below patch works on AM437x. Boot logs here: http://paste.ubuntu.com/9680938/ Thanks and regards, Lokesh > > It passes all the basic tests here except it does not boot o

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-01-05 Thread Paul Walmsley
Roger, Lokesh, could you try this one instead? It passes all the basic tests here except it does not boot on the 4460 VAR-SOM-OM - unclear why at this point - but it would be good to see if it works on your AM4372 boards, since I don't have that one. Test logs are here: http://www.pwsan.com/o

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-01-05 Thread santosh.shilim...@oracle.com
On 1/5/15 2:19 PM, Paul Walmsley wrote: + Santosh Hi Lokesh On Mon, 5 Jan 2015, Lokesh Vutla wrote: On Saturday 03 January 2015 02:40 AM, Paul Walmsley wrote: On Thu, 18 Dec 2014, Roger Quadros wrote: On 18/12/14 17:49, Roger Quadros wrote: There are quite a few hwmods that don't have sysc

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-01-05 Thread Paul Walmsley
On Mon, 5 Jan 2015, Suman Anna wrote: > That's right, the test was present even before 6423d6df1440, I merely > made this a block. Indeed, I misread the commit. Sorry about ihat. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord.

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-01-05 Thread Paul Walmsley
+ Santosh Hi Lokesh On Mon, 5 Jan 2015, Lokesh Vutla wrote: > On Saturday 03 January 2015 02:40 AM, Paul Walmsley wrote: > > On Thu, 18 Dec 2014, Roger Quadros wrote: > > > >> On 18/12/14 17:49, Roger Quadros wrote: > >>> There are quite a few hwmods that don't have sysconfig register and so > >

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-01-05 Thread Suman Anna
On 01/05/2015 02:35 AM, Lokesh Vutla wrote: > Hi Paul, > On Saturday 03 January 2015 02:40 AM, Paul Walmsley wrote: >> + Suman, lakml >> >> Hi Roger >> >> On Thu, 18 Dec 2014, Roger Quadros wrote: >> >>> Fixing up Paul's email id. >>> >>> cheers, >>> -roger >>> >>> On 18/12/14 17:49, Roger Quadros

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-01-05 Thread Lokesh Vutla
Hi Paul, On Saturday 03 January 2015 02:40 AM, Paul Walmsley wrote: > + Suman, lakml > > Hi Roger > > On Thu, 18 Dec 2014, Roger Quadros wrote: > >> Fixing up Paul's email id. >> >> cheers, >> -roger >> >> On 18/12/14 17:49, Roger Quadros wrote: >>> There are quite a few hwmods that don't have s

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-01-02 Thread Paul Walmsley
+ Suman, lakml Hi Roger On Thu, 18 Dec 2014, Roger Quadros wrote: > Fixing up Paul's email id. > > cheers, > -roger > > On 18/12/14 17:49, Roger Quadros wrote: > > There are quite a few hwmods that don't have sysconfig register and so > > _find_mpu_rt_port(oh) will return NULL thus preventing

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2015-01-02 Thread Tony Lindgren
* Roger Quadros [141219 01:08]: > Lokesh, > > On 19/12/14 07:21, Lokesh Vutla wrote: > > Hi Roger, > > On Thursday 18 December 2014 09:22 PM, Roger Quadros wrote: > >> Fixing up Paul's email id. > >> > >> cheers, > >> -roger > >> > >> On 18/12/14 17:49, Roger Quadros wrote: > >>> There are quite

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2014-12-19 Thread Roger Quadros
Lokesh, On 19/12/14 07:21, Lokesh Vutla wrote: > Hi Roger, > On Thursday 18 December 2014 09:22 PM, Roger Quadros wrote: >> Fixing up Paul's email id. >> >> cheers, >> -roger >> >> On 18/12/14 17:49, Roger Quadros wrote: >>> There are quite a few hwmods that don't have sysconfig register and so >>

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2014-12-18 Thread Lokesh Vutla
Hi Roger, On Thursday 18 December 2014 09:22 PM, Roger Quadros wrote: > Fixing up Paul's email id. > > cheers, > -roger > > On 18/12/14 17:49, Roger Quadros wrote: >> There are quite a few hwmods that don't have sysconfig register and so >> _find_mpu_rt_port(oh) will return NULL thus preventing r

Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2014-12-18 Thread Roger Quadros
Fixing up Paul's email id. cheers, -roger On 18/12/14 17:49, Roger Quadros wrote: > There are quite a few hwmods that don't have sysconfig register and so > _find_mpu_rt_port(oh) will return NULL thus preventing ready state check > on those modules after the module is enabled. > > This can poten

[PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

2014-12-18 Thread Roger Quadros
There are quite a few hwmods that don't have sysconfig register and so _find_mpu_rt_port(oh) will return NULL thus preventing ready state check on those modules after the module is enabled. This can potentially cause a bus access error if the module is accessed before the module is ready. Get rid