Re: [PATCH] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-06-06 Thread Cousson, Benoit
On 6/6/2012 2:28 AM, Paul Walmsley wrote: Hello Benoît On Tue, 5 Jun 2012, Paul Walmsley wrote: On Tue, 29 May 2012, Cousson, Benoit wrote: So in fact, I'm wondering if a new flag is needed. We can potentially apply that if idlemodes == (SIDLE_FORCE | SIDLE_NO). We need to check which IP wi

Re: [PATCH] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-06-06 Thread Cousson, Benoit
Salut Paul, On 6/6/2012 12:55 AM, Paul Walmsley wrote: Hello Benoît On Tue, 29 May 2012, Cousson, Benoit wrote: On 5/25/2012 11:56 PM, Paul Walmsley wrote: This patch is effectively a workaround for a hardware oversight. A better hardware approach would have been to implement a smart-idle

Re: [PATCH] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-06-05 Thread Paul Walmsley
Hello Benoît On Tue, 5 Jun 2012, Paul Walmsley wrote: > On Tue, 29 May 2012, Cousson, Benoit wrote: > > > So in fact, I'm wondering if a new flag is needed. We can potentially > > apply that if idlemodes == (SIDLE_FORCE | SIDLE_NO). > > > > We need to check which IP will have that to ensure th

Re: [PATCH] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-06-05 Thread Paul Walmsley
Hello Benoît On Tue, 29 May 2012, Cousson, Benoit wrote: > On 5/25/2012 11:56 PM, Paul Walmsley wrote: > > > This patch is effectively a workaround for a hardware oversight. A > > better hardware approach would have been to implement a smart-idle > > target idle mode for this IP block. The smar

Re: [PATCH] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-05-29 Thread Cousson, Benoit
Hi Paul, On 5/25/2012 11:56 PM, Paul Walmsley wrote: > > Kevin discovered that commit c8d82ff68fb6873691536cf33021977efbf5593c > ("ARM: OMAP2/3: hwmod data: Add 32k-sync timer data to hwmod > database") broke CORE idle on OMAP3. This blocks device low power > states. > > The root cause is that

[PATCH] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-05-25 Thread Paul Walmsley
Kevin discovered that commit c8d82ff68fb6873691536cf33021977efbf5593c ("ARM: OMAP2/3: hwmod data: Add 32k-sync timer data to hwmod database") broke CORE idle on OMAP3. This blocks device low power states. The root cause is that the 32K sync timer IP block does not support smart-idle mode[1], and