Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-14 Thread Sekhar Nori
On Wednesday 09 July 2014 07:25 PM, Felipe Balbi wrote: On Wed, Jul 09, 2014 at 05:56:37PM +0530, Sekhar Nori wrote: On Wednesday 09 July 2014 02:55 PM, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [140708 01:32]: * Sekhar Nori nsek...@ti.com [140707 21:56]: On Monday 07 July 2014

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-14 Thread Sekhar Nori
On Wednesday 09 July 2014 07:45 PM, Santosh Shilimkar wrote: On Wednesday 09 July 2014 08:39 AM, Russell King - ARM Linux wrote: On Wed, Jul 09, 2014 at 05:56:37PM +0530, Sekhar Nori wrote: On Wednesday 09 July 2014 02:55 PM, Tony Lindgren wrote: I guess no more comments. Took a look at the

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-09 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [140708 01:32]: * Sekhar Nori nsek...@ti.com [140707 21:56]: On Monday 07 July 2014 08:40 PM, Felipe Balbi wrote: On Mon, Jul 07, 2014 at 02:40:08PM +0100, Russell King - ARM Linux wrote: --- a/arch/arm/mm/cache-l2x0.c +++ b/arch/arm/mm/cache-l2x0.c

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-09 Thread Sekhar Nori
On Wednesday 09 July 2014 02:55 PM, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [140708 01:32]: * Sekhar Nori nsek...@ti.com [140707 21:56]: On Monday 07 July 2014 08:40 PM, Felipe Balbi wrote: On Mon, Jul 07, 2014 at 02:40:08PM +0100, Russell King - ARM Linux wrote: ---

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-09 Thread Tony Lindgren
* Sekhar Nori nsek...@ti.com [140709 05:28]: On Wednesday 09 July 2014 02:55 PM, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [140708 01:32]: * Sekhar Nori nsek...@ti.com [140707 21:56]: On Monday 07 July 2014 08:40 PM, Felipe Balbi wrote: On Mon, Jul 07, 2014 at 02:40:08PM

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-09 Thread Russell King - ARM Linux
On Wed, Jul 09, 2014 at 05:56:37PM +0530, Sekhar Nori wrote: On Wednesday 09 July 2014 02:55 PM, Tony Lindgren wrote: I guess no more comments. Took a look at the patch again, Sekhar, can you please update the description with what has been discovered in this thread and repost? How does

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-09 Thread Felipe Balbi
On Wed, Jul 09, 2014 at 02:25:31AM -0700, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [140708 01:32]: * Sekhar Nori nsek...@ti.com [140707 21:56]: On Monday 07 July 2014 08:40 PM, Felipe Balbi wrote: On Mon, Jul 07, 2014 at 02:40:08PM +0100, Russell King - ARM Linux wrote:

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-09 Thread Felipe Balbi
On Wed, Jul 09, 2014 at 05:56:37PM +0530, Sekhar Nori wrote: On Wednesday 09 July 2014 02:55 PM, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [140708 01:32]: * Sekhar Nori nsek...@ti.com [140707 21:56]: On Monday 07 July 2014 08:40 PM, Felipe Balbi wrote: On Mon, Jul 07, 2014 at

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-09 Thread Santosh Shilimkar
On Monday 07 July 2014 09:40 AM, Russell King - ARM Linux wrote: On Mon, Jul 07, 2014 at 05:39:26AM -0700, Tony Lindgren wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [140707 05:17]: On Mon, Jul 07, 2014 at 05:20:27PM +0530, Sekhar Nori wrote: OMAP4430 had L2 cache controller

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-09 Thread Santosh Shilimkar
On Wednesday 09 July 2014 08:39 AM, Russell King - ARM Linux wrote: On Wed, Jul 09, 2014 at 05:56:37PM +0530, Sekhar Nori wrote: On Wednesday 09 July 2014 02:55 PM, Tony Lindgren wrote: I guess no more comments. Took a look at the patch again, Sekhar, can you please update the description with

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-08 Thread Tony Lindgren
* Sekhar Nori nsek...@ti.com [140707 21:56]: On Monday 07 July 2014 08:40 PM, Felipe Balbi wrote: On Mon, Jul 07, 2014 at 02:40:08PM +0100, Russell King - ARM Linux wrote: --- a/arch/arm/mm/cache-l2x0.c +++ b/arch/arm/mm/cache-l2x0.c @@ -732,7 +732,7 @@ static int

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-07 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [140702 01:13]: * Felipe Balbi ba...@ti.com [140701 12:49]: On Tue, Jun 17, 2014 at 08:19:35AM -0500, Felipe Balbi wrote: On Tue, Jun 17, 2014 at 04:04:51PM +0530, Sekhar Nori wrote: ROM code on AM437x does not support writing to L2C-310 power control

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-07 Thread Russell King - ARM Linux
On Mon, Jul 07, 2014 at 03:47:27AM -0700, Tony Lindgren wrote: That's now merged into v3.16-rc4, so applying this into omap-for-v3.16/fixes. I intentionally left the warning in the hope that someone would update it to write to the register. From the comments in the patch, it seems that

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-07 Thread Tony Lindgren
* Russell King - ARM Linux li...@arm.linux.org.uk [140707 03:51]: On Mon, Jul 07, 2014 at 03:47:27AM -0700, Tony Lindgren wrote: That's now merged into v3.16-rc4, so applying this into omap-for-v3.16/fixes. I intentionally left the warning in the hope that someone would update it to write

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-07 Thread Sekhar Nori
On Monday 07 July 2014 04:32 PM, Tony Lindgren wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [140707 03:51]: On Mon, Jul 07, 2014 at 03:47:27AM -0700, Tony Lindgren wrote: That's now merged into v3.16-rc4, so applying this into omap-for-v3.16/fixes. I intentionally left the

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-07 Thread Russell King - ARM Linux
On Mon, Jul 07, 2014 at 05:20:27PM +0530, Sekhar Nori wrote: OMAP4430 had L2 cache controller version r2p0 (per the public TRM) which does not have this register. So unless there is a ROM API that was introduced after OMAP4430, this would not be there even for other OMAP4s. Public TRM of

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-07 Thread Tony Lindgren
* Russell King - ARM Linux li...@arm.linux.org.uk [140707 05:17]: On Mon, Jul 07, 2014 at 05:20:27PM +0530, Sekhar Nori wrote: OMAP4430 had L2 cache controller version r2p0 (per the public TRM) which does not have this register. So unless there is a ROM API that was introduced after

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-07 Thread Russell King - ARM Linux
On Mon, Jul 07, 2014 at 05:39:26AM -0700, Tony Lindgren wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [140707 05:17]: On Mon, Jul 07, 2014 at 05:20:27PM +0530, Sekhar Nori wrote: OMAP4430 had L2 cache controller version r2p0 (per the public TRM) which does not have this

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-07 Thread Felipe Balbi
Hi, On Mon, Jul 07, 2014 at 02:40:08PM +0100, Russell King - ARM Linux wrote: On Mon, Jul 07, 2014 at 05:39:26AM -0700, Tony Lindgren wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [140707 05:17]: On Mon, Jul 07, 2014 at 05:20:27PM +0530, Sekhar Nori wrote: OMAP4430 had L2

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-07 Thread Sekhar Nori
On Monday 07 July 2014 08:40 PM, Felipe Balbi wrote: Hi, On Mon, Jul 07, 2014 at 02:40:08PM +0100, Russell King - ARM Linux wrote: On Mon, Jul 07, 2014 at 05:39:26AM -0700, Tony Lindgren wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [140707 05:17]: On Mon, Jul 07, 2014 at

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-02 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [140701 12:49]: On Tue, Jun 17, 2014 at 08:19:35AM -0500, Felipe Balbi wrote: On Tue, Jun 17, 2014 at 04:04:51PM +0530, Sekhar Nori wrote: ROM code on AM437x does not support writing to L2C-310 power control register. The L2C driver, however, tries writing to

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-07-01 Thread Felipe Balbi
On Tue, Jun 17, 2014 at 08:19:35AM -0500, Felipe Balbi wrote: On Tue, Jun 17, 2014 at 04:04:51PM +0530, Sekhar Nori wrote: ROM code on AM437x does not support writing to L2C-310 power control register. The L2C driver, however, tries writing to this register for all revisions = r3p0.

[PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-06-17 Thread Sekhar Nori
ROM code on AM437x does not support writing to L2C-310 power control register. The L2C driver, however, tries writing to this register for all revisions = r3p0. This leads to a warning dump on boot which leads most users to believe that L2 cache is non-functional. Since the problem is

Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

2014-06-17 Thread Felipe Balbi
On Tue, Jun 17, 2014 at 04:04:51PM +0530, Sekhar Nori wrote: ROM code on AM437x does not support writing to L2C-310 power control register. The L2C driver, however, tries writing to this register for all revisions = r3p0. This leads to a warning dump on boot which leads most users to believe