Re: [PATCH] IRQ: simplify OMAP2 mask_irq/unmask_irq code

2008-05-22 Thread Tony Lindgren
ter and > > > IRQ > > > number-to-register bit calculations. > > > > How about patching Jouni's new omap_irq_pending() for this too? > > done - updated patch below. Thanks, pushing today. Tony > > - Paul > > > [PATCH] IRQ: simplify OM

Re: [PATCH] IRQ: simplify OMAP2 mask_irq/unmask_irq code

2008-05-21 Thread Paul Walmsley
#x27;s new omap_irq_pending() for this too? done - updated patch below. - Paul [PATCH] IRQ: simplify OMAP2 mask_irq/unmask_irq code Modify mach-omap2/irq.c to simplify the IRQ number-to-IRQ register and IRQ number-to-register bit calculations. Signed-off-by: Paul Walmsley <[EMAIL PROTECT

Re: [PATCH] IRQ: simplify OMAP2 mask_irq/unmask_irq code

2008-05-21 Thread Tony Lindgren
Hi, * Paul Walmsley <[EMAIL PROTECTED]> [080520 18:20]: > > Modify mach-omap2/irq.c to simplify the IRQ number-to-IRQ register and IRQ > number-to-register bit calculations. How about patching Jouni's new omap_irq_pending() for this too? Tony > Signed-off-by: Kyungmin Park <[EMAIL PROTECTED]>

Re: [PATCH] IRQ: simplify OMAP2 mask_irq/unmask_irq code

2008-05-20 Thread Paul Walmsley
Great - thanks everyone for the review, - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] IRQ: simplify OMAP2 mask_irq/unmask_irq code

2008-05-20 Thread Paul Walmsley
Modify mach-omap2/irq.c to simplify the IRQ number-to-IRQ register and IRQ number-to-register bit calculations. Signed-off-by: Kyungmin Park <[EMAIL PROTECTED]> Signed-off-by: Paul Walmsley <[EMAIL PROTECTED]> Acked-by: Paul Mundt <[EMAIL PROTECTED]> size: textdata bss dec he

Re: [PATCH] IRQ: simplify OMAP2 mask_irq/unmask_irq code

2008-05-20 Thread Paul Mundt
On Tue, May 20, 2008 at 06:12:04PM -0600, Paul Walmsley wrote: > On Wed, 21 May 2008, Kyungmin Park wrote: > > On Wed, May 21, 2008 at 3:21 AM, Paul Walmsley <[EMAIL PROTECTED]> wrote: > > > > > > static void omap_mask_irq(unsigned int irq) > > > { > > > - int offset = (irq >> 5) << 5; > >

Re: [PATCH] IRQ: simplify OMAP2 mask_irq/unmask_irq code

2008-05-20 Thread Kyungmin Park
On Wed, May 21, 2008 at 9:39 AM, Philip Balister <[EMAIL PROTECTED]> wrote: > Paul Walmsley wrote: >> >> Hello Kyungmin, >> >> On Wed, 21 May 2008, Kyungmin Park wrote: >> >>> On Wed, May 21, 2008 at 3:21 AM, Paul Walmsley <[EMAIL PROTECTED]> wrote: static void omap_mask_irq(unsigned int

Re: [PATCH] IRQ: simplify OMAP2 mask_irq/unmask_irq code

2008-05-20 Thread Philip Balister
Paul Walmsley wrote: Hello Kyungmin, On Wed, 21 May 2008, Kyungmin Park wrote: On Wed, May 21, 2008 at 3:21 AM, Paul Walmsley <[EMAIL PROTECTED]> wrote: static void omap_mask_irq(unsigned int irq) { - int offset = (irq >> 5) << 5; + int offset = irq & (~(IRQ_BITS_PER_REG - 1));

Re: [PATCH] IRQ: simplify OMAP2 mask_irq/unmask_irq code

2008-05-20 Thread Paul Walmsley
Hello Kyungmin, On Wed, 21 May 2008, Kyungmin Park wrote: > On Wed, May 21, 2008 at 3:21 AM, Paul Walmsley <[EMAIL PROTECTED]> wrote: > > > > static void omap_mask_irq(unsigned int irq) > > { > > - int offset = (irq >> 5) << 5; > > + int offset = irq & (~(IRQ_BITS_PER_REG - 1)); > >

Re: [PATCH] IRQ: simplify OMAP2 mask_irq/unmask_irq code

2008-05-20 Thread Kyungmin Park
On Wed, May 21, 2008 at 3:21 AM, Paul Walmsley <[EMAIL PROTECTED]> wrote: > > Simplify the IRQ register/IRQ register bit calculations in > mach-omap2/irq.c. > > Test-booted on 3430SDP. > > Signed-off-by: Paul Walmsley <[EMAIL PROTECTED]> > > --- > > size: > textdata bss dec hex fi

[PATCH] IRQ: simplify OMAP2 mask_irq/unmask_irq code

2008-05-20 Thread Paul Walmsley
Simplify the IRQ register/IRQ register bit calculations in mach-omap2/irq.c. Test-booted on 3430SDP. Signed-off-by: Paul Walmsley <[EMAIL PROTECTED]> --- size: textdata bss dec hex filename 3341347 170992 109008 3621347 3741e3 vmlinux.3430sdp 3341315 170992 109008 362