Re: [PATCH] OMAPDSS: TFP410: use gpio_set_value_cansleep

2012-05-10 Thread Tomi Valkeinen
On Wed, 2012-05-09 at 16:37 -0700, Tony Lindgren wrote: * Russ Dill russ.d...@ti.com [120509 15:53]: On Wed, May 9, 2012 at 3:14 PM, Tony Lindgren t...@atomide.com wrote: * Russ Dill russ.d...@ti.com [120509 15:12]: The Beagleboard xM gpio used for TFP410 powerdown is connected through

Re: [PATCH] OMAPDSS: TFP410: use gpio_set_value_cansleep

2012-05-10 Thread Tomi Valkeinen
On Wed, 2012-05-09 at 15:08 -0700, Russ Dill wrote: The Beagleboard xM gpio used for TFP410 powerdown is connected through an I2C attached chip which means setting the GPIO can sleep. Code that calls tfp410_power_on/off holds a mutex, so sleeping should be fine. Signed-off-by: Russ Dill

Re: [PATCH] OMAPDSS: TFP410: use gpio_set_value_cansleep

2012-05-10 Thread Tony Lindgren
* Tomi Valkeinen tomi.valkei...@ti.com [120509 23:56]: On Wed, 2012-05-09 at 16:37 -0700, Tony Lindgren wrote: * Russ Dill russ.d...@ti.com [120509 15:53]: On Wed, May 9, 2012 at 3:14 PM, Tony Lindgren t...@atomide.com wrote: * Russ Dill russ.d...@ti.com [120509 15:12]: The

[PATCH] OMAPDSS: TFP410: use gpio_set_value_cansleep

2012-05-09 Thread Russ Dill
The Beagleboard xM gpio used for TFP410 powerdown is connected through an I2C attached chip which means setting the GPIO can sleep. Code that calls tfp410_power_on/off holds a mutex, so sleeping should be fine. Signed-off-by: Russ Dill russ.d...@ti.com ---

Re: [PATCH] OMAPDSS: TFP410: use gpio_set_value_cansleep

2012-05-09 Thread Tony Lindgren
* Russ Dill russ.d...@ti.com [120509 15:12]: The Beagleboard xM gpio used for TFP410 powerdown is connected through an I2C attached chip which means setting the GPIO can sleep. Code that calls tfp410_power_on/off holds a mutex, so sleeping should be fine. What's the error without this patch?

Re: [PATCH] OMAPDSS: TFP410: use gpio_set_value_cansleep

2012-05-09 Thread Russ Dill
On Wed, May 9, 2012 at 3:14 PM, Tony Lindgren t...@atomide.com wrote: * Russ Dill russ.d...@ti.com [120509 15:12]: The Beagleboard xM gpio used for TFP410 powerdown is connected through an I2C attached chip which means setting the GPIO can sleep. Code that calls tfp410_power_on/off holds a

Re: [PATCH] OMAPDSS: TFP410: use gpio_set_value_cansleep

2012-05-09 Thread Tony Lindgren
* Russ Dill russ.d...@ti.com [120509 15:53]: On Wed, May 9, 2012 at 3:14 PM, Tony Lindgren t...@atomide.com wrote: * Russ Dill russ.d...@ti.com [120509 15:12]: The Beagleboard xM gpio used for TFP410 powerdown is connected through an I2C attached chip which means setting the GPIO can sleep.