Re: [PATCH] dmaengine: edma: fix build without CONFIG_OF

2015-11-15 Thread Vinod Koul
On Tue, Nov 03, 2015 at 03:00:57PM +0100, Arnd Bergmann wrote: > During the edma rework, a build error was introduced for the > case that CONFIG_OF is disabled: > > drivers/built-in.o: In function `edma_tc_set_pm_state': > :(.text+0x43bf0): undefined reference to `of_find_device_by_node' > > As t

Re: [PATCH] dmaengine: edma: fix build without CONFIG_OF

2015-11-04 Thread Arnd Bergmann
On Wednesday 04 November 2015 11:05:54 Peter Ujfalusi wrote: > > > > I think that would be less readable, and gives no compile-time coverage > > to the contents of the edma_tc_set_pm_state function. > > Hrm, if the compiler knows that there is no need to compile the code after > the: > if (!IS_E

Re: [PATCH] dmaengine: edma: fix build without CONFIG_OF

2015-11-04 Thread Peter Ujfalusi
On 11/04/2015 10:46 AM, Arnd Bergmann wrote: > On Wednesday 04 November 2015 09:42:35 Peter Ujfalusi wrote: >> On 11/03/2015 04:00 PM, Arnd Bergmann wrote: >>> During the edma rework, a build error was introduced for the >>> case that CONFIG_OF is disabled: >>> >>> drivers/built-in.o: In function `

Re: [PATCH] dmaengine: edma: fix build without CONFIG_OF

2015-11-04 Thread Arnd Bergmann
On Wednesday 04 November 2015 09:42:35 Peter Ujfalusi wrote: > On 11/03/2015 04:00 PM, Arnd Bergmann wrote: > > During the edma rework, a build error was introduced for the > > case that CONFIG_OF is disabled: > > > > drivers/built-in.o: In function `edma_tc_set_pm_state': > > :(.text+0x43bf0): un

Re: [PATCH] dmaengine: edma: fix build without CONFIG_OF

2015-11-03 Thread Peter Ujfalusi
On 11/03/2015 04:00 PM, Arnd Bergmann wrote: > During the edma rework, a build error was introduced for the > case that CONFIG_OF is disabled: > > drivers/built-in.o: In function `edma_tc_set_pm_state': > :(.text+0x43bf0): undefined reference to `of_find_device_by_node' > > As the edma_tc_set_pm_

[PATCH] dmaengine: edma: fix build without CONFIG_OF

2015-11-03 Thread Arnd Bergmann
During the edma rework, a build error was introduced for the case that CONFIG_OF is disabled: drivers/built-in.o: In function `edma_tc_set_pm_state': :(.text+0x43bf0): undefined reference to `of_find_device_by_node' As the edma_tc_set_pm_state() function does nothing in case we are running withou