Re: [PATCH] i2c: twl4030: warning: mixed declarations and code

2008-06-23 Thread Tony Lindgren
* Eduardo Valentin [EMAIL PROTECTED] [080611 17:04]: Hi Balbi, On Wed, Jun 11, 2008 at 9:55 AM, Felipe Balbi [EMAIL PROTECTED] wrote: On Wed, Jun 11, 2008 at 09:53:45AM -0400, ext Eduardo Valentin wrote: - struct twl4030_usb *twl = xceiv_to_twl(xceiv); u32 l; +

[PATCH] i2c: twl4030: warning: mixed declarations and code

2008-06-11 Thread Felipe Balbi
Latest patches for multi-omap support introduced it, removing. Trivial patch. Signed-off-by: Felipe Balbi [EMAIL PROTECTED] --- drivers/i2c/chips/twl4030-usb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/chips/twl4030-usb.c

Re: [PATCH] i2c: twl4030: warning: mixed declarations and code

2008-06-11 Thread Eduardo Valentin
Hi Balbi, On Wed, Jun 11, 2008 at 9:55 AM, Felipe Balbi [EMAIL PROTECTED] wrote: On Wed, Jun 11, 2008 at 09:53:45AM -0400, ext Eduardo Valentin wrote: - struct twl4030_usb *twl = xceiv_to_twl(xceiv); u32 l; + struct twl4030_usb *twl = xceiv_to_twl(xceiv); To me you are

Re: [PATCH] i2c: twl4030: warning: mixed declarations and code

2008-06-11 Thread Felipe Balbi
On Wed, Jun 11, 2008 at 09:53:45AM -0400, ext Eduardo Valentin wrote: - struct twl4030_usb *twl = xceiv_to_twl(xceiv); u32 l; + struct twl4030_usb *twl = xceiv_to_twl(xceiv); To me you are just moving the place of this declaration. Yes, because ISO C99 forbids mixed

Re: [PATCH] i2c: twl4030: warning: mixed declarations and code

2008-06-11 Thread Eduardo Valentin
Hi Balbi, Sorry but I didn't get your point with your patch. On Wed, Jun 11, 2008 at 7:55 AM, Felipe Balbi [EMAIL PROTECTED] wrote: Latest patches for multi-omap support introduced it, removing. What exactly you are removing? Trivial patch. Signed-off-by: Felipe Balbi [EMAIL PROTECTED]