Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-11 Thread Lars-Peter Clausen
On 10/11/2013 06:41 AM, Tomi Valkeinen wrote: On 10/10/13 21:58, Lars-Peter Clausen wrote: According to the datasheet the the panel as a dedicated dout pin. Maybe you did not connect it in your design, which means you won't be able to read any data from the panel at all. I don't see a

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-11 Thread Dr. H. Nikolaus Schaller
Hi all, Am 11.10.2013 um 06:41 schrieb Tomi Valkeinen: On 10/10/13 21:58, Lars-Peter Clausen wrote: According to the datasheet the the panel as a dedicated dout pin. Maybe you did not connect it in your design, which means you won't be able to read any data from the panel at all. I

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-11 Thread Dr. H. Nikolaus Schaller
Hi Lars-Peter, ah, I didn't see your mail while writing mine - so some overlap. Am 11.10.2013 um 09:08 schrieb Lars-Peter Clausen: On 10/11/2013 06:41 AM, Tomi Valkeinen wrote: On 10/10/13 21:58, Lars-Peter Clausen wrote: According to the datasheet the the panel as a dedicated dout pin.

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-11 Thread Tomi Valkeinen
On 11/10/13 10:42, Dr. H. Nikolaus Schaller wrote: I am not sure if there is a SPI driver for a McBSP port [1]? And to make that work (reliably) and tested it might need a lot of work for us. At least I think such a change (e.g. setting up clock polarity etc.) is not done in some minutes.

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-11 Thread Belisko Marek
Hi Tomi, On Fri, Oct 11, 2013 at 10:17 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On 11/10/13 10:42, Dr. H. Nikolaus Schaller wrote: I am not sure if there is a SPI driver for a McBSP port [1]? And to make that work (reliably) and tested it might need a lot of work for us. At least I

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-11 Thread Lars-Peter Clausen
On 10/11/2013 10:59 AM, Belisko Marek wrote: Hi Tomi, On Fri, Oct 11, 2013 at 10:17 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On 11/10/13 10:42, Dr. H. Nikolaus Schaller wrote: I am not sure if there is a SPI driver for a McBSP port [1]? And to make that work (reliably) and

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-11 Thread Tomi Valkeinen
On 11/10/13 11:59, Belisko Marek wrote: That's why I won't allow representing this panel as having 4 gpios in the DT data, because that is not correct. The panel has 3 pins. But then, the panel does allow reading, which could be implemented using 4 gpios as you have done. This data should be

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-11 Thread Dr. H. Nikolaus Schaller
Hi all, Am 11.10.2013 um 11:06 schrieb Lars-Peter Clausen: On 10/11/2013 10:59 AM, Belisko Marek wrote: Hi Tomi, On Fri, Oct 11, 2013 at 10:17 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On 11/10/13 10:42, Dr. H. Nikolaus Schaller wrote: I am not sure if there is a SPI driver for

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-11 Thread Tomi Valkeinen
On 11/10/13 12:50, Dr. H. Nikolaus Schaller wrote: Hm. Is this a SPI or does it just look like one? Or is it some - otherwise unknown - 3 wire serial interface. Or is it a 3(+1) GPIO slave device? I am still not sure about this. Lars-Peter said Back in the OpenMoko days we used the panel in

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-11 Thread Dr. H. Nikolaus Schaller
Hi Tomi, Am 11.10.2013 um 12:09 schrieb Tomi Valkeinen: On 11/10/13 12:50, Dr. H. Nikolaus Schaller wrote: Hm. Is this a SPI or does it just look like one? Or is it some - otherwise unknown - 3 wire serial interface. Or is it a 3(+1) GPIO slave device? I am still not sure about this.

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-10 Thread Tomi Valkeinen
Hi, On 10/10/13 00:08, Marek Belisko wrote: For communicating with driver is used gpio bitbanging because TD028 does not have a standard compliant SPI interface. It is a 3-wire thing with direction reversal. Isn't that SPI_3WIRE? Communication with display is used only during panel

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-10 Thread Dr. H. Nikolaus Schaller
Hi Tomi, Am 10.10.2013 um 10:19 schrieb Tomi Valkeinen: Hi, On 10/10/13 00:08, Marek Belisko wrote: For communicating with driver is used gpio bitbanging because TD028 does not have a standard compliant SPI interface. It is a 3-wire thing with direction reversal. Isn't that SPI_3WIRE?

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-10 Thread Tomi Valkeinen
On 10/10/13 12:34, Dr. H. Nikolaus Schaller wrote: Hi Tomi, Am 10.10.2013 um 10:19 schrieb Tomi Valkeinen: Hi, On 10/10/13 00:08, Marek Belisko wrote: For communicating with driver is used gpio bitbanging because TD028 does not have a standard compliant SPI interface. It is a 3-wire

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-10 Thread Dr. H. Nikolaus Schaller
Hi Tomi, Am 10.10.2013 um 13:10 schrieb Tomi Valkeinen: On 10/10/13 12:34, Dr. H. Nikolaus Schaller wrote: Hi Tomi, Am 10.10.2013 um 10:19 schrieb Tomi Valkeinen: Hi, On 10/10/13 00:08, Marek Belisko wrote: For communicating with driver is used gpio bitbanging because TD028 does not

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-10 Thread Tomi Valkeinen
On 10/10/13 14:52, Dr. H. Nikolaus Schaller wrote: Yes, I agree and I am willing to help if someone comes up with such a SoC. At the moment we have connected it to the OMAP3 only. True, but even without that kind of SoC, SPI bitbanging should be handled by an SPI driver, not by the drivers

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-10 Thread Lars-Peter Clausen
On 10/10/2013 02:13 PM, Tomi Valkeinen wrote: On 10/10/13 14:52, Dr. H. Nikolaus Schaller wrote: Yes, I agree and I am willing to help if someone comes up with such a SoC. At the moment we have connected it to the OMAP3 only. True, but even without that kind of SoC, SPI bitbanging should

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-10 Thread Dr. H. Nikolaus Schaller
Am 10.10.2013 um 14:26 schrieb Lars-Peter Clausen: On 10/10/2013 02:13 PM, Tomi Valkeinen wrote: On 10/10/13 14:52, Dr. H. Nikolaus Schaller wrote: Yes, I agree and I am willing to help if someone comes up with such a SoC. At the moment we have connected it to the OMAP3 only. True, but

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-10 Thread Lars-Peter Clausen
On 10/10/2013 03:42 PM, Dr. H. Nikolaus Schaller wrote: Am 10.10.2013 um 14:26 schrieb Lars-Peter Clausen: On 10/10/2013 02:13 PM, Tomi Valkeinen wrote: On 10/10/13 14:52, Dr. H. Nikolaus Schaller wrote: Yes, I agree and I am willing to help if someone comes up with such a SoC. At the

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-10 Thread Tomi Valkeinen
On 10/10/13 21:58, Lars-Peter Clausen wrote: According to the datasheet the the panel as a dedicated dout pin. Maybe you did not connect it in your design, which means you won't be able to read any data from the panel at all. I don't see a dedicated dout in the datasheet...

[PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-09 Thread Marek Belisko
For communicating with driver is used gpio bitbanging because TD028 does not have a standard compliant SPI interface. It is a 3-wire thing with direction reversal. Communication with display is used only during panel enable/disable so it's not performance issue. Signed-off-by: Marek Belisko