Re: [PATCH] staging: Platform device tester - Allow removal

2013-08-13 Thread Greg Kroah-Hartman
On Tue, Aug 13, 2013 at 12:34:30PM +0300, Pantelis Antoniou wrote: This is a very simple device that allows testing of the removal path for platform devices. The only interface is a single writeable sysfs attribute (action). Why not use the existing unbind/bind sysfs files that all busses

Re: [PATCH] staging: Platform device tester - Allow removal

2013-08-13 Thread Greg Kroah-Hartman
On Tue, Aug 13, 2013 at 12:34:30PM +0300, Pantelis Antoniou wrote: +/* + * pdevtest.c + * + * Tester of platform device's operation. + * + * Copyright (C) 2013, Pantelis Antoniou pa...@antoniou-consulting.com + * + * This program is distributed in the hope that it will be useful, + * but

Re: [PATCH] staging: Platform device tester - Allow removal

2013-08-13 Thread Pantelis Antoniou
Hi Greg, On Aug 13, 2013, at 9:20 PM, Greg Kroah-Hartman wrote: On Tue, Aug 13, 2013 at 12:34:30PM +0300, Pantelis Antoniou wrote: This is a very simple device that allows testing of the removal path for platform devices. The only interface is a single writeable sysfs attribute (action).

Re: [PATCH] staging: Platform device tester - Allow removal

2013-08-13 Thread Greg Kroah-Hartman
On Tue, Aug 13, 2013 at 09:42:27PM +0300, Pantelis Antoniou wrote: Hi Greg, On Aug 13, 2013, at 9:20 PM, Greg Kroah-Hartman wrote: On Tue, Aug 13, 2013 at 12:34:30PM +0300, Pantelis Antoniou wrote: This is a very simple device that allows testing of the removal path for platform

Re: [PATCH] staging: Platform device tester - Allow removal

2013-08-13 Thread Russell King - ARM Linux
On Tue, Aug 13, 2013 at 09:42:27PM +0300, Pantelis Antoniou wrote: But creation just crashes. root@beaglebone:/sys/bus/platform/drivers/omap_i2c# echo 4819c000.i2c bind [ 145.053929] Unable to handle kernel NULL pointer dereference at virtual address 0001 [ 145.062651] pgd

Re: [PATCH] staging: Platform device tester - Allow removal

2013-08-13 Thread Pantelis Antoniou
Hi Greg, Just to make sure we're on the same page this is with my platform device removal patchset applied. Without it you get the original crash I've posted in the pdevtest patch with the unbind method. Regards -- Pantelis -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] staging: Platform device tester - Allow removal

2013-08-13 Thread Russell King - ARM Linux
On Tue, Aug 13, 2013 at 09:59:03PM +0300, Pantelis Antoniou wrote: Hi Greg, Just to make sure we're on the same page this is with my platform device removal patchset applied. Without it you get the original crash I've posted in the pdevtest patch with the unbind method. Yes,

Re: [PATCH] staging: Platform device tester - Allow removal

2013-08-13 Thread Greg Kroah-Hartman
On Tue, Aug 13, 2013 at 09:59:03PM +0300, Pantelis Antoniou wrote: Hi Greg, Just to make sure we're on the same page this is with my platform device removal patchset applied. Ah, ok, I never applied those, so could you resend them? thanks, greg k-h -- To unsubscribe from this list: send

Re: [PATCH] staging: Platform device tester - Allow removal

2013-08-13 Thread Pantelis Antoniou
Hi Russell, On Aug 13, 2013, at 10:02 PM, Russell King - ARM Linux wrote: On Tue, Aug 13, 2013 at 09:59:03PM +0300, Pantelis Antoniou wrote: Hi Greg, Just to make sure we're on the same page this is with my platform device removal patchset applied. Without it you get the original crash

Re: [PATCH] staging: Platform device tester - Allow removal

2013-08-13 Thread Kevin Hilman
Hi Pantelis, For some reason, with both this patch and the earlier versions, I don't see the patch until Greg (or someone else) responds. Nor do I find the originals in the linux-omap or LKML archives. Something's going on with your mail so that the first ones don't make it to the lists, so I

Re: [PATCH] staging: Platform device tester - Allow removal

2013-08-13 Thread Kevin Hilman
Russell King - ARM Linux li...@arm.linux.org.uk writes: On Tue, Aug 13, 2013 at 09:42:27PM +0300, Pantelis Antoniou wrote: But creation just crashes. root@beaglebone:/sys/bus/platform/drivers/omap_i2c# echo 4819c000.i2c bind [ 145.053929] Unable to handle kernel NULL pointer