Re: [PATCH-V3 3/3] ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around __omap2_set_globals

2012-06-29 Thread Tony Lindgren
* Benoit Cousson b-cous...@ti.com [120628 08:46]: On 06/28/2012 05:39 PM, Hiremath, Vaibhav wrote: On Thu, Jun 28, 2012 at 20:35:38, Cousson, Benoit wrote: OMAP4 does not have the SDRC but the EMIF like TI8XX. Benoit, This selection is happening for SOC_OMAP2420 and not for OMAP4.

[PATCH-V3 3/3] ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around __omap2_set_globals

2012-06-28 Thread Vaibhav Hiremath
The function __omap2_set_globals() can be common across all platforms/architectures, even in case of omap4, internally it calls same set of functions as in __omap2_set_globals() function (except for sdrc). This patch adds new config flag SOC_HAS_OMAP2_SDRC to handle sdrc, so that we can reuse same

Re: [PATCH-V3 3/3] ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around __omap2_set_globals

2012-06-28 Thread Benoit Cousson
Hi Vaibhav, One small comment. On 06/28/2012 04:59 PM, Vaibhav Hiremath wrote: The function __omap2_set_globals() can be common across all platforms/architectures, even in case of omap4, internally it calls same set of functions as in __omap2_set_globals() function (except for sdrc). This

RE: [PATCH-V3 3/3] ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around __omap2_set_globals

2012-06-28 Thread Hiremath, Vaibhav
On Thu, Jun 28, 2012 at 20:35:38, Cousson, Benoit wrote: Hi Vaibhav, One small comment. On 06/28/2012 04:59 PM, Vaibhav Hiremath wrote: The function __omap2_set_globals() can be common across all platforms/architectures, even in case of omap4, internally it calls same set of functions

RE: [PATCH-V3 3/3] ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around __omap2_set_globals

2012-06-28 Thread Hiremath, Vaibhav
On Thu, Jun 28, 2012 at 20:35:38, Cousson, Benoit wrote: Hi Vaibhav, One small comment. On 06/28/2012 04:59 PM, Vaibhav Hiremath wrote: The function __omap2_set_globals() can be common across all platforms/architectures, even in case of omap4, internally it calls same set of functions

Re: [PATCH-V3 3/3] ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around __omap2_set_globals

2012-06-28 Thread Benoit Cousson
On 06/28/2012 05:39 PM, Hiremath, Vaibhav wrote: On Thu, Jun 28, 2012 at 20:35:38, Cousson, Benoit wrote: Hi Vaibhav, One small comment. On 06/28/2012 04:59 PM, Vaibhav Hiremath wrote: The function __omap2_set_globals() can be common across all platforms/architectures, even in case of omap4,