Re: [PATCH 01/10] ARM: OMAP2+: PM QoS: control the power domains next state from the constraints

2012-07-19 Thread Menon, Nishanth
On Thu, Jun 14, 2012 at 10:05 AM, Jean Pihet jean.pi...@newoldbits.com wrote: Minor comment follows: [...] +/** + * _pwrdm_wakeuplat_update_pwrst - Update power domain power state if needed + * @pwrdm: struct powerdomain * to which requesting device belongs to. + * @min_latency: the allowed

Re: [PATCH 01/10] ARM: OMAP2+: PM QoS: control the power domains next state from the constraints

2012-07-19 Thread Menon, Nishanth
On Thu, Jun 14, 2012 at 10:05 AM, Jean Pihet jean.pi...@newoldbits.com wrote: +static int _pwrdm_wakeuplat_update_pwrst(struct powerdomain *pwrdm, +long min_latency) +{ + int ret = 0, state, new_state = PWRDM_FUNC_PWRST_ON; + + if

Re: [PATCH 01/10] ARM: OMAP2+: PM QoS: control the power domains next state from the constraints

2012-06-15 Thread Jean Pihet
Hi, Here are some remarks I got after an internal review. I think those points need to be discussed with a broader audience. On Thu, Jun 14, 2012 at 5:05 PM, Jean Pihet jean.pi...@newoldbits.com wrote: When a PM QoS device latency constraint is requested or removed the constraint is stored in

[PATCH 01/10] ARM: OMAP2+: PM QoS: control the power domains next state from the constraints

2012-06-14 Thread Jean Pihet
When a PM QoS device latency constraint is requested or removed the constraint is stored in the constraints list of the corresponding power domain, then the aggregated constraint value is applied by programming the next functional power state using omap_set_pwrdm_state. Tested on OMAP3