Re: [PATCH 05/11] OMAPDSS: add clk_prepare and clk_unprepare

2012-06-26 Thread Rajendra Nayak
On Wednesday 27 June 2012 09:49 AM, Tomi Valkeinen wrote: On Tue, 2012-06-26 at 17:47 -0700, Mike Turquette wrote: On 20120625-16:14, Tomi Valkeinen wrote: A question about clk_prepare/unprepare, not directly related: let's say I have a driver for some HW block. The driver doesn't use clk funct

Re: [PATCH 05/11] OMAPDSS: add clk_prepare and clk_unprepare

2012-06-26 Thread Tomi Valkeinen
On Tue, 2012-06-26 at 17:47 -0700, Mike Turquette wrote: > On 20120625-16:14, Tomi Valkeinen wrote: > > A question about clk_prepare/unprepare, not directly related: let's say > > I have a driver for some HW block. The driver doesn't use clk functions, > > but uses runtime PM. The driver also sets

Re: [PATCH 05/11] OMAPDSS: add clk_prepare and clk_unprepare

2012-06-26 Thread Mike Turquette
On 20120625-16:14, Tomi Valkeinen wrote: > A question about clk_prepare/unprepare, not directly related: let's say > I have a driver for some HW block. The driver doesn't use clk functions, > but uses runtime PM. The driver also sets pm_runtime_irq_safe(). > > Now, the driver can call pm_runtime_g

Re: [PATCH 05/11] OMAPDSS: add clk_prepare and clk_unprepare

2012-06-26 Thread Rajendra Nayak
On Tuesday 26 June 2012 12:25 PM, Tomi Valkeinen wrote: On Tue, 2012-06-26 at 10:30 +0530, Rajendra Nayak wrote: So as far as I see, clocks are never handled in atomic context. Is everything related to the base clk stuff already in mainline? Can I take the clk_prepare/unprepare patch into my om

Re: [PATCH 05/11] OMAPDSS: add clk_prepare and clk_unprepare

2012-06-25 Thread Tomi Valkeinen
On Tue, 2012-06-26 at 10:30 +0530, Rajendra Nayak wrote: > > So as far as I see, clocks are never handled in atomic context. Is > > everything related to the base clk stuff already in mainline? Can I take > > the clk_prepare/unprepare patch into my omapdss tree? > > Well the Common Clk framework

Re: [PATCH 05/11] OMAPDSS: add clk_prepare and clk_unprepare

2012-06-25 Thread Rajendra Nayak
On Monday 25 June 2012 06:44 PM, Tomi Valkeinen wrote: venc and hdmi use clk_enable/disable in runtime PM callbacks (suspend& resume). If I understand correctly, the callbacks are not called in atomic context if pm_runtime_irq_safe() has not been used. And it is not used in omapdss. dsi uses clk

Re: [PATCH 05/11] OMAPDSS: add clk_prepare and clk_unprepare

2012-06-25 Thread Tomi Valkeinen
On Mon, 2012-06-25 at 17:18 +0530, Rajendra Nayak wrote: > On Monday 25 June 2012 01:28 PM, Tomi Valkeinen wrote: > > On Mon, 2012-06-25 at 12:29 +0530, Rajendra Nayak wrote: > >> On Monday 25 June 2012 11:37 AM, Tomi Valkeinen wrote: > >>> Hi, > >>> > >>> On Fri, 2012-06-22 at 19:18 +0530, Rajendr

Re: [PATCH 05/11] OMAPDSS: add clk_prepare and clk_unprepare

2012-06-25 Thread Rajendra Nayak
On Monday 25 June 2012 01:28 PM, Tomi Valkeinen wrote: On Mon, 2012-06-25 at 12:29 +0530, Rajendra Nayak wrote: On Monday 25 June 2012 11:37 AM, Tomi Valkeinen wrote: Hi, On Fri, 2012-06-22 at 19:18 +0530, Rajendra Nayak wrote: In preparation of OMAP moving to Common Clk Framework(CCF) add cl

Re: [PATCH 05/11] OMAPDSS: add clk_prepare and clk_unprepare

2012-06-25 Thread Russell King - ARM Linux
On Mon, Jun 25, 2012 at 09:07:58AM +0300, Tomi Valkeinen wrote: > On Fri, 2012-06-22 at 19:18 +0530, Rajendra Nayak wrote: > > In preparation of OMAP moving to Common Clk Framework(CCF) add clk_prepare() > > and clk_unprepare() for the omapdss clocks. > > You used clk_prepare and clk_unprepare ins

Re: [PATCH 05/11] OMAPDSS: add clk_prepare and clk_unprepare

2012-06-25 Thread Tomi Valkeinen
On Mon, 2012-06-25 at 12:29 +0530, Rajendra Nayak wrote: > On Monday 25 June 2012 11:37 AM, Tomi Valkeinen wrote: > > Hi, > > > > On Fri, 2012-06-22 at 19:18 +0530, Rajendra Nayak wrote: > >> In preparation of OMAP moving to Common Clk Framework(CCF) add > >> clk_prepare() > >> and clk_unprepare()

Re: [PATCH 05/11] OMAPDSS: add clk_prepare and clk_unprepare

2012-06-24 Thread Rajendra Nayak
On Monday 25 June 2012 11:37 AM, Tomi Valkeinen wrote: Hi, On Fri, 2012-06-22 at 19:18 +0530, Rajendra Nayak wrote: In preparation of OMAP moving to Common Clk Framework(CCF) add clk_prepare() and clk_unprepare() for the omapdss clocks. You used clk_prepare and clk_unprepare instead of clk_pr

Re: [PATCH 05/11] OMAPDSS: add clk_prepare and clk_unprepare

2012-06-24 Thread Tomi Valkeinen
Hi, On Fri, 2012-06-22 at 19:18 +0530, Rajendra Nayak wrote: > In preparation of OMAP moving to Common Clk Framework(CCF) add clk_prepare() > and clk_unprepare() for the omapdss clocks. You used clk_prepare and clk_unprepare instead of clk_prepare_enable and clk_disable_unprepare. I didn't check

[PATCH 05/11] OMAPDSS: add clk_prepare and clk_unprepare

2012-06-22 Thread Rajendra Nayak
In preparation of OMAP moving to Common Clk Framework(CCF) add clk_prepare() and clk_unprepare() for the omapdss clocks. Signed-off-by: Rajendra Nayak Cc: Tomi Valkeinen Cc: --- drivers/video/omap2/dss/dsi.c |5 - drivers/video/omap2/dss/hdmi.c |5 - drivers/video/omap2/dss/ve