Re: [PATCH 1/1] twl4030-madc: Fix arbitrarily initialized function pointer

2008-08-04 Thread Tony Lindgren
* Viktor Rosendahl [EMAIL PROTECTED] [080703 18:37]: + req.func_cb = NULL; maybe below is a better patch: diff --git a/drivers/i2c/chips/twl4030-madc.c b/drivers/i2c/chips/twl4030-madc.c index 72b126b..6d8915e 100644 --- a/drivers/i2c/chips/twl4030-madc.c +++

Re: [PATCH 1/1] twl4030-madc: Fix arbitrarily initialized function pointer

2008-07-03 Thread Viktor Rosendahl
+ req.func_cb = NULL; maybe below is a better patch: diff --git a/drivers/i2c/chips/twl4030-madc.c b/drivers/i2c/chips/twl4030-madc.c index 72b126b..6d8915e 100644 --- a/drivers/i2c/chips/twl4030-madc.c +++ b/drivers/i2c/chips/twl4030-madc.c @@ -360,7 +360,7 @@ static

[PATCH 1/1] twl4030-madc: Fix arbitrarily initialized function pointer

2008-07-02 Thread Viktor Rosendahl
req is an automatic variable and thus we cannot rely on it being initialized to zero (I am leaving the 0!= NULL discussion aside). Other functions test if this pointer is NULL, in order to determine whether it is a valid address or not. Signed-off-by: Viktor Rosendahl [EMAIL PROTECTED] ---