Re: [PATCH 1/4] OMAP: mcbsp - add omap_mcbsp_set_dma_op_mode()

2010-05-19 Thread Jarkko Nikula
On Tue, 18 May 2010 21:13:11 +0100 Liam Girdwood l...@slimlogic.co.uk wrote: This adds a method to set the MCBSP DMA OP mode. Signed-off-by: Liam Girdwood l...@slimlogic.co.uk --- arch/arm/plat-omap/include/plat/mcbsp.h |2 ++ arch/arm/plat-omap/mcbsp.c | 31

Re: [PATCH 1/4] OMAP: mcbsp - add omap_mcbsp_set_dma_op_mode()

2010-05-19 Thread Eduardo Valentin
On Tue, May 18, 2010 at 10:13:11PM +0200, Liam Girdwood wrote: This adds a method to set the MCBSP DMA OP mode. OK. good. But again, why do you need set dma op mode other than inside mcbsp code? Right, so, from what I have read briefly, the idea is to remove the user space ability to set the

Re: [PATCH 1/4] OMAP: mcbsp - add omap_mcbsp_set_dma_op_mode()

2010-05-19 Thread Liam Girdwood
On Wed, 2010-05-19 at 13:50 +0300, Eduardo Valentin wrote: On Tue, May 18, 2010 at 10:13:11PM +0200, Liam Girdwood wrote: This adds a method to set the MCBSP DMA OP mode. OK. good. But again, why do you need set dma op mode other than inside mcbsp code? I think Peter has answered this.

[PATCH 1/4] OMAP: mcbsp - add omap_mcbsp_set_dma_op_mode()

2010-05-18 Thread Liam Girdwood
This adds a method to set the MCBSP DMA OP mode. Signed-off-by: Liam Girdwood l...@slimlogic.co.uk --- arch/arm/plat-omap/include/plat/mcbsp.h |2 ++ arch/arm/plat-omap/mcbsp.c | 31 +++ 2 files changed, 33 insertions(+), 0 deletions(-) diff --git