RE: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle

2012-11-15 Thread AnilKumar, Chimata
On Wed, Nov 14, 2012 at 15:54:53, Mark Brown wrote: On Wed, Nov 14, 2012 at 11:08:49AM +0100, Benoit Cousson wrote: I was wondering that, because exposing a pin to control the whole PMIC low power mode seems to be something that should be generic enough to be handled by the regulator

Re: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle

2012-11-14 Thread Benoit Cousson
Hi Mark, On 11/14/2012 08:00 AM, Mark Brown wrote: On Wed, Nov 14, 2012 at 06:49:58AM +, AnilKumar, Chimata wrote: Earlier you have a comment on this thread, I am adding my comments on top of it. Sorry if I am in wrong direction. Ah, I see. I was just commenting because Benoit was

Re: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle

2012-11-14 Thread Mark Brown
On Wed, Nov 14, 2012 at 11:08:49AM +0100, Benoit Cousson wrote: I was wondering that, because exposing a pin to control the whole PMIC low power mode seems to be something that should be generic enough to be handled by the regulator framework. Having something that's controlled by software is

Re: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle

2012-11-13 Thread Mark Brown
On Mon, Nov 05, 2012 at 05:59:36PM +0100, Benoit Cousson wrote: On 11/05/2012 10:42 AM, AnilKumar Ch wrote: +Optional properties: +- ti,pmic-shutdown-controller: Telling the PMIC to shutdown on PWR_EN toggle. That sounds like a generic functionality to me. Don't we have some more

RE: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle

2012-11-13 Thread AnilKumar, Chimata
On Wed, Nov 14, 2012 at 07:53:42, Mark Brown wrote: On Mon, Nov 05, 2012 at 05:59:36PM +0100, Benoit Cousson wrote: On 11/05/2012 10:42 AM, AnilKumar Ch wrote: +Optional properties: +- ti,pmic-shutdown-controller: Telling the PMIC to shutdown on PWR_EN toggle. That sounds like a

RE: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle

2012-11-13 Thread AnilKumar, Chimata
On Wed, Nov 14, 2012 at 10:40:18, AnilKumar, Chimata wrote: On Wed, Nov 14, 2012 at 07:53:42, Mark Brown wrote: On Mon, Nov 05, 2012 at 05:59:36PM +0100, Benoit Cousson wrote: On 11/05/2012 10:42 AM, AnilKumar Ch wrote: +Optional properties: +- ti,pmic-shutdown-controller: Telling

Re: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle

2012-11-13 Thread Mark Brown
On Wed, Nov 14, 2012 at 06:11:45AM +, AnilKumar, Chimata wrote: From these two threads we can infer that this is handled in power_off sequence only. And this is feature of PMIC to go to shutdown mode nothing to be fixed in silicon. PWR_EN line can be connected to any of these like PRCM

RE: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle

2012-11-13 Thread AnilKumar, Chimata
On Wed, Nov 14, 2012 at 11:51:19, Mark Brown wrote: On Wed, Nov 14, 2012 at 06:11:45AM +, AnilKumar, Chimata wrote: From these two threads we can infer that this is handled in power_off sequence only. And this is feature of PMIC to go to shutdown mode nothing to be fixed in silicon.

Re: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle

2012-11-13 Thread Mark Brown
On Wed, Nov 14, 2012 at 06:49:58AM +, AnilKumar, Chimata wrote: Earlier you have a comment on this thread, I am adding my comments on top of it. Sorry if I am in wrong direction. Ah, I see. I was just commenting because Benoit was asking if this should be supported with a standard

[PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle

2012-11-05 Thread AnilKumar Ch
From: Colin Foe-Parker colin.foepar...@logicpd.com Set tps65217 PMIC status to OFF if power enable toggle is supported. Also adds platform data flag, which should be passed from board init data. Signed-off-by: Colin Foe-Parker colin.foepar...@logicpd.com [anilku...@ti.com: move the additions to

Re: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle

2012-11-05 Thread Benoit Cousson
+ Mark On 11/05/2012 10:42 AM, AnilKumar Ch wrote: From: Colin Foe-Parker colin.foepar...@logicpd.com Set tps65217 PMIC status to OFF if power enable toggle is supported. Also adds platform data flag, which should be passed from board init data. Signed-off-by: Colin Foe-Parker

RE: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle

2012-11-05 Thread AnilKumar, Chimata
On Mon, Nov 05, 2012 at 22:29:36, Cousson, Benoit wrote: + Mark On 11/05/2012 10:42 AM, AnilKumar Ch wrote: From: Colin Foe-Parker colin.foepar...@logicpd.com Set tps65217 PMIC status to OFF if power enable toggle is supported. Also adds platform data flag, which should be passed