Re: [PATCH 1/4] usb: musb: am35x: use SIMPLE_DEV_PM_OPS

2013-10-02 Thread Daniel Mack
On 30.09.2013 18:25, Felipe Balbi wrote: On Fri, Sep 27, 2013 at 08:47:10PM +0200, Daniel Mack wrote: So are you happy with this v2? It's just a cosmetic cleanup after all ... I can't see v2 anywhere... The only version I have is the one with DEV_PM_OPS still in it. Seen them this time?

Re: [PATCH 1/4] usb: musb: am35x: use SIMPLE_DEV_PM_OPS

2013-09-30 Thread Felipe Balbi
Hi, On Fri, Sep 27, 2013 at 08:47:10PM +0200, Daniel Mack wrote: On 25.09.2013 15:48, Felipe Balbi wrote: On Tue, Sep 24, 2013 at 08:57:08AM +0200, Daniel Mack wrote: On 23.09.2013 23:20, Felipe Balbi wrote: On Sun, Sep 22, 2013 at 01:46:58PM +0200, Daniel Mack wrote: -static struct

Re: [PATCH 1/4] usb: musb: am35x: use SIMPLE_DEV_PM_OPS

2013-09-30 Thread Daniel Mack
On 30.09.2013 18:25, Felipe Balbi wrote: On Fri, Sep 27, 2013 at 08:47:10PM +0200, Daniel Mack wrote: On 25.09.2013 15:48, Felipe Balbi wrote: On Tue, Sep 24, 2013 at 08:57:08AM +0200, Daniel Mack wrote: On 23.09.2013 23:20, Felipe Balbi wrote: On Sun, Sep 22, 2013 at 01:46:58PM +0200, Daniel

Re: [PATCH 1/4] usb: musb: am35x: use SIMPLE_DEV_PM_OPS

2013-09-27 Thread Daniel Mack
On 25.09.2013 15:48, Felipe Balbi wrote: On Tue, Sep 24, 2013 at 08:57:08AM +0200, Daniel Mack wrote: On 23.09.2013 23:20, Felipe Balbi wrote: On Sun, Sep 22, 2013 at 01:46:58PM +0200, Daniel Mack wrote: -static struct dev_pm_ops am35x_pm_ops = { - .suspend= am35x_suspend, -

Re: [PATCH 1/4] usb: musb: am35x: use SIMPLE_DEV_PM_OPS

2013-09-25 Thread Felipe Balbi
On Tue, Sep 24, 2013 at 08:57:08AM +0200, Daniel Mack wrote: On 23.09.2013 23:20, Felipe Balbi wrote: On Sun, Sep 22, 2013 at 01:46:58PM +0200, Daniel Mack wrote: -static struct dev_pm_ops am35x_pm_ops = { - .suspend= am35x_suspend, - .resume = am35x_resume, -};

Re: [PATCH 1/4] usb: musb: am35x: use SIMPLE_DEV_PM_OPS

2013-09-24 Thread Daniel Mack
On 23.09.2013 23:20, Felipe Balbi wrote: On Sun, Sep 22, 2013 at 01:46:58PM +0200, Daniel Mack wrote: -static struct dev_pm_ops am35x_pm_ops = { -.suspend= am35x_suspend, -.resume = am35x_resume, -}; +static SIMPLE_DEV_PM_OPS(am35x_pm_ops, am35x_suspend,

Re: [PATCH 1/4] usb: musb: am35x: use SIMPLE_DEV_PM_OPS

2013-09-23 Thread Felipe Balbi
Hi, On Sun, Sep 22, 2013 at 01:46:58PM +0200, Daniel Mack wrote: This makes am35x_pm_ops const. Also, checkpatch.pl complains about the use of DEV_PM_OPS: ERROR: Macros with complex values should be enclosed in parenthesis Signed-off-by: Daniel Mack zon...@gmail.com ---

[PATCH 1/4] usb: musb: am35x: use SIMPLE_DEV_PM_OPS

2013-09-22 Thread Daniel Mack
This makes am35x_pm_ops const. Also, checkpatch.pl complains about the use of DEV_PM_OPS: ERROR: Macros with complex values should be enclosed in parenthesis Signed-off-by: Daniel Mack zon...@gmail.com --- drivers/usb/musb/am35x.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-)