Re: [PATCH 1/5] iommu/omap: Use the cache cleaning API

2014-03-17 Thread Suman Anna
On 03/17/2014 06:12 PM, Laurent Pinchart wrote: > Hi Arnd, > > On Friday 14 March 2014 17:57:48 Arnd Bergmann wrote: >> On Friday 14 March 2014, Santosh Shilimkar wrote: >>> I remember NAKing this approach in past and my stand remains same. The >>> cache APIs which you are trying to use here are n

Re: [PATCH 1/5] iommu/omap: Use the cache cleaning API

2014-03-17 Thread Laurent Pinchart
Hi Arnd, On Friday 14 March 2014 17:57:48 Arnd Bergmann wrote: > On Friday 14 March 2014, Santosh Shilimkar wrote: > > I remember NAKing this approach in past and my stand remains same. The > > cache APIs which you are trying to use here are not suppose to be used > > outside. > > > > I think the

Re: [PATCH 1/5] iommu/omap: Use the cache cleaning API

2014-03-17 Thread Laurent Pinchart
Hi all, On Friday 14 March 2014 20:49:56 Suman Anna wrote: > On 03/14/2014 12:51 PM, Santosh Shilimkar wrote: > > On Friday 14 March 2014 12:38 PM, Laurent Pinchart wrote: > >> On Friday 14 March 2014 12:15:11 Santosh Shilimkar wrote: > >>> On Thursday 13 March 2014 10:47 PM, Anna, Suman wrote: >

Re: [PATCH 1/5] iommu/omap: Use the cache cleaning API

2014-03-17 Thread Suman Anna
Hi Santosh, On 03/15/2014 12:54 PM, Santosh Shilimkar wrote: On Friday 14 March 2014 09:49 PM, Suman Anna wrote: Hi Santosh, Laurent, Russell, Arnd, On 03/14/2014 12:51 PM, Santosh Shilimkar wrote: On Friday 14 March 2014 12:38 PM, Laurent Pinchart wrote: Hi Santosh, On Friday 14 March 2014

Re: [PATCH 1/5] iommu/omap: Use the cache cleaning API

2014-03-15 Thread Santosh Shilimkar
On Friday 14 March 2014 09:49 PM, Suman Anna wrote: > Hi Santosh, Laurent, Russell, Arnd, > > On 03/14/2014 12:51 PM, Santosh Shilimkar wrote: >> On Friday 14 March 2014 12:38 PM, Laurent Pinchart wrote: >>> Hi Santosh, >>> >>> On Friday 14 March 2014 12:15:11 Santosh Shilimkar wrote: + Russe

Re: [PATCH 1/5] iommu/omap: Use the cache cleaning API

2014-03-14 Thread Suman Anna
Hi Santosh, Laurent, Russell, Arnd, On 03/14/2014 12:51 PM, Santosh Shilimkar wrote: On Friday 14 March 2014 12:38 PM, Laurent Pinchart wrote: Hi Santosh, On Friday 14 March 2014 12:15:11 Santosh Shilimkar wrote: + Russell, Arnd On Thursday 13 March 2014 10:47 PM, Anna, Suman wrote: On 03/0

Re: [PATCH 1/5] iommu/omap: Use the cache cleaning API

2014-03-14 Thread Santosh Shilimkar
On Friday 14 March 2014 12:57 PM, Arnd Bergmann wrote: > On Friday 14 March 2014, Santosh Shilimkar wrote: >> I remember NAKing this approach in past and my stand remains same. >> The cache APIs which you are trying to use here are not suppose >> to be used outside. >> >> I think the right way to f

Re: [PATCH 1/5] iommu/omap: Use the cache cleaning API

2014-03-14 Thread Santosh Shilimkar
On Friday 14 March 2014 12:38 PM, Laurent Pinchart wrote: > Hi Santosh, > > On Friday 14 March 2014 12:15:11 Santosh Shilimkar wrote: >> + Russell, Arnd >> >> On Thursday 13 March 2014 10:47 PM, Anna, Suman wrote: >>> On 03/07/2014 06:46 PM, Laurent Pinchart wrote: The page table entries must

Re: [PATCH 1/5] iommu/omap: Use the cache cleaning API

2014-03-14 Thread Arnd Bergmann
On Friday 14 March 2014, Santosh Shilimkar wrote: > I remember NAKing this approach in past and my stand remains same. > The cache APIs which you are trying to use here are not suppose > to be used outside. > > I think the right way to fix this is to make use of streaming APIs. > If needed, IOMMU

Re: [PATCH 1/5] iommu/omap: Use the cache cleaning API

2014-03-14 Thread Laurent Pinchart
Hi Santosh, On Friday 14 March 2014 12:15:11 Santosh Shilimkar wrote: > + Russell, Arnd > > On Thursday 13 March 2014 10:47 PM, Anna, Suman wrote: > > On 03/07/2014 06:46 PM, Laurent Pinchart wrote: > >> The page table entries must be cleaned from the cache before being > >> accessed by the IOMMU

Re: [PATCH 1/5] iommu/omap: Use the cache cleaning API

2014-03-14 Thread Santosh Shilimkar
+ Russell, Arnd On Thursday 13 March 2014 10:47 PM, Anna, Suman wrote: > Hi Laurent, > > On 03/07/2014 06:46 PM, Laurent Pinchart wrote: >> The page table entries must be cleaned from the cache before being >> accessed by the IOMMU. Instead of implementing cache management manually >> (and ignori

Re: [PATCH 1/5] iommu/omap: Use the cache cleaning API

2014-03-13 Thread Suman Anna
Hi Laurent, On 03/07/2014 06:46 PM, Laurent Pinchart wrote: The page table entries must be cleaned from the cache before being accessed by the IOMMU. Instead of implementing cache management manually (and ignoring L2 cache), use clean_dcache_area() to make sure the entries are visible to the dev

[PATCH 1/5] iommu/omap: Use the cache cleaning API

2014-03-07 Thread Laurent Pinchart
The page table entries must be cleaned from the cache before being accessed by the IOMMU. Instead of implementing cache management manually (and ignoring L2 cache), use clean_dcache_area() to make sure the entries are visible to the device. Signed-off-by: Laurent Pinchart --- drivers/iommu/omap-