Re: [PATCH 1/6] OMAPDSS: DISPC: cleanup cpu_is_xxxx checks

2012-08-14 Thread Tomi Valkeinen
On Mon, 2012-08-13 at 17:28 +0530, Chandrabhanu Mahapatra wrote: All the cpu_is checks have been moved to dispc_init_features function providing a much more generic and cleaner interface. The OMAP version and revision specific functions and data are initialized by dispc_features structure

Re: [PATCH 1/6] OMAPDSS: DISPC: cleanup cpu_is_xxxx checks

2012-08-14 Thread Mahapatra, Chandrabhanu
+static const struct __initdata dispc_features omap2_dispc_features = { + .hp_max = 256, + .vp_max = 255, + .sw_max = 64, + .sw_start = 5, + .fp_start = 15,

Re: [PATCH 1/6] OMAPDSS: DISPC: cleanup cpu_is_xxxx checks

2012-08-14 Thread Tomi Valkeinen
On Tue, 2012-08-14 at 17:33 +0530, Mahapatra, Chandrabhanu wrote: +static const struct __initdata dispc_features omap2_dispc_features = { + .hp_max = 256, + .vp_max = 255, + .sw_max = 64, +

[PATCH 1/6] OMAPDSS: DISPC: cleanup cpu_is_xxxx checks

2012-08-13 Thread Chandrabhanu Mahapatra
All the cpu_is checks have been moved to dispc_init_features function providing a much more generic and cleaner interface. The OMAP version and revision specific functions and data are initialized by dispc_features structure which is local to dispc.c. Signed-off-by: Chandrabhanu Mahapatra

[PATCH 1/6] OMAPDSS: DISPC: cleanup cpu_is_xxxx checks

2012-08-08 Thread Chandrabhanu Mahapatra
All the cpu_is checks have been moved to dispc_init_features function providing a much more generic and cleaner interface. The OMAP version and revision specific functions are initialized by dispc_features structure local to dispc.c. Signed-off-by: Chandrabhanu Mahapatra cmahapa...@ti.com ---

Re: [PATCH 1/6] OMAPDSS: DISPC: cleanup cpu_is_xxxx checks

2012-08-08 Thread Tomi Valkeinen
On Wed, 2012-08-08 at 17:07 +0530, Chandrabhanu Mahapatra wrote: All the cpu_is checks have been moved to dispc_init_features function providing a much more generic and cleaner interface. The OMAP version and revision specific functions are initialized by dispc_features structure local to

Re: [PATCH 1/6] OMAPDSS: DISPC: cleanup cpu_is_xxxx checks

2012-08-08 Thread Mahapatra, Chandrabhanu
On Wed, Aug 8, 2012 at 6:06 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Wed, 2012-08-08 at 17:07 +0530, Chandrabhanu Mahapatra wrote: All the cpu_is checks have been moved to dispc_init_features function providing a much more generic and cleaner interface. The OMAP version and revision

Re: [PATCH 1/6] OMAPDSS: DISPC: cleanup cpu_is_xxxx checks

2012-08-08 Thread Tomi Valkeinen
On Wed, 2012-08-08 at 18:31 +0530, Mahapatra, Chandrabhanu wrote: Yes, this sounds good, but I was just following general order of structure and function declarations, structures initializations followed by functions. Yep, it's a good rule. But there are exceptions when we'll get bloated code