Re: [PATCH 1/8] clk: divider: fix rate calculation for fractional rates

2014-03-18 Thread Mike Turquette
Quoting Tomi Valkeinen (2014-03-17 05:53:03) > On 27/02/14 04:25, Mike Turquette wrote: > > Quoting Tero Kristo (2014-02-14 05:45:22) > >> On 02/13/2014 12:03 PM, Tomi Valkeinen wrote: > >>> clk-divider.c does not calculate the rates consistently at the moment. > >>> > >>> As an example, on OMAP3 w

Re: [PATCH 1/8] clk: divider: fix rate calculation for fractional rates

2014-03-17 Thread Tomi Valkeinen
On 27/02/14 04:25, Mike Turquette wrote: > Quoting Tero Kristo (2014-02-14 05:45:22) >> On 02/13/2014 12:03 PM, Tomi Valkeinen wrote: >>> clk-divider.c does not calculate the rates consistently at the moment. >>> >>> As an example, on OMAP3 we have a clock divider with a source clock of >>> 864

Re: [PATCH 1/8] clk: divider: fix rate calculation for fractional rates

2014-02-28 Thread Tomi Valkeinen
On 27/02/14 04:25, Mike Turquette wrote: >> Basically the patch looks good to me, but it might be good to have a >> testing round of sort with this. It can potentially cause regressions on >> multiple boards if the drivers happen to rely on the "broken" clock >> rates. Same for patch #2 which i

Re: [PATCH 1/8] clk: divider: fix rate calculation for fractional rates

2014-02-26 Thread Mike Turquette
Quoting Tero Kristo (2014-02-14 05:45:22) > On 02/13/2014 12:03 PM, Tomi Valkeinen wrote: > > clk-divider.c does not calculate the rates consistently at the moment. > > > > As an example, on OMAP3 we have a clock divider with a source clock of > > 86400 Hz. With dividers 6, 7 and 8 the theoreti

Re: [PATCH 1/8] clk: divider: fix rate calculation for fractional rates

2014-02-14 Thread Tero Kristo
On 02/13/2014 12:03 PM, Tomi Valkeinen wrote: clk-divider.c does not calculate the rates consistently at the moment. As an example, on OMAP3 we have a clock divider with a source clock of 86400 Hz. With dividers 6, 7 and 8 the theoretical rates are: 6: 14400 7: 123428571.428571... 8: 10

[PATCH 1/8] clk: divider: fix rate calculation for fractional rates

2014-02-13 Thread Tomi Valkeinen
clk-divider.c does not calculate the rates consistently at the moment. As an example, on OMAP3 we have a clock divider with a source clock of 86400 Hz. With dividers 6, 7 and 8 the theoretical rates are: 6: 14400 7: 123428571.428571... 8: 10800 Calling clk_round_rate() with the rate