Re: [PATCH 13/16] ARM: omap: move platform_data definitions
On Tuesday 18 September 2012, Peter Ujfalusi wrote: I thought I have replied to this... Whichever way you prefer. I can craft a series to clean up the plat/mcbsp.h usage and move the mcbsp header via ASoC tree. I'm also fine if you do the move. Let me know what you prefer. I think I'll just keep all my patches together then, and leave this one in. Arnd -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 13/16] ARM: omap: move platform_data definitions
Hi Arnd, On 09/12/2012 08:20 PM, Arnd Bergmann wrote: On Tuesday 11 September 2012, Peter Ujfalusi wrote: OMAP McBSP has nothing to do with a dsp. A better name would be: ti-mcbsp.h (or leave it as mcbsp.h) McBSP stands for: Multichannel Buffered Serial Port and it is used for audio connection (I2S, TDM, etc). changed to asoc-ti-mcbsp.h to, as discussed. .../include/plat/dsp.h = include/linux/platform_data/dsp-omap.h |0 .../plat/keypad.h = include/linux/platform_data/keypad-omap.h |0 .../plat/lcd_mipid.h = include/linux/platform_data/lcd-mipid.h|0 .../plat/nand.h = include/linux/platform_data/mtd-nand-omap2.h|0 .../onenand.h = include/linux/platform_data/mtd-onenand-omap2.h |0 .../remoteproc.h = include/linux/platform_data/remoteproc-omap.h |0 .../voltage.h = include/linux/platform_data/smartreflex-omap.h|0 .../plat/mcspi.h = include/linux/platform_data/spi-omap2-mcspi.h |0 include/linux/power/smartreflex.h |2 +- Let me see these: This four drivers are going to be removed via sound tree. sound/soc/omap/igep0020.c |2 +- sound/soc/omap/omap3beagle.c |2 +- sound/soc/omap/omap3evm.c |2 +- sound/soc/omap/overo.c |2 +- The new driver which replaces these (omap-twl4030.c) does not include plat/mcbsp.h For the sake of bisection, I think we should leave the patch as is. When merging the two branches, we will get a small conflict that is trivial to resolve. From these ASoC machine drivers you can just remove the plat/mcbsp.h include since they should not include them (I have pending patch for this to be sent): sound/soc/omap/am3517evm.c |2 +- sound/soc/omap/ams-delta.c |2 +- sound/soc/omap/n810.c |2 +- sound/soc/omap/omap3pandora.c |2 +- sound/soc/omap/osk5912.c |2 +- sound/soc/omap/rx51.c |2 +- sound/soc/omap/sdp3430.c |2 +- sound/soc/omap/zoom2.c |2 +- sound/soc/omap/omap-mcbsp.c|2 +- sound/soc/omap/mcbsp.c |2 +- Can you do that change on top of mine? I would prefer to leave it as is because I could create this version with a script. The alternative is that I leave the mcbsp.h file alone entirely and you submit a patch to fix all instances where it's used, either rename or remove them. I thought I have replied to this... Whichever way you prefer. I can craft a series to clean up the plat/mcbsp.h usage and move the mcbsp header via ASoC tree. I'm also fine if you do the move. Let me know what you prefer. Thanks, Péter -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 13/16] ARM: omap: move platform_data definitions
Hi Arnd, On Tue, Sep 11, 2012 at 2:59 PM, Arnd Bergmann a...@arndb.de wrote: Platform data for device drivers should be defined in include/linux/platform_data/*.h, not in the architecture and platform specific directories. This moves such data out of the omap include directories Signed-off-by: Arnd Bergmann a...@arndb.de ... diff --git a/arch/arm/mach-omap2/voltage.h b/arch/arm/mach-omap2/voltage.h index 0ac2caf..7abf1c0 100644 --- a/arch/arm/mach-omap2/voltage.h +++ b/arch/arm/mach-omap2/voltage.h @@ -16,7 +16,7 @@ #include linux/err.h -#include plat/voltage.h +#include linux/platform_data/smartreflex-omap.h #include vc.h #include vp.h ... diff --git a/arch/arm/plat-omap/include/plat/voltage.h b/include/linux/platform_data/smartreflex-omap.h similarity index 100% rename from arch/arm/plat-omap/include/plat/voltage.h rename to include/linux/platform_data/smartreflex-omap.h The filename should be voltage-omap.h. The header file is for a voltage layer which is used by other layers, one of them is the smartreflex driver code (in drivers/power/avs). The header file for the smartreflex driver is in include/linux/power/smartreflex.h. diff --git a/include/linux/power/smartreflex.h b/include/linux/power/smartreflex.h index 3101e62..e376f94 100644 --- a/include/linux/power/smartreflex.h +++ b/include/linux/power/smartreflex.h @@ -23,7 +23,7 @@ #include linux/types.h #include linux/platform_device.h #include linux/delay.h -#include plat/voltage.h +#include linux/platform_data/smartreflex-omap.h /* * Different Smartreflex IPs version. The v1 is the 65nm version used in Thanks for the clean-up! Regards, Jean -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 13/16] ARM: omap: move platform_data definitions
On Wednesday 12 September 2012, Pihet-XID, Jean wrote: diff --git a/arch/arm/plat-omap/include/plat/voltage.h b/include/linux/platform_data/smartreflex-omap.h similarity index 100% rename from arch/arm/plat-omap/include/plat/voltage.h rename to include/linux/platform_data/smartreflex-omap.h The filename should be voltage-omap.h. The header file is for a voltage layer which is used by other layers, one of them is the smartreflex driver code (in drivers/power/avs). The header file for the smartreflex driver is in include/linux/power/smartreflex.h. Ok, makes sense. Changed now. Arnd -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 13/16] ARM: omap: move platform_data definitions
On Tuesday 11 September 2012, Peter Ujfalusi wrote: OMAP McBSP has nothing to do with a dsp. A better name would be: ti-mcbsp.h (or leave it as mcbsp.h) McBSP stands for: Multichannel Buffered Serial Port and it is used for audio connection (I2S, TDM, etc). changed to asoc-ti-mcbsp.h to, as discussed. .../include/plat/dsp.h = include/linux/platform_data/dsp-omap.h |0 .../plat/keypad.h = include/linux/platform_data/keypad-omap.h |0 .../plat/lcd_mipid.h = include/linux/platform_data/lcd-mipid.h|0 .../plat/nand.h = include/linux/platform_data/mtd-nand-omap2.h|0 .../onenand.h = include/linux/platform_data/mtd-onenand-omap2.h |0 .../remoteproc.h = include/linux/platform_data/remoteproc-omap.h |0 .../voltage.h = include/linux/platform_data/smartreflex-omap.h|0 .../plat/mcspi.h = include/linux/platform_data/spi-omap2-mcspi.h |0 include/linux/power/smartreflex.h |2 +- Let me see these: This four drivers are going to be removed via sound tree. sound/soc/omap/igep0020.c |2 +- sound/soc/omap/omap3beagle.c |2 +- sound/soc/omap/omap3evm.c |2 +- sound/soc/omap/overo.c |2 +- The new driver which replaces these (omap-twl4030.c) does not include plat/mcbsp.h For the sake of bisection, I think we should leave the patch as is. When merging the two branches, we will get a small conflict that is trivial to resolve. From these ASoC machine drivers you can just remove the plat/mcbsp.h include since they should not include them (I have pending patch for this to be sent): sound/soc/omap/am3517evm.c |2 +- sound/soc/omap/ams-delta.c |2 +- sound/soc/omap/n810.c |2 +- sound/soc/omap/omap3pandora.c |2 +- sound/soc/omap/osk5912.c |2 +- sound/soc/omap/rx51.c |2 +- sound/soc/omap/sdp3430.c |2 +- sound/soc/omap/zoom2.c |2 +- sound/soc/omap/omap-mcbsp.c|2 +- sound/soc/omap/mcbsp.c |2 +- Can you do that change on top of mine? I would prefer to leave it as is because I could create this version with a script. The alternative is that I leave the mcbsp.h file alone entirely and you submit a patch to fix all instances where it's used, either rename or remove them. Arnd -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 13/16] ARM: omap: move platform_data definitions
On Wed, Sep 12, 2012 at 7:15 PM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 12 September 2012, Pihet-XID, Jean wrote: diff --git a/arch/arm/plat-omap/include/plat/voltage.h b/include/linux/platform_data/smartreflex-omap.h similarity index 100% rename from arch/arm/plat-omap/include/plat/voltage.h rename to include/linux/platform_data/smartreflex-omap.h The filename should be voltage-omap.h. The header file is for a voltage layer which is used by other layers, one of them is the smartreflex driver code (in drivers/power/avs). The header file for the smartreflex driver is in include/linux/power/smartreflex.h. Ok, makes sense. Changed now. Great, thanks! Jean Arnd -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 13/16] ARM: omap: move platform_data definitions
Platform data for device drivers should be defined in include/linux/platform_data/*.h, not in the architecture and platform specific directories. This moves such data out of the omap include directories Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Tony Lindgren t...@atomide.com Cc: Kevin Hilman khil...@ti.com Cc: Benoît Cousson b-cous...@ti.com Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc: David Woodhouse dw...@infradead.org Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Ohad Ben-Cohen o...@wizery.com Cc: Grant Likely grant.lik...@secretlab.ca Cc: Omar Ramirez Luna omar.rami...@ti.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Tomi Valkeinen tomi.valkei...@ti.com Cc: Florian Tobias Schandinat florianschandi...@gmx.de Cc: Peter Ujfalusi peter.ujfal...@ti.com Cc: Jarkko Nikula jarkko.nik...@bitmer.com Cc: Liam Girdwood l...@ti.com Cc: Mark Brown broo...@opensource.wolfsonmicro.com Cc: Artem Bityutskiy artem.bityuts...@linux.intel.com Cc: Jean Pihet j-pi...@ti.com Cc: J Keerthy j-keer...@ti.com Cc: linux-omap@vger.kernel.org --- arch/arm/mach-omap1/board-ams-delta.c |2 +- arch/arm/mach-omap1/board-fsample.c|2 +- arch/arm/mach-omap1/board-h2.c |2 +- arch/arm/mach-omap1/board-h3.c |2 +- arch/arm/mach-omap1/board-htcherald.c |2 +- arch/arm/mach-omap1/board-innovator.c |2 +- arch/arm/mach-omap1/board-nokia770.c |4 ++-- arch/arm/mach-omap1/board-osk.c|2 +- arch/arm/mach-omap1/board-palmte.c |2 +- arch/arm/mach-omap1/board-palmtt.c |2 +- arch/arm/mach-omap1/board-palmz71.c|2 +- arch/arm/mach-omap1/board-perseus2.c |2 +- arch/arm/mach-omap1/board-sx1.c|2 +- arch/arm/mach-omap1/mcbsp.c|2 +- arch/arm/mach-omap2/board-3430sdp.c|2 +- arch/arm/mach-omap2/board-cm-t35.c |4 ++-- arch/arm/mach-omap2/board-cm-t3517.c |2 +- arch/arm/mach-omap2/board-devkit8000.c |4 ++-- arch/arm/mach-omap2/board-flash.c |4 ++-- arch/arm/mach-omap2/board-igep0020.c |2 +- arch/arm/mach-omap2/board-ldp.c|2 +- arch/arm/mach-omap2/board-n8x0.c |4 ++-- arch/arm/mach-omap2/board-omap3beagle.c|2 +- arch/arm/mach-omap2/board-omap3evm.c |4 ++-- arch/arm/mach-omap2/board-omap3pandora.c |4 ++-- arch/arm/mach-omap2/board-omap3stalker.c |4 ++-- arch/arm/mach-omap2/board-omap3touchbook.c |4 ++-- arch/arm/mach-omap2/board-overo.c |4 ++-- arch/arm/mach-omap2/board-rm680.c |2 +- arch/arm/mach-omap2/board-rx51-peripherals.c |4 ++-- arch/arm/mach-omap2/board-rx51-video.c |2 +- arch/arm/mach-omap2/board-rx51.c |2 +- arch/arm/mach-omap2/board-zoom-display.c |2 +- arch/arm/mach-omap2/common-board-devices.c |4 ++-- arch/arm/mach-omap2/devices.c |2 +- arch/arm/mach-omap2/dsp.c |2 +- arch/arm/mach-omap2/gpmc-nand.c|2 +- arch/arm/mach-omap2/gpmc-onenand.c |2 +- arch/arm/mach-omap2/mcbsp.c|2 +- arch/arm/mach-omap2/omap_hwmod_2420_data.c |2 +- arch/arm/mach-omap2/omap_hwmod_2430_data.c |4 ++-- arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c |2 +- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |4 ++-- arch/arm/mach-omap2/omap_hwmod_44xx_data.c |4 ++-- arch/arm/mach-omap2/voltage.h |2 +- arch/arm/plat-omap/common.c|2 +- drivers/input/keyboard/omap-keypad.c |2 +- drivers/mtd/nand/omap2.c |2 +- drivers/mtd/onenand/omap2.c|2 +- drivers/remoteproc/omap_remoteproc.c |2 +-
[PATCH 13/16] ARM: omap: move platform_data definitions
Platform data for device drivers should be defined in include/linux/platform_data/*.h, not in the architecture and platform specific directories. This moves such data out of the omap include directories Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Tony Lindgren t...@atomide.com Cc: Kevin Hilman khil...@ti.com Cc: Benoît Cousson b-cous...@ti.com Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc: David Woodhouse dw...@infradead.org Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Ohad Ben-Cohen o...@wizery.com Cc: Grant Likely grant.lik...@secretlab.ca Cc: Omar Ramirez Luna omar.rami...@ti.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Tomi Valkeinen tomi.valkei...@ti.com Cc: Florian Tobias Schandinat florianschandi...@gmx.de Cc: Peter Ujfalusi peter.ujfal...@ti.com Cc: Jarkko Nikula jarkko.nik...@bitmer.com Cc: Liam Girdwood l...@ti.com Cc: Mark Brown broo...@opensource.wolfsonmicro.com Cc: Artem Bityutskiy artem.bityuts...@linux.intel.com Cc: Jean Pihet j-pi...@ti.com Cc: J Keerthy j-keer...@ti.com Cc: linux-omap@vger.kernel.org --- arch/arm/mach-omap1/board-ams-delta.c |2 +- arch/arm/mach-omap1/board-fsample.c|2 +- arch/arm/mach-omap1/board-h2.c |2 +- arch/arm/mach-omap1/board-h3.c |2 +- arch/arm/mach-omap1/board-htcherald.c |2 +- arch/arm/mach-omap1/board-innovator.c |2 +- arch/arm/mach-omap1/board-nokia770.c |4 ++-- arch/arm/mach-omap1/board-osk.c|2 +- arch/arm/mach-omap1/board-palmte.c |2 +- arch/arm/mach-omap1/board-palmtt.c |2 +- arch/arm/mach-omap1/board-palmz71.c|2 +- arch/arm/mach-omap1/board-perseus2.c |2 +- arch/arm/mach-omap1/board-sx1.c|2 +- arch/arm/mach-omap1/mcbsp.c|2 +- arch/arm/mach-omap2/board-3430sdp.c|2 +- arch/arm/mach-omap2/board-cm-t35.c |4 ++-- arch/arm/mach-omap2/board-cm-t3517.c |2 +- arch/arm/mach-omap2/board-devkit8000.c |4 ++-- arch/arm/mach-omap2/board-flash.c |4 ++-- arch/arm/mach-omap2/board-igep0020.c |2 +- arch/arm/mach-omap2/board-ldp.c|2 +- arch/arm/mach-omap2/board-n8x0.c |4 ++-- arch/arm/mach-omap2/board-omap3beagle.c|2 +- arch/arm/mach-omap2/board-omap3evm.c |4 ++-- arch/arm/mach-omap2/board-omap3pandora.c |4 ++-- arch/arm/mach-omap2/board-omap3stalker.c |4 ++-- arch/arm/mach-omap2/board-omap3touchbook.c |4 ++-- arch/arm/mach-omap2/board-overo.c |4 ++-- arch/arm/mach-omap2/board-rm680.c |2 +- arch/arm/mach-omap2/board-rx51-peripherals.c |4 ++-- arch/arm/mach-omap2/board-rx51-video.c |2 +- arch/arm/mach-omap2/board-rx51.c |2 +- arch/arm/mach-omap2/board-zoom-display.c |2 +- arch/arm/mach-omap2/common-board-devices.c |4 ++-- arch/arm/mach-omap2/devices.c |2 +- arch/arm/mach-omap2/dsp.c |2 +- arch/arm/mach-omap2/gpmc-nand.c|2 +- arch/arm/mach-omap2/gpmc-onenand.c |2 +- arch/arm/mach-omap2/mcbsp.c|2 +- arch/arm/mach-omap2/omap_hwmod_2420_data.c |2 +- arch/arm/mach-omap2/omap_hwmod_2430_data.c |4 ++-- arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c |2 +- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |4 ++-- arch/arm/mach-omap2/omap_hwmod_44xx_data.c |4 ++-- arch/arm/mach-omap2/voltage.h |2 +- arch/arm/plat-omap/common.c|2 +- drivers/input/keyboard/omap-keypad.c |2 +- drivers/mtd/nand/omap2.c |2 +- drivers/mtd/onenand/omap2.c|2 +- drivers/remoteproc/omap_remoteproc.c |2 +-
Re: [PATCH 13/16] ARM: omap: move platform_data definitions
Hi Arnd, On 09/11/2012 03:59 PM, Arnd Bergmann wrote: Platform data for device drivers should be defined in include/linux/platform_data/*.h, not in the architecture and platform specific directories. This moves such data out of the omap include directories Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Tony Lindgren t...@atomide.com Cc: Kevin Hilman khil...@ti.com Cc: Benoît Cousson b-cous...@ti.com Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc: David Woodhouse dw...@infradead.org Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Ohad Ben-Cohen o...@wizery.com Cc: Grant Likely grant.lik...@secretlab.ca Cc: Omar Ramirez Luna omar.rami...@ti.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Tomi Valkeinen tomi.valkei...@ti.com Cc: Florian Tobias Schandinat florianschandi...@gmx.de Cc: Peter Ujfalusi peter.ujfal...@ti.com Cc: Jarkko Nikula jarkko.nik...@bitmer.com Cc: Liam Girdwood l...@ti.com Cc: Mark Brown broo...@opensource.wolfsonmicro.com Cc: Artem Bityutskiy artem.bityuts...@linux.intel.com Cc: Jean Pihet j-pi...@ti.com Cc: J Keerthy j-keer...@ti.com Cc: linux-omap@vger.kernel.org --- arch/arm/mach-omap1/board-ams-delta.c |2 +- arch/arm/mach-omap1/board-fsample.c|2 +- arch/arm/mach-omap1/board-h2.c |2 +- arch/arm/mach-omap1/board-h3.c |2 +- arch/arm/mach-omap1/board-htcherald.c |2 +- arch/arm/mach-omap1/board-innovator.c |2 +- arch/arm/mach-omap1/board-nokia770.c |4 ++-- arch/arm/mach-omap1/board-osk.c|2 +- arch/arm/mach-omap1/board-palmte.c |2 +- arch/arm/mach-omap1/board-palmtt.c |2 +- arch/arm/mach-omap1/board-palmz71.c|2 +- arch/arm/mach-omap1/board-perseus2.c |2 +- arch/arm/mach-omap1/board-sx1.c|2 +- arch/arm/mach-omap1/mcbsp.c|2 +- arch/arm/mach-omap2/board-3430sdp.c|2 +- arch/arm/mach-omap2/board-cm-t35.c |4 ++-- arch/arm/mach-omap2/board-cm-t3517.c |2 +- arch/arm/mach-omap2/board-devkit8000.c |4 ++-- arch/arm/mach-omap2/board-flash.c |4 ++-- arch/arm/mach-omap2/board-igep0020.c |2 +- arch/arm/mach-omap2/board-ldp.c|2 +- arch/arm/mach-omap2/board-n8x0.c |4 ++-- arch/arm/mach-omap2/board-omap3beagle.c|2 +- arch/arm/mach-omap2/board-omap3evm.c |4 ++-- arch/arm/mach-omap2/board-omap3pandora.c |4 ++-- arch/arm/mach-omap2/board-omap3stalker.c |4 ++-- arch/arm/mach-omap2/board-omap3touchbook.c |4 ++-- arch/arm/mach-omap2/board-overo.c |4 ++-- arch/arm/mach-omap2/board-rm680.c |2 +- arch/arm/mach-omap2/board-rx51-peripherals.c |4 ++-- arch/arm/mach-omap2/board-rx51-video.c |2 +- arch/arm/mach-omap2/board-rx51.c |2 +- arch/arm/mach-omap2/board-zoom-display.c |2 +- arch/arm/mach-omap2/common-board-devices.c |4 ++-- arch/arm/mach-omap2/devices.c |2 +- arch/arm/mach-omap2/dsp.c |2 +- arch/arm/mach-omap2/gpmc-nand.c|2 +- arch/arm/mach-omap2/gpmc-onenand.c |2 +- arch/arm/mach-omap2/mcbsp.c|2 +- arch/arm/mach-omap2/omap_hwmod_2420_data.c |2 +- arch/arm/mach-omap2/omap_hwmod_2430_data.c |4 ++-- arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c |2 +- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |4 ++-- arch/arm/mach-omap2/omap_hwmod_44xx_data.c |4 ++-- arch/arm/mach-omap2/voltage.h |2 +- arch/arm/plat-omap/common.c|2 +- drivers/input/keyboard/omap-keypad.c |2 +- drivers/mtd/nand/omap2.c |2 +-
Re: [PATCH 13/16] ARM: omap: move platform_data definitions
Arnd, On Tue, Sep 11, 2012 at 6:32 PM, Arnd Bergmann a...@arndb.de wrote: Platform data for device drivers should be defined in include/linux/platform_data/*.h, not in the architecture and platform specific directories. This moves such data out of the omap include directories Signed-off-by: Arnd Bergmann a...@arndb.de [...] 81 files changed, 87 insertions(+), 87 deletions(-) rename arch/arm/plat-omap/include/plat/mcbsp.h = include/linux/platform_data/dsp-mcbsp.h (100%) rename arch/arm/plat-omap/include/plat/dsp.h = include/linux/platform_data/dsp-omap.h (100%) rename arch/arm/plat-omap/include/plat/keypad.h = include/linux/platform_data/keypad-omap.h (100%) rename arch/arm/plat-omap/include/plat/lcd_mipid.h = include/linux/platform_data/lcd-mipid.h (100%) rename arch/arm/plat-omap/include/plat/nand.h = include/linux/platform_data/mtd-nand-omap2.h (100%) rename arch/arm/plat-omap/include/plat/onenand.h = include/linux/platform_data/mtd-onenand-omap2.h (100%) rename arch/arm/plat-omap/include/plat/remoteproc.h = include/linux/platform_data/remoteproc-omap.h (100%) rename arch/arm/plat-omap/include/plat/voltage.h = include/linux/platform_data/smartreflex-omap.h (100%) rename arch/arm/plat-omap/include/plat/mcspi.h = include/linux/platform_data/spi-omap2-mcspi.h (100%) Just curious to know how you came with some of the above header names ? plat/mcbsp --- dsp-mcbsp.h There is no connection of DSP with McBSP. omap-mcbsp.h would been a better name. plat/nand.h -- /mtd-nand-omap2.h plat/onenand.h -- /mtd-onenand-omap2.h May be omap-nand.h and omap-onenand.h plat/mcspi.h--spi-omap2-mcspi.h May be omap-spi.h Regards, Santosh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 13/16] ARM: omap: move platform_data definitions
On Tuesday 11 September 2012, Shilimkar, Santosh wrote: Just curious to know how you came with some of the above header names ? plat/mcbsp --- dsp-mcbsp.h There is no connection of DSP with McBSP. omap-mcbsp.h would been a better name. This one was a mistake on my side, as Tony and Peter already pointed out. How about asoc-mcbsp.h or asoc-omap-mcbsp.h? plat/nand.h -- /mtd-nand-omap2.h plat/onenand.h -- /mtd-onenand-omap2.h May be omap-nand.h and omap-onenand.h plat/mcspi.h--spi-omap2-mcspi.h May be omap-spi.h As I wrote in the introductory mail, I tried to always prefix the file names with the subsystem, followed by the name of the driver, in order to standardize on just one set of rules. The drivers implementing the three headers above are: drivers/mtd/nand/omap2.c drivers/mtd/onenand/omap2.c drivers/spi/spi-omap2-mcspi.c so these all seem appropriate. Arnd -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 13/16] ARM: omap: move platform_data definitions
On Tue, Sep 11, 2012 at 7:47 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 11 September 2012, Shilimkar, Santosh wrote: Just curious to know how you came with some of the above header names ? plat/mcbsp --- dsp-mcbsp.h There is no connection of DSP with McBSP. omap-mcbsp.h would been a better name. This one was a mistake on my side, as Tony and Peter already pointed out. How about asoc-mcbsp.h or asoc-omap-mcbsp.h? After re-reading the cover-letter and your below response, 'asoc-omap-mcbsp.h' seems to be fine. plat/nand.h -- /mtd-nand-omap2.h plat/onenand.h -- /mtd-onenand-omap2.h May be omap-nand.h and omap-onenand.h plat/mcspi.h--spi-omap2-mcspi.h May be omap-spi.h As I wrote in the introductory mail, I tried to always prefix the file names with the subsystem, followed by the name of the driver, in order to standardize on just one set of rules. Just read that now. The drivers implementing the three headers above are: drivers/mtd/nand/omap2.c drivers/mtd/onenand/omap2.c drivers/spi/spi-omap2-mcspi.c so these all seem appropriate. Sorry I missed the subsystem prefix point. These names seems to be fine then. Regards Santosh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 13/16] ARM: omap: move platform_data definitions
On 9/11/2012 7:54 PM, Shilimkar, Santosh wrote: On Tue, Sep 11, 2012 at 7:47 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 11 September 2012, Shilimkar, Santosh wrote: Just curious to know how you came with some of the above header names ? plat/mcbsp --- dsp-mcbsp.h There is no connection of DSP with McBSP. omap-mcbsp.h would been a better name. This one was a mistake on my side, as Tony and Peter already pointed out. How about asoc-mcbsp.h or asoc-omap-mcbsp.h? After re-reading the cover-letter and your below response, 'asoc-omap-mcbsp.h' seems to be fine. Note that mcbsp is also applicable to Davinci family of devices. Thanks, Vaibhav plat/nand.h -- /mtd-nand-omap2.h plat/onenand.h -- /mtd-onenand-omap2.h May be omap-nand.h and omap-onenand.h plat/mcspi.h--spi-omap2-mcspi.h May be omap-spi.h As I wrote in the introductory mail, I tried to always prefix the file names with the subsystem, followed by the name of the driver, in order to standardize on just one set of rules. Just read that now. The drivers implementing the three headers above are: drivers/mtd/nand/omap2.c drivers/mtd/onenand/omap2.c drivers/spi/spi-omap2-mcspi.c so these all seem appropriate. Sorry I missed the subsystem prefix point. These names seems to be fine then. Regards Santosh ___ linux-arm-kernel mailing list linux-arm-ker...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 13/16] ARM: omap: move platform_data definitions
* Arnd Bergmann a...@arndb.de [120911 10:05]: On Tuesday 11 September 2012, Vaibhav Hiremath wrote: On 9/11/2012 7:54 PM, Shilimkar, Santosh wrote: On Tue, Sep 11, 2012 at 7:47 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 11 September 2012, Shilimkar, Santosh wrote: Just curious to know how you came with some of the above header names ? plat/mcbsp --- dsp-mcbsp.h There is no connection of DSP with McBSP. omap-mcbsp.h would been a better name. This one was a mistake on my side, as Tony and Peter already pointed out. How about asoc-mcbsp.h or asoc-omap-mcbsp.h? After re-reading the cover-letter and your below response, 'asoc-omap-mcbsp.h' seems to be fine. Note that mcbsp is also applicable to Davinci family of devices. asoc-ti-mcbsp.h then? Sounds good to me. Whatever the name ends up being: Acked-by: Tony Lindgren t...@atomide.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
