[PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-28 Thread Thomas Renninger
Recent changes: - Enable EVENT_POWER_TRACING_DEPRECATED by default New power trace events: power:cpu_idle power:cpu_frequency power:machine_suspend C-state/idle accounting events: power:power_start power:power_end are replaced with: power:cpu_idle and power:power_frequency is

Re: [PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-28 Thread Rafael J. Wysocki
On Thursday, October 28, 2010, Thomas Renninger wrote: Recent changes: - Enable EVENT_POWER_TRACING_DEPRECATED by default New power trace events: power:cpu_idle power:cpu_frequency power:machine_suspend C-state/idle accounting events: power:power_start power:power_end are

Re: [linux-pm] [PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-28 Thread Rafael J. Wysocki
On Thursday, October 28, 2010, Rafael J. Wysocki wrote: On Thursday, October 28, 2010, Thomas Renninger wrote: Recent changes: - Enable EVENT_POWER_TRACING_DEPRECATED by default New power trace events: power:cpu_idle power:cpu_frequency power:machine_suspend C-state/idle

[PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-28 Thread Thomas Renninger
Recent changes: - Enable EVENT_POWER_TRACING_DEPRECATED by default New power trace events: power:cpu_idle power:cpu_frequency power:machine_suspend C-state/idle accounting events: power:power_start power:power_end are replaced with: power:cpu_idle and power:power_frequency is

Re: [PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-25 Thread Arjan van de Ven
On 10/19/2010 4:36 AM, Thomas Renninger wrote: static void poll_idle(void) { - trace_power_start(POWER_CSTATE, 0, smp_processor_id()); local_irq_enable(); while (!need_resched()) cpu_relax(); - trace_power_end(0); } why did you remove the idle

Re: [PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-25 Thread Arjan van de Ven
On 10/19/2010 4:36 AM, Thomas Renninger wrote: New power trace events: power:processor_idle power:processor_frequency power:machine_suspend C-state/idle accounting events: power:power_start power:power_end are replaced with: power:processor_idle I think you need two trace points for

Re: [PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-25 Thread Thomas Renninger
On Monday 25 October 2010 08:54:34 Arjan van de Ven wrote: On 10/19/2010 4:36 AM, Thomas Renninger wrote: static void poll_idle(void) { - trace_power_start(POWER_CSTATE, 0, smp_processor_id()); local_irq_enable(); while (!need_resched()) cpu_relax(); -

Re: [PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-25 Thread Ingo Molnar
* Thomas Renninger tr...@suse.de wrote: New power trace events: power:processor_idle power:processor_frequency power:machine_suspend C-state/idle accounting events: power:power_start power:power_end are replaced with: power:processor_idle Well, most power saving hw models

Re: [PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-25 Thread Thomas Renninger
On Monday 25 October 2010 12:04:28 Ingo Molnar wrote: * Thomas Renninger tr...@suse.de wrote: New power trace events: power:processor_idle power:processor_frequency power:machine_suspend C-state/idle accounting events: power:power_start power:power_end are replaced

Re: [PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-25 Thread Ingo Molnar
* Thomas Renninger tr...@suse.de wrote: On Monday 25 October 2010 12:04:28 Ingo Molnar wrote: * Thomas Renninger tr...@suse.de wrote: New power trace events: power:processor_idle power:processor_frequency power:machine_suspend C-state/idle accounting events:

Re: [PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-25 Thread Thomas Renninger
On Monday 25 October 2010 13:55:25 Ingo Molnar wrote: * Thomas Renninger tr...@suse.de wrote: On Monday 25 October 2010 12:04:28 Ingo Molnar wrote: * Thomas Renninger tr...@suse.de wrote: New power trace events: power:processor_idle power:processor_frequency

Re: [PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-25 Thread Mathieu Desnoyers
* Ingo Molnar (mi...@elte.hu) wrote: * Thomas Renninger tr...@suse.de wrote: On Monday 25 October 2010 12:04:28 Ingo Molnar wrote: * Thomas Renninger tr...@suse.de wrote: New power trace events: power:processor_idle power:processor_frequency power:machine_suspend

Re: [PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-25 Thread Arjan van de Ven
On 10/25/2010 2:41 AM, Thomas Renninger wrote: On Monday 25 October 2010 08:54:34 Arjan van de Ven wrote: On 10/19/2010 4:36 AM, Thomas Renninger wrote: static void poll_idle(void) { - trace_power_start(POWER_CSTATE, 0, smp_processor_id()); local_irq_enable(); while

Re: [PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-25 Thread Arjan van de Ven
On 10/25/2010 4:03 AM, Thomas Renninger wrote: On Monday 25 October 2010 12:04:28 Ingo Molnar wrote: * Thomas Renningertr...@suse.de wrote: New power trace events: power:processor_idle power:processor_frequency power:machine_suspend C-state/idle accounting events: power:power_start

Re: [PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-25 Thread Arjan van de Ven
On 10/25/2010 5:55 AM, Thomas Renninger wrote: But the actual code does not actually deal with any 'state 0', does it? It does. Not being idle is tracked by cpuidle driver as state 0 (arch independent): /sys/devices/system/cpu/cpu0/cpuidle/state0/ halt/C1 on X86 is:

Re: [PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-25 Thread Thomas Renninger
On Monday 25 October 2010 15:55:08 Arjan van de Ven wrote: On 10/25/2010 2:41 AM, Thomas Renninger wrote: On Monday 25 October 2010 08:54:34 Arjan van de Ven wrote: On 10/19/2010 4:36 AM, Thomas Renninger wrote: static void poll_idle(void) { - trace_power_start(POWER_CSTATE, 0,

Re: [PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-25 Thread Arjan van de Ven
On 10/25/2010 7:36 AM, Thomas Renninger wrote: I know that your new API tries to use 0 as exit, but 0 is already taken (in all power terminology at least on x86 it is) for this. cpuidle indeed misuses C0 as poll idle state. That's really bad/misleading, but nothing that can be changed easily.

Re: [PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-25 Thread Thomas Renninger
On Monday 25 October 2010 16:56:04 Ingo Molnar wrote: * Arjan van de Ven ar...@linux.intel.com wrote: On 10/25/2010 7:36 AM, Thomas Renninger wrote: ok so we have C0 idle Ideally this should not be called C0, but expressed as (#define) POLL_IDLE wherever possible. In all

Re: [PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-25 Thread Arjan van de Ven
On 10/25/2010 8:48 AM, Thomas Renninger wrote: On Monday 25 October 2010 16:56:04 Ingo Molnar wrote: * Arjan van de Venar...@linux.intel.com wrote: On 10/25/2010 7:36 AM, Thomas Renninger wrote: ok so we have C0 idle Ideally this should not be called C0, but expressed as (#define) POLL_IDLE

Re: [PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-25 Thread Rafael J. Wysocki
On Monday, October 25, 2010, Mathieu Desnoyers wrote: * Ingo Molnar (mi...@elte.hu) wrote: * Thomas Renninger tr...@suse.de wrote: On Monday 25 October 2010 12:04:28 Ingo Molnar wrote: * Thomas Renninger tr...@suse.de wrote: New power trace events:

Re: [PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-25 Thread Rafael J. Wysocki
On Monday, October 25, 2010, Arjan van de Ven wrote: On 10/25/2010 4:03 AM, Thomas Renninger wrote: On Monday 25 October 2010 12:04:28 Ingo Molnar wrote: * Thomas Renningertr...@suse.de wrote: New power trace events: power:processor_idle power:processor_frequency

Re: [PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-25 Thread Thomas Renninger
@Ingo: Can you queue up 1/3, it's an independent fix. On Monday 25 October 2010 06:00:17 pm Arjan van de Ven wrote: On 10/25/2010 8:48 AM, Thomas Renninger wrote: sure naming is one thing Yes it should get renamed to not show: cat /sys/devices/system/cpu/cpu0/cpuidle/state0/name C0 This is