Re: [PATCH 25/25] ARM: pm: omap34xx: convert to generic suspend/resume support

2011-06-23 Thread Tony Lindgren
* Russell King - ARM Linux li...@arm.linux.org.uk [110622 08:24]: Convert sa11x0 to use the generic CPU suspend/resume support, rather ^^ Should be omap34xx above. than implementing its own version. Tested on 3430 LDP. Nice job with this series Russell! Tony -- To unsubscribe

Re: [PATCH 25/25] ARM: pm: omap34xx: convert to generic suspend/resume support

2011-06-23 Thread Russell King - ARM Linux
On Wed, Jun 22, 2011 at 04:16:58PM +0100, Russell King - ARM Linux wrote: + /* Now branch to the common CPU resume function */ + ldr r0, =cpu_resume + bx r0 + .ltorg A slight correction - firstly this code does not run from SRAM. Secondly, this will try to branch

Re: [PATCH 25/25] ARM: pm: omap34xx: convert to generic suspend/resume support

2011-06-23 Thread Russell King - ARM Linux
On Thu, Jun 23, 2011 at 11:06:10AM +0100, Russell King - ARM Linux wrote: On Wed, Jun 22, 2011 at 04:16:58PM +0100, Russell King - ARM Linux wrote: + /* Now branch to the common CPU resume function */ + ldr r0, =cpu_resume + bx r0 + .ltorg A slight correction -

Re: [PATCH 25/25] ARM: pm: omap34xx: convert to generic suspend/resume support

2011-06-23 Thread Russell King - ARM Linux
On Thu, Jun 23, 2011 at 05:03:39AM +0530, Santosh Shilimkar wrote: On 6/22/2011 9:40 PM, Russell King - ARM Linux wrote: A couple of things to point out here: On Wed, Jun 22, 2011 at 04:16:58PM +0100, Russell King - ARM Linux wrote: - mrc p15, 0, r4, c13, c0, 1 @ Context ID - mrc

Re: [PATCH 25/25] ARM: pm: omap34xx: convert to generic suspend/resume support

2011-06-23 Thread Kevin Hilman
Hi Russell, Russell King - ARM Linux li...@arm.linux.org.uk writes: Convert sa11x0 to use the generic CPU suspend/resume support, rather than implementing its own version. Tested on 3430 LDP. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk I tested this on 3430/n900 and 3530/Overo

Re: [PATCH 25/25] ARM: pm: omap34xx: convert to generic suspend/resume support

2011-06-23 Thread Kevin Hilman
Kevin Hilman khil...@ti.com writes: Hi Russell, Russell King - ARM Linux li...@arm.linux.org.uk writes: Convert sa11x0 to use the generic CPU suspend/resume support, rather than implementing its own version. Tested on 3430 LDP. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk I

Re: [PATCH 25/25] ARM: pm: omap34xx: convert to generic suspend/resume support

2011-06-23 Thread Kevin Hilman
Kevin Hilman khil...@ti.com writes: Hi Russell, Russell King - ARM Linux li...@arm.linux.org.uk writes: Convert sa11x0 to use the generic CPU suspend/resume support, rather than implementing its own version. Tested on 3430 LDP. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk I

[PATCH 25/25] ARM: pm: omap34xx: convert to generic suspend/resume support

2011-06-22 Thread Russell King - ARM Linux
Convert sa11x0 to use the generic CPU suspend/resume support, rather than implementing its own version. Tested on 3430 LDP. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- arch/arm/mach-omap2/pm34xx.c| 39 ++-- arch/arm/mach-omap2/sleep34xx.S | 130

Re: [PATCH 25/25] ARM: pm: omap34xx: convert to generic suspend/resume support

2011-06-22 Thread Russell King - ARM Linux
A couple of things to point out here: On Wed, Jun 22, 2011 at 04:16:58PM +0100, Russell King - ARM Linux wrote: - mrc p15, 0, r4, c13, c0, 1 @ Context ID - mrc p15, 0, r5, c13, c0, 2 @ User r/w thread and process ID - mrc p15, 0, r6, c12, c0, 0 @ Secure or NS vector

Re: [PATCH 25/25] ARM: pm: omap34xx: convert to generic suspend/resume support

2011-06-22 Thread Santosh Shilimkar
On 6/22/2011 9:40 PM, Russell King - ARM Linux wrote: A couple of things to point out here: On Wed, Jun 22, 2011 at 04:16:58PM +0100, Russell King - ARM Linux wrote: - mrc p15, 0, r4, c13, c0, 1 @ Context ID - mrc p15, 0, r5, c13, c0, 2 @ User r/w thread and process ID -