Re: [PATCH 3/3] OMAP4: powerdomain data: Fix core mem states and missing cefuse flag

2011-07-01 Thread Cousson, Benoit

On 7/1/2011 1:48 AM, Paul Walmsley wrote:

On Thu, 23 Jun 2011, Benoit Cousson wrote:


Since ES2.0, the core ocmram does not support a different state
than the main power domain anymore during both ON and RET power
domain state.
Since PM is not supported at all in ES1.0, update the common
structure.

LOWPOWERSTATECHANGE is supported by the cefuse power domain but
the flag was missing.
Add the PWRDM_HAS_LOWPOWERSTATECHANGE in flags field.

Indent all previous flags to be aligned with other fields.

Update the TI copyright date to 2011.

Signed-off-by: Benoit Coussonb-cous...@ti.com
Cc: Paul Walmsleyp...@pwsan.com
Cc: Rajendra Nayakrna...@ti.com
Cc: Santosh Shilimkarsantosh.shilim...@ti.com


Reviewed-by: Paul Walmsleyp...@pwsan.com

I guess the CEFUSE LOWPOWERSTATECHANGE bit is in the Security TRM?


Good question... but I think so.

Benoit

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 3/3] OMAP4: powerdomain data: Fix core mem states and missing cefuse flag

2011-06-30 Thread Paul Walmsley
On Thu, 23 Jun 2011, Benoit Cousson wrote:

 Since ES2.0, the core ocmram does not support a different state
 than the main power domain anymore during both ON and RET power
 domain state.
 Since PM is not supported at all in ES1.0, update the common
 structure.
 
 LOWPOWERSTATECHANGE is supported by the cefuse power domain but
 the flag was missing.
 Add the PWRDM_HAS_LOWPOWERSTATECHANGE in flags field.
 
 Indent all previous flags to be aligned with other fields.
 
 Update the TI copyright date to 2011.
 
 Signed-off-by: Benoit Cousson b-cous...@ti.com
 Cc: Paul Walmsley p...@pwsan.com
 Cc: Rajendra Nayak rna...@ti.com
 Cc: Santosh Shilimkar santosh.shilim...@ti.com

Reviewed-by: Paul Walmsley p...@pwsan.com

I guess the CEFUSE LOWPOWERSTATECHANGE bit is in the Security TRM?


- Paul
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 3/3] OMAP4: powerdomain data: Fix core mem states and missing cefuse flag

2011-06-23 Thread Benoit Cousson
Since ES2.0, the core ocmram does not support a different state
than the main power domain anymore during both ON and RET power
domain state.
Since PM is not supported at all in ES1.0, update the common
structure.

LOWPOWERSTATECHANGE is supported by the cefuse power domain but
the flag was missing.
Add the PWRDM_HAS_LOWPOWERSTATECHANGE in flags field.

Indent all previous flags to be aligned with other fields.

Update the TI copyright date to 2011.

Signed-off-by: Benoit Cousson b-cous...@ti.com
Cc: Paul Walmsley p...@pwsan.com
Cc: Rajendra Nayak rna...@ti.com
Cc: Santosh Shilimkar santosh.shilim...@ti.com
---
 arch/arm/mach-omap2/powerdomains44xx_data.c |   25 +
 1 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/arch/arm/mach-omap2/powerdomains44xx_data.c 
b/arch/arm/mach-omap2/powerdomains44xx_data.c
index c4222c7..8f46e7d 100644
--- a/arch/arm/mach-omap2/powerdomains44xx_data.c
+++ b/arch/arm/mach-omap2/powerdomains44xx_data.c
@@ -1,7 +1,7 @@
 /*
  * OMAP4 Power domains framework
  *
- * Copyright (C) 2009-2010 Texas Instruments, Inc.
+ * Copyright (C) 2009-2011 Texas Instruments, Inc.
  * Copyright (C) 2009-2011 Nokia Corporation
  *
  * Abhijit Pagare (abhijitpag...@ti.com)
@@ -41,19 +41,19 @@ static struct powerdomain core_44xx_pwrdm = {
.banks= 5,
.pwrsts_mem_ret = {
[0] = PWRSTS_OFF,   /* core_nret_bank */
-   [1] = PWRSTS_OFF_RET,   /* core_ocmram */
+   [1] = PWRSTS_RET,   /* core_ocmram */
[2] = PWRSTS_RET,   /* core_other_bank */
[3] = PWRSTS_OFF_RET,   /* ducati_l2ram */
[4] = PWRSTS_OFF_RET,   /* ducati_unicache */
},
.pwrsts_mem_on  = {
[0] = PWRSTS_ON,/* core_nret_bank */
-   [1] = PWRSTS_OFF_RET,   /* core_ocmram */
+   [1] = PWRSTS_ON,/* core_ocmram */
[2] = PWRSTS_ON,/* core_other_bank */
[3] = PWRSTS_ON,/* ducati_l2ram */
[4] = PWRSTS_ON,/* ducati_unicache */
},
-   .flags  = PWRDM_HAS_LOWPOWERSTATECHANGE,
+   .flags= PWRDM_HAS_LOWPOWERSTATECHANGE,
 };
 
 /* gfx_44xx_pwrdm: 3D accelerator power domain */
@@ -70,7 +70,7 @@ static struct powerdomain gfx_44xx_pwrdm = {
.pwrsts_mem_on  = {
[0] = PWRSTS_ON,/* gfx_mem */
},
-   .flags  = PWRDM_HAS_LOWPOWERSTATECHANGE,
+   .flags= PWRDM_HAS_LOWPOWERSTATECHANGE,
 };
 
 /* abe_44xx_pwrdm: Audio back end power domain */
@@ -90,7 +90,7 @@ static struct powerdomain abe_44xx_pwrdm = {
[0] = PWRSTS_ON,/* aessmem */
[1] = PWRSTS_ON,/* periphmem */
},
-   .flags  = PWRDM_HAS_LOWPOWERSTATECHANGE,
+   .flags= PWRDM_HAS_LOWPOWERSTATECHANGE,
 };
 
 /* dss_44xx_pwrdm: Display subsystem power domain */
@@ -108,7 +108,7 @@ static struct powerdomain dss_44xx_pwrdm = {
.pwrsts_mem_on  = {
[0] = PWRSTS_ON,/* dss_mem */
},
-   .flags  = PWRDM_HAS_LOWPOWERSTATECHANGE,
+   .flags= PWRDM_HAS_LOWPOWERSTATECHANGE,
 };
 
 /* tesla_44xx_pwrdm: Tesla processor power domain */
@@ -130,7 +130,7 @@ static struct powerdomain tesla_44xx_pwrdm = {
[1] = PWRSTS_ON,/* tesla_l1 */
[2] = PWRSTS_ON,/* tesla_l2 */
},
-   .flags  = PWRDM_HAS_LOWPOWERSTATECHANGE,
+   .flags= PWRDM_HAS_LOWPOWERSTATECHANGE,
 };
 
 /* wkup_44xx_pwrdm: Wake-up power domain */
@@ -241,7 +241,7 @@ static struct powerdomain ivahd_44xx_pwrdm = {
[2] = PWRSTS_ON,/* tcm1_mem */
[3] = PWRSTS_ON,/* tcm2_mem */
},
-   .flags  = PWRDM_HAS_LOWPOWERSTATECHANGE,
+   .flags= PWRDM_HAS_LOWPOWERSTATECHANGE,
 };
 
 /* cam_44xx_pwrdm: Camera subsystem power domain */
@@ -258,7 +258,7 @@ static struct powerdomain cam_44xx_pwrdm = {
.pwrsts_mem_on  = {
[0] = PWRSTS_ON,/* cam_mem */
},
-   .flags  = PWRDM_HAS_LOWPOWERSTATECHANGE,
+   .flags= PWRDM_HAS_LOWPOWERSTATECHANGE,
 };
 
 /* l3init_44xx_pwrdm: L3 initators pheripherals power domain  */
@@ -276,7 +276,7 @@ static struct powerdomain l3init_44xx_pwrdm = {
.pwrsts_mem_on  = {
[0] = PWRSTS_ON,/* l3init_bank1 */
},
-   .flags  = PWRDM_HAS_LOWPOWERSTATECHANGE,
+   .flags= PWRDM_HAS_LOWPOWERSTATECHANGE,
 };
 
 /* l4per_44xx_pwrdm: Target peripherals power domain */
@@ -296,7 +296,7 @@ static struct powerdomain l4per_44xx_pwrdm = {
[0] = PWRSTS_ON,/* nonretained_bank */
[1] = PWRSTS_ON,/* retained_bank */
},
-   .flags  = PWRDM_HAS_LOWPOWERSTATECHANGE,
+