Re: [PATCH 3/5] ARM: omap3evm: enable VBUS switch for EHCI tranceiver

2012-07-08 Thread Zumeng Chen 

于 2012年07月06日 16:41, Tony Lindgren 写道:

* Sergei Shtylyovsshtyl...@mvista.com  [120620 05:10]:

On 20-06-2012 13:14, Zumeng Chen wrote:

This will set TWL4030.GPIO2 as output pin to drive EHCI tranceiver.

...


+   /* Enable VBUS switch by setting TWL4030.GPIO2DIR as output
+* for starting USB tranceiver
+*/
+   if (get_omap3_evm_rev()= OMAP3EVM_BOARD_GEN_2) {
+   u8 val;

Empty line after declaration block wouldn't hurt...


I'll apply these into devel-board branch with the extra line
added. Not taking the clock related patch 4/5 as that's something
Paul should queue.

Also note that the board-*.c files are being phased out with
devicetree support.

Thanks Tony for your comments, I understand all of them.

Regards,
Zumeng


Regards,

Tony


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/5] ARM: omap3evm: enable VBUS switch for EHCI tranceiver

2012-07-06 Thread Tony Lindgren 
* Sergei Shtylyov sshtyl...@mvista.com [120620 05:10]:
 On 20-06-2012 13:14, Zumeng Chen wrote:
 
 This will set TWL4030.GPIO2 as output pin to drive EHCI tranceiver.
...

 +/* Enable VBUS switch by setting TWL4030.GPIO2DIR as output
 + * for starting USB tranceiver
 + */
 +if (get_omap3_evm_rev()= OMAP3EVM_BOARD_GEN_2) {
 +u8 val;
 
Empty line after declaration block wouldn't hurt...
 

I'll apply these into devel-board branch with the extra line
added. Not taking the clock related patch 4/5 as that's something
Paul should queue.

Also note that the board-*.c files are being phased out with
devicetree support.

Regards,

Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/5] ARM: omap3evm: enable VBUS switch for EHCI tranceiver

2012-06-20 Thread Zumeng Chen 
This was chosen by following the trace on the schematic from component U131
and U134 to the CPEN pin on the USB3320 device.

TWL4030.GPIO2-...-(T2_GPIO2_3V3)U131-..nUSB2_EN-..U134-..EXP_nUSB2_1V8
which starts EHCI tranceiver USB3320.

This will set TWL4030.GPIO2 as output pin to drive EHCI tranceiver.

Signed-off-by: Zumeng Chen zumeng.c...@windriver.com
---
 arch/arm/mach-omap2/board-omap3evm.c |9 +
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap3evm.c 
b/arch/arm/mach-omap2/board-omap3evm.c
index 1bfbe42..02d8047 100644
--- a/arch/arm/mach-omap2/board-omap3evm.c
+++ b/arch/arm/mach-omap2/board-omap3evm.c
@@ -360,6 +360,15 @@ static int omap3evm_twl_gpio_setup(struct device *dev,
 
platform_device_register(leds_gpio);
 
+   /* Enable VBUS switch by setting TWL4030.GPIO2DIR as output
+* for starting USB tranceiver
+*/
+   if (get_omap3_evm_rev() = OMAP3EVM_BOARD_GEN_2) {
+   u8 val;
+   twl_i2c_read_u8(TWL4030_MODULE_GPIO, val, REG_GPIODATADIR1);
+   val |= 0x04; /* TWL4030.GPIO2DIR BIT at GPIODATADIR1(0x9B) */
+   twl_i2c_write_u8(TWL4030_MODULE_GPIO, val, REG_GPIODATADIR1);
+   }
return 0;
 }
 
-- 
1.7.5.4

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/5] ARM: omap3evm: enable VBUS switch for EHCI tranceiver

2012-06-20 Thread Sergei Shtylyov 

Hello.

On 20-06-2012 13:14, Zumeng Chen wrote:


This was chosen by following the trace on the schematic from component U131
and U134 to the CPEN pin on the USB3320 device.



TWL4030.GPIO2-...-(T2_GPIO2_3V3)U131-..nUSB2_EN-..U134-..EXP_nUSB2_1V8
which starts EHCI tranceiver USB3320.



This will set TWL4030.GPIO2 as output pin to drive EHCI tranceiver.



Signed-off-by: Zumeng Chenzumeng.c...@windriver.com
---
  arch/arm/mach-omap2/board-omap3evm.c |9 +
  1 files changed, 9 insertions(+), 0 deletions(-)



diff --git a/arch/arm/mach-omap2/board-omap3evm.c 
b/arch/arm/mach-omap2/board-omap3evm.c
index 1bfbe42..02d8047 100644
--- a/arch/arm/mach-omap2/board-omap3evm.c
+++ b/arch/arm/mach-omap2/board-omap3evm.c
@@ -360,6 +360,15 @@ static int omap3evm_twl_gpio_setup(struct device *dev,

platform_device_register(leds_gpio);

+   /* Enable VBUS switch by setting TWL4030.GPIO2DIR as output
+* for starting USB tranceiver
+*/
+   if (get_omap3_evm_rev()= OMAP3EVM_BOARD_GEN_2) {
+   u8 val;


   Empty line after declaration block wouldn't hurt...


+   twl_i2c_read_u8(TWL4030_MODULE_GPIO,val, REG_GPIODATADIR1);
+   val |= 0x04; /* TWL4030.GPIO2DIR BIT at GPIODATADIR1(0x9B) */
+   twl_i2c_write_u8(TWL4030_MODULE_GPIO, val, REG_GPIODATADIR1);
+   }
return 0;
  }


WBR, Sergei
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/5] ARM: omap3evm: enable VBUS switch for EHCI tranceiver

2012-06-20 Thread Zumeng Chen 

于 2012年06月20日 20:05, Sergei Shtylyov 写道:

Hello.

On 20-06-2012 13:14, Zumeng Chen wrote:

This was chosen by following the trace on the schematic from 
component U131

and U134 to the CPEN pin on the USB3320 device.


TWL4030.GPIO2-...-(T2_GPIO2_3V3)U131-..nUSB2_EN-..U134-..EXP_nUSB2_1V8 


which starts EHCI tranceiver USB3320.



This will set TWL4030.GPIO2 as output pin to drive EHCI tranceiver.



Signed-off-by: Zumeng Chenzumeng.c...@windriver.com
---
arch/arm/mach-omap2/board-omap3evm.c | 9 +
1 files changed, 9 insertions(+), 0 deletions(-)


diff --git a/arch/arm/mach-omap2/board-omap3evm.c 
b/arch/arm/mach-omap2/board-omap3evm.c

index 1bfbe42..02d8047 100644
--- a/arch/arm/mach-omap2/board-omap3evm.c
+++ b/arch/arm/mach-omap2/board-omap3evm.c
@@ -360,6 +360,15 @@ static int omap3evm_twl_gpio_setup(struct device 
*dev,


platform_device_register(leds_gpio);

+ /* Enable VBUS switch by setting TWL4030.GPIO2DIR as output
+ * for starting USB tranceiver
+ */
+ if (get_omap3_evm_rev()= OMAP3EVM_BOARD_GEN_2) {
+ u8 val;


Empty line after declaration block wouldn't hurt...

Yes, Agreed.

Regards,
Zumeng



+ twl_i2c_read_u8(TWL4030_MODULE_GPIO,val, REG_GPIODATADIR1);
+ val |= 0x04; /* TWL4030.GPIO2DIR BIT at GPIODATADIR1(0x9B) */
+ twl_i2c_write_u8(TWL4030_MODULE_GPIO, val, REG_GPIODATADIR1);
+ }
return 0;
}


WBR, Sergei


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html