Re: [PATCH 3/5] omap3: cm-t3517: add support for usb host.

2010-09-27 Thread Tony Lindgren
* Igor Grinberg grinb...@compulab.co.il [100922 01:16]: It should be okay to execute this code independent of whether the driver is built or not. The device registration can be unconditional and if there is no driver present, we won't probe anyway. The current patch looks OK to me, adding

Re: [PATCH 3/5] omap3: cm-t3517: add support for usb host.

2010-09-22 Thread Igor Grinberg
On 09/21/10 18:26, Gadiyar, Anand wrote: On Tue, Sep 21, 2010 at 9:33 PM, Igor Grinberg grinb...@compulab.co.il wrote: add support for hsusb host ports 1, 2 and on-module usb hub. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-omap2/board-cm-t3517.c | 50

Re: [PATCH 3/5] omap3: cm-t3517: add support for usb host.

2010-09-21 Thread Felipe Balbi
On Mon, Sep 20, 2010 at 09:46:34AM -0500, Igor Grinberg wrote: On 09/20/10 08:39, Felipe Balbi wrote: On Thu, Sep 16, 2010 at 04:12:06AM -0500, Igor Grinberg wrote: Yes it will, but even if the hub reset gpio is for some reason unavailable, we don't want to disable ehci completely... then

[PATCH 3/5] omap3: cm-t3517: add support for usb host.

2010-09-21 Thread Igor Grinberg
add support for hsusb host ports 1, 2 and on-module usb hub. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-omap2/board-cm-t3517.c | 50 ++ 1 files changed, 50 insertions(+), 0 deletions(-) diff --git

Re: [PATCH 3/5] omap3: cm-t3517: add support for usb host.

2010-09-21 Thread Gadiyar, Anand
On Tue, Sep 21, 2010 at 9:33 PM, Igor Grinberg grinb...@compulab.co.il wrote: add support for hsusb host ports 1, 2 and on-module usb hub. Signed-off-by: Igor Grinberg grinb...@compulab.co.il ---  arch/arm/mach-omap2/board-cm-t3517.c |   50 ++ ... @@

Re: [PATCH 3/5] omap3: cm-t3517: add support for usb host.

2010-09-20 Thread Igor Grinberg
On 09/20/10 08:39, Felipe Balbi wrote: On Thu, Sep 16, 2010 at 04:12:06AM -0500, Igor Grinberg wrote: Yes it will, but even if the hub reset gpio is for some reason unavailable, we don't want to disable ehci completely... then you should set the gpio to an invalid number, otherwise you might

Re: [PATCH 3/5] omap3: cm-t3517: add support for usb host.

2010-09-19 Thread Igor Grinberg
On 09/16/10 19:48, Tony Lindgren wrote: * Igor Grinberg grinb...@compulab.co.il [100916 02:04]: Hi, On 09/16/10 11:00, Felipe Balbi wrote: Hi, On Thu, Sep 16, 2010 at 03:54:39AM -0500, Igor Grinberg wrote: put a description here. This is a relatively small patch, is the subject not

[PATCH 3/5] omap3: cm-t3517: add support for usb host.

2010-09-16 Thread Igor Grinberg
Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-omap2/board-cm-t3517.c | 51 ++ 1 files changed, 51 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-cm-t3517.c b/arch/arm/mach-omap2/board-cm-t3517.c index

Re: [PATCH 3/5] omap3: cm-t3517: add support for usb host.

2010-09-16 Thread Felipe Balbi
Hi, On Thu, Sep 16, 2010 at 03:54:39AM -0500, Igor Grinberg wrote: put a description here. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- [snip] +static int cm_t3517_init_usbh(void) +{ + int err; + + err = gpio_request(USB_HUB_RESET_GPIO, usb hub rst); + if

Re: [PATCH 3/5] omap3: cm-t3517: add support for usb host.

2010-09-16 Thread Igor Grinberg
Hi, On 09/16/10 11:00, Felipe Balbi wrote: Hi, On Thu, Sep 16, 2010 at 03:54:39AM -0500, Igor Grinberg wrote: put a description here. This is a relatively small patch, is the subject not descriptive enough? Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- [snip] +static int

Re: [PATCH 3/5] omap3: cm-t3517: add support for usb host.

2010-09-16 Thread Tony Lindgren
* Igor Grinberg grinb...@compulab.co.il [100916 02:04]: Hi, On 09/16/10 11:00, Felipe Balbi wrote: Hi, On Thu, Sep 16, 2010 at 03:54:39AM -0500, Igor Grinberg wrote: put a description here. This is a relatively small patch, is the subject not descriptive enough? In that case