Re: [PATCH 5/8] ARM: OMAP2+: PM: introduce power domains achievable functional states

2012-07-19 Thread Menon, Nishanth
On Fri, Jun 15, 2012 at 6:28 AM, Jean Pihet jean.pi...@newoldbits.com wrote: 1. The while loops need optimization. - This can definitely be simplified and made non-risky; this also needs some more error handling If you are interested using something like the following static int

Re: [PATCH 5/8] ARM: OMAP2+: PM: introduce power domains achievable functional states

2012-06-15 Thread Jean Pihet
Hi, Here are some remarks I got after an internal review. I think those points need to be discussed with a broader audience. On Thu, Jun 14, 2012 at 4:53 PM, Jean Pihet jean.pi...@newoldbits.com wrote: Note: the patch is in RFC state because the state machine for setting the next power domain

[PATCH 5/8] ARM: OMAP2+: PM: introduce power domains achievable functional states

2012-06-14 Thread Jean Pihet
Note: the patch is in RFC state because the state machine for setting the next power domain states needs more discussion. Validated on OMAP34 with cpuidle and suspend/resume, though. Power domains have varied capabilities. When attempting a low power state such as OFF/RET, a specific min