Re: [PATCH 7/7] omap3 evm, beagle and overo use the generic twl4030 script

2008-10-14 Thread David Brownell
On Monday 13 October 2008, Peter 'p2' De Schrijver wrote: +extern struct twl4030_power_data generic3430_t2scripts_data; Such extern decls should as a rule be in header files... In this case the rule is appropriate, since you've got the same decl in three different places.  That's

Re: [PATCH 7/7] omap3 evm, beagle and overo use the generic twl4030 script

2008-10-13 Thread Peter 'p2' De Schrijver
On Fri, Oct 10, 2008 at 10:50:29AM -0700, ext David Brownell wrote: On Friday 10 October 2008, Peter 'p2' De Schrijver wrote: +extern struct twl4030_power_data generic3430_t2scripts_data; Such extern decls should as a rule be in header files... In this case the rule is appropriate, since

[PATCH 7/7] omap3 evm, beagle and overo use the generic twl4030 script

2008-10-13 Thread Peter 'p2' De Schrijver
Make omap3 evm, beagle and overo use the generic twl4030 script. Signed-off-by: Peter 'p2' De Schrijver [EMAIL PROTECTED] --- arch/arm/mach-omap2/Makefile|9 ++--- arch/arm/mach-omap2/board-omap3beagle.c |4 ++-- arch/arm/mach-omap2/board-omap3evm.c|4 ++--

[PATCH 7/7] omap3 evm, beagle and overo use the generic twl4030 script

2008-10-10 Thread Peter 'p2' De Schrijver
Make omap3 evm, beagle and overo use the generic twl4030 script. Signed-off-by: Peter 'p2' De Schrijver [EMAIL PROTECTED] --- arch/arm/mach-omap2/Makefile|9 ++--- arch/arm/mach-omap2/board-omap3beagle.c |3 +++ arch/arm/mach-omap2/board-omap3evm.c|3 +++

Re: [PATCH 7/7] omap3 evm, beagle and overo use the generic twl4030 script

2008-10-10 Thread David Brownell
On Friday 10 October 2008, Peter 'p2' De Schrijver wrote: +extern struct twl4030_power_data generic3430_t2scripts_data; Such extern decls should as a rule be in header files... In this case the rule is appropriate, since you've got the same decl in three different places. That's about two