Re: [PATCH 8/8] gpio/omap: fix missing check in *_runtime_suspend()

2012-05-18 Thread Kevin Hilman
Grant Likely writes: >> Grant, after Tarun/Santosh have a chance to review/ack this, can you >> still get this in for 3.5? If not, getting it into -rc should be fine. > > Yes. Do you have any other omap patches? Do you want to send me a > pull req? We just found one more fix needed. I'm coll

Re: [PATCH 8/8] gpio/omap: fix missing check in *_runtime_suspend()

2012-05-18 Thread DebBarma, Tarun Kanti
On Fri, May 18, 2012 at 3:51 AM, Kevin Hilman wrote: > Tarun, Santosh, > > Tarun Kanti DebBarma writes: > >> We do checking for bank->enabled_non_wakeup_gpios in order >> to skip redundant operations. Somehow, the check got missed >> while doing the cleanup series. >> >> Just to make sure that we

Re: [PATCH 8/8] gpio/omap: fix missing check in *_runtime_suspend()

2012-05-17 Thread Shilimkar, Santosh
On Fri, May 18, 2012 at 5:26 AM, Kevin Hilman wrote: > Tony Lindgren writes: > >> * Kevin Hilman [120517 15:29]: >>> >>> I just noticed that this patch has caused some strange problems, notably >>> with the GPIO IRQ used by smsc911x NIC (Overo, Zoom3, 2430SDP, etc. etc.) >>> >>> The patch itself

Re: [PATCH 8/8] gpio/omap: fix missing check in *_runtime_suspend()

2012-05-17 Thread DebBarma, Tarun Kanti
On Fri, May 18, 2012 at 3:51 AM, Kevin Hilman wrote: > Tarun, Santosh, > > Tarun Kanti DebBarma writes: > >> We do checking for bank->enabled_non_wakeup_gpios in order >> to skip redundant operations. Somehow, the check got missed >> while doing the cleanup series. >> >> Just to make sure that we

Re: [PATCH 8/8] gpio/omap: fix missing check in *_runtime_suspend()

2012-05-17 Thread DebBarma, Tarun Kanti
On Fri, May 18, 2012 at 5:26 AM, Kevin Hilman wrote: > Tony Lindgren writes: > >> * Kevin Hilman [120517 15:29]: >>> >>> I just noticed that this patch has caused some strange problems, notably >>> with the GPIO IRQ used by smsc911x NIC (Overo, Zoom3, 2430SDP, etc. etc.) >>> >>> The patch itself

Re: [PATCH 8/8] gpio/omap: fix missing check in *_runtime_suspend()

2012-05-17 Thread Tony Lindgren
* Kevin Hilman [120517 17:00]: > > Argh, then $SUBJECT patch here has caused brokeness in multiple ways. > It managed to break both runtime suspend and runtime resume at the same > time. :( > > The change added by this patch to runtime_suspend effectively disables > the fix I did in 68942edb09 (

Re: [PATCH 8/8] gpio/omap: fix missing check in *_runtime_suspend()

2012-05-17 Thread Kevin Hilman
Tony Lindgren writes: > * Kevin Hilman [120517 15:29]: >> >> I just noticed that this patch has caused some strange problems, notably >> with the GPIO IRQ used by smsc911x NIC (Overo, Zoom3, 2430SDP, etc. etc.) >> >> The patch itself is OK, but it has exposed a bug in other parts of the >> con

Re: [PATCH 8/8] gpio/omap: fix missing check in *_runtime_suspend()

2012-05-17 Thread Grant Likely
On Thu, 17 May 2012 15:21:07 -0700, Kevin Hilman wrote: > Tarun, Santosh, > > Tarun Kanti DebBarma writes: > > > We do checking for bank->enabled_non_wakeup_gpios in order > > to skip redundant operations. Somehow, the check got missed > > while doing the cleanup series. > > > > Just to make su

Re: [PATCH 8/8] gpio/omap: fix missing check in *_runtime_suspend()

2012-05-17 Thread Tony Lindgren
* Kevin Hilman [120517 15:29]: > > I just noticed that this patch has caused some strange problems, notably > with the GPIO IRQ used by smsc911x NIC (Overo, Zoom3, 2430SDP, etc. etc.) > > The patch itself is OK, but it has exposed a bug in other parts of the > context restore path that was previ

Re: [PATCH 8/8] gpio/omap: fix missing check in *_runtime_suspend()

2012-05-17 Thread Kevin Hilman
Tarun, Santosh, Tarun Kanti DebBarma writes: > We do checking for bank->enabled_non_wakeup_gpios in order > to skip redundant operations. Somehow, the check got missed > while doing the cleanup series. > > Just to make sure that we do context restore correctly in > *_runtime_resume(), the bank->

Re: [PATCH 8/8] gpio/omap: fix missing check in *_runtime_suspend()

2012-05-03 Thread Santosh Shilimkar
On Friday 27 April 2012 07:43 PM, Tarun Kanti DebBarma wrote: > We do checking for bank->enabled_non_wakeup_gpios in order > to skip redundant operations. Somehow, the check got missed > while doing the cleanup series. > > Just to make sure that we do context restore correctly in > *_runtime_resum

[PATCH 8/8] gpio/omap: fix missing check in *_runtime_suspend()

2012-04-27 Thread Tarun Kanti DebBarma
We do checking for bank->enabled_non_wakeup_gpios in order to skip redundant operations. Somehow, the check got missed while doing the cleanup series. Just to make sure that we do context restore correctly in *_runtime_resume(), the bank->workaround_enabled check is moved after context restore. Ot