Re: [PATCH v2] gpio/omap: fix incorrect initialization of omap_gpio_mod_init

2012-05-11 Thread Grant Likely
On Mon, 7 May 2012 10:52:28 +0530, "DebBarma, Tarun Kanti" wrote: > Hi, > > On Sun, May 6, 2012 at 3:25 AM, Grazvydas Ignotas wrote: > > I've noticed that current mainline enables _all_ possible GPIO > > interrupts, this patch fixes that problem. > OK, thanks. > > > Also Grant doesn't seem to

Re: [PATCH v2] gpio/omap: fix incorrect initialization of omap_gpio_mod_init

2012-05-11 Thread Grant Likely
On Thu, 10 May 2012 07:23:56 -0700, Kevin Hilman wrote: > Grant, > > "DebBarma, Tarun Kanti" writes: > > > Hi, > > > > On Thu, May 10, 2012 at 3:06 AM, Janusz Krzysztofik > > wrote: > >> On Mon, 7 May 2012 10:52:28 DebBarma, Tarun Kanti wrote: > >>> On Sun, May 6, 2012 at 3:25 AM, Grazvydas Ig

Re: [PATCH v2] gpio/omap: fix incorrect initialization of omap_gpio_mod_init

2012-05-10 Thread Kevin Hilman
Grant, "DebBarma, Tarun Kanti" writes: > Hi, > > On Thu, May 10, 2012 at 3:06 AM, Janusz Krzysztofik > wrote: >> On Mon, 7 May 2012 10:52:28 DebBarma, Tarun Kanti wrote: >>> On Sun, May 6, 2012 at 3:25 AM, Grazvydas Ignotas wrote: >>> > On Mon, Apr 30, 2012 at 10:20 AM, Tarun Kanti DebBarma >>

Re: [PATCH v2] gpio/omap: fix incorrect initialization of omap_gpio_mod_init

2012-05-09 Thread DebBarma, Tarun Kanti
Hi, On Thu, May 10, 2012 at 3:06 AM, Janusz Krzysztofik wrote: > On Mon, 7 May 2012 10:52:28 DebBarma, Tarun Kanti wrote: >> On Sun, May 6, 2012 at 3:25 AM, Grazvydas Ignotas wrote: >> > On Mon, Apr 30, 2012 at 10:20 AM, Tarun Kanti DebBarma >> > wrote: >> >> Initialization of irqenable, irqsta

Re: [PATCH v2] gpio/omap: fix incorrect initialization of omap_gpio_mod_init

2012-05-09 Thread Janusz Krzysztofik
On Mon, 7 May 2012 10:52:28 DebBarma, Tarun Kanti wrote: > On Sun, May 6, 2012 at 3:25 AM, Grazvydas Ignotas wrote: > > On Mon, Apr 30, 2012 at 10:20 AM, Tarun Kanti DebBarma > > wrote: > >> Initialization of irqenable, irqstatus registers is the common > >> operation done in this function for al

Re: [PATCH v2] gpio/omap: fix incorrect initialization of omap_gpio_mod_init

2012-05-06 Thread DebBarma, Tarun Kanti
Hi, On Sun, May 6, 2012 at 3:25 AM, Grazvydas Ignotas wrote: > I've noticed that current mainline enables _all_ possible GPIO > interrupts, this patch fixes that problem. OK, thanks. > Also Grant doesn't seem to be on CC so might not be able to pick this up. I have added Cc: in the patch and was

Re: [PATCH v2] gpio/omap: fix incorrect initialization of omap_gpio_mod_init

2012-05-05 Thread Grazvydas Ignotas
I've noticed that current mainline enables _all_ possible GPIO interrupts, this patch fixes that problem. Also Grant doesn't seem to be on CC so might not be able to pick this up. On Mon, Apr 30, 2012 at 10:20 AM, Tarun Kanti DebBarma wrote: > Initialization of irqenable, irqstatus registers is t

[PATCH v2] gpio/omap: fix incorrect initialization of omap_gpio_mod_init

2012-04-30 Thread Tarun Kanti DebBarma
Initialization of irqenable, irqstatus registers is the common operation done in this function for all OMAP platforms, viz. OMAP1, OMAP2+. The latter _gpio_rmw()'s which supposedly got introduced wrongly to take care of OMAP2+ platforms were overwriting initially programmed OMAP1 value breaking fun