Re: [PATCH v2] usb: omap2430: fix memleak in err case

2013-05-28 Thread Libo Chen 
ping...

On 2013/5/22 11:30, Libo Chen wrote:
 
 when omap_get_control_dev faild, we should release related platform_device
 
 * Changelog from v1:
   * fix spell: s/fail/fails/, s/relational/related/ , thank Sergei 
 sergei.shtyl...@cogentembedded.com
 
 Signed-off-by: Libo Chen libo.c...@huawei.com
 ---
  drivers/usb/musb/omap2430.c |3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)
 
 diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
 index 3551f1a..b626f19 100644
 --- a/drivers/usb/musb/omap2430.c
 +++ b/drivers/usb/musb/omap2430.c
 @@ -549,7 +549,8 @@ static int omap2430_probe(struct platform_device *pdev)
   glue-control_otghs = omap_get_control_dev();
   if (IS_ERR(glue-control_otghs)) {
   dev_vdbg(pdev-dev, Failed to get control device\n);
 - return -ENODEV;
 + ret = -ENODEV;
 + goto err2;
   }
   } else {
   glue-control_otghs = ERR_PTR(-ENODEV);
 


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] usb: omap2430: fix memleak in err case

2013-05-28 Thread Andy Shevchenko 
No go.

Check the 4b7e450fb5cefb5865c77999a675330206ab3b8a
And update you tree, please.

--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] usb: omap2430: fix memleak in err case

2013-05-28 Thread Sergei Shtylyov 

Hello.

On 22-05-2013 7:30, Libo Chen wrote:


when omap_get_control_dev faild, we should release related platform_device



* Changelog from v1:
* fix spell: s/fail/fails/, s/relational/related/ , thank Sergei 
sergei.shtyl...@cogentembedded.com


   It seems you've actually replaced fail with faild, not fails.


Signed-off-by: Libo Chen libo.c...@huawei.com
---
  drivers/usb/musb/omap2430.c |3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)


WBR, Sergei

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] usb: omap2430: fix memleak in err case

2013-05-28 Thread Libo Chen 
On 2013/5/28 23:34, Andy Shevchenko wrote:
 No go.
 
 Check the 4b7e450fb5cefb5865c77999a675330206ab3b8a
 And update you tree, please.
 
 --
 With Best Regards,
 Andy Shevchenko
 
 

It had been changed :(

Thanks,

Libo

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] usb: omap2430: fix memleak in err case

2013-05-28 Thread Libo Chen 
On 2013/5/29 1:40, Sergei Shtylyov wrote:
 Hello.
 
 On 22-05-2013 7:30, Libo Chen wrote:
 
 when omap_get_control_dev faild, we should release related platform_device
 
 * Changelog from v1:
 * fix spell: s/fail/fails/, s/relational/related/ , thank Sergei 
 sergei.shtyl...@cogentembedded.com
 
It seems you've actually replaced fail with faild, not fails.

sorry for my weak spell.


thanks again,

Libo


 
 Signed-off-by: Libo Chen libo.c...@huawei.com
 ---
   drivers/usb/musb/omap2430.c |3 ++-
   1 files changed, 2 insertions(+), 1 deletions(-)
 
 WBR, Sergei
 
 
 


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2] usb: omap2430: fix memleak in err case

2013-05-21 Thread Libo Chen 

when omap_get_control_dev faild, we should release related platform_device

* Changelog from v1:
* fix spell: s/fail/fails/, s/relational/related/ , thank Sergei 
sergei.shtyl...@cogentembedded.com

Signed-off-by: Libo Chen libo.c...@huawei.com
---
 drivers/usb/musb/omap2430.c |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index 3551f1a..b626f19 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -549,7 +549,8 @@ static int omap2430_probe(struct platform_device *pdev)
glue-control_otghs = omap_get_control_dev();
if (IS_ERR(glue-control_otghs)) {
dev_vdbg(pdev-dev, Failed to get control device\n);
-   return -ENODEV;
+   ret = -ENODEV;
+   goto err2;
}
} else {
glue-control_otghs = ERR_PTR(-ENODEV);
-- 
1.7.1



--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html