Re: [PATCH v2 02/11] mfd: twl6040: Fix wrong TWL6040_GPO3 bitfield value

2011-12-01 Thread Laurent Pinchart
Hi Sergio, On Thursday 01 December 2011 18:35:20 Aguirre, Sergio wrote: > On Thu, Dec 1, 2011 at 11:24 AM, Laurent Pinchart wrote: > > On Thursday 01 December 2011 01:14:51 Sergio Aguirre wrote: > >> The define should be the result of 1 << Bit number. > >> > >> Bit number for GPOCTL.GPO3 field is

Re: [PATCH v2 02/11] mfd: twl6040: Fix wrong TWL6040_GPO3 bitfield value

2011-12-01 Thread Aguirre, Sergio
Hi Laurent, Thanks for the review. On Thu, Dec 1, 2011 at 11:24 AM, Laurent Pinchart wrote: > Hi Sergio, > > On Thursday 01 December 2011 01:14:51 Sergio Aguirre wrote: >> The define should be the result of 1 << Bit number. >> >> Bit number for GPOCTL.GPO3 field is 2, which results >> in 0x4 val

Re: [PATCH v2 02/11] mfd: twl6040: Fix wrong TWL6040_GPO3 bitfield value

2011-12-01 Thread Laurent Pinchart
Hi Sergio, On Thursday 01 December 2011 01:14:51 Sergio Aguirre wrote: > The define should be the result of 1 << Bit number. > > Bit number for GPOCTL.GPO3 field is 2, which results > in 0x4 value. > > Signed-off-by: Sergio Aguirre > --- > include/linux/mfd/twl6040.h |2 +- > 1 files chang

[PATCH v2 02/11] mfd: twl6040: Fix wrong TWL6040_GPO3 bitfield value

2011-11-30 Thread Sergio Aguirre
The define should be the result of 1 << Bit number. Bit number for GPOCTL.GPO3 field is 2, which results in 0x4 value. Signed-off-by: Sergio Aguirre --- include/linux/mfd/twl6040.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/linux/mfd/twl6040.h b/include/li