Re: [PATCH v2 1/2] extcon: fix hang and extcon_get/set_cable_state().

2015-07-30 Thread Chanwoo Choi
Hi Roger, I add minor comment about code clean. After I modified it by myself, I applied it on extcon-fixes. Best Regards, Chanwoo Choi On 07/07/2015 10:06 PM, Roger Quadros wrote: Users of find_cable_index_by_name() will cause a kernel hang as the while loop counter is never incremented and

Re: [PATCH v2 1/2] extcon: fix hang and extcon_get/set_cable_state().

2015-07-27 Thread Chanwoo Choi
Hi Roger, On 07/27/2015 07:39 PM, Roger Quadros wrote: Chanwoo, On 10/07/15 18:54, Chanwoo Choi wrote: Hi Roger, Thanks for your working. I'll review, test and apply it on next week because I'm on vacation now. Can you please take this for -rc cycle? Thanks. I'm sorry for delay

Re: [PATCH v2 1/2] extcon: fix hang and extcon_get/set_cable_state().

2015-07-27 Thread Roger Quadros
Chanwoo, On 10/07/15 18:54, Chanwoo Choi wrote: Hi Roger, Thanks for your working. I'll review, test and apply it on next week because I'm on vacation now. Can you please take this for -rc cycle? Thanks. cheers, -roger Thanks, Chanwoo Choi On Tue, Jul 7, 2015 at 3:06 PM, Roger

Re: [PATCH v2 1/2] extcon: fix hang and extcon_get/set_cable_state().

2015-07-10 Thread Chanwoo Choi
Hi Roger, Thanks for your working. I'll review, test and apply it on next week because I'm on vacation now. Thanks, Chanwoo Choi On Tue, Jul 7, 2015 at 3:06 PM, Roger Quadros rog...@ti.com wrote: Users of find_cable_index_by_name() will cause a kernel hang as the while loop counter is never

Re: [PATCH v2 1/2] extcon: fix hang and extcon_get/set_cable_state().

2015-07-07 Thread Ivan T. Ivanov
On Tue, 2015-07-07 at 16:06 +0300, Roger Quadros wrote: Users of find_cable_index_by_name() will cause a kernel hang as the while loop counter is never incremented and end condition is never reached. extcon_get_cable_state() and extcon_set_cable_state() are broken because they use cable

[PATCH v2 1/2] extcon: fix hang and extcon_get/set_cable_state().

2015-07-07 Thread Roger Quadros
Users of find_cable_index_by_name() will cause a kernel hang as the while loop counter is never incremented and end condition is never reached. extcon_get_cable_state() and extcon_set_cable_state() are broken because they use cable index instead of cable id. This causes the first cable state