Re: [PATCH v2 1/3] omap: mailbox: enable mailbox irq per instance

2012-05-08 Thread Ohad Ben-Cohen
Hi Juan, On Tue, May 8, 2012 at 1:09 AM, Gutierrez, Juan jgutier...@ti.com wrote: Startup it is now only used to enable pm runtime of the whole mbox module. Btw I really doubt we need to do that in a machine-specific handler, or whether we really need this startup/shutdown abstraction at all.

Re: [PATCH v2 1/3] omap: mailbox: enable mailbox irq per instance

2012-05-07 Thread Gutierrez, Juan
Hi Ohad On Sun, May 6, 2012 at 11:00 AM, Ohad Ben-Cohen o...@wizery.com wrote: Hi Juan, On Sat, Apr 14, 2012 at 2:39 AM, Juan Gutierrez jgutier...@ti.com wrote: The machine-specific omap2_mbox_startup is called only once to initialize the whole mbox module. Enabling mbox irq at startup is

Re: [PATCH v2 1/3] omap: mailbox: enable mailbox irq per instance

2012-05-06 Thread Ohad Ben-Cohen
Hi Juan, On Sat, Apr 14, 2012 at 2:39 AM, Juan Gutierrez jgutier...@ti.com wrote: The machine-specific omap2_mbox_startup is called only once to initialize the whole mbox module. Enabling mbox irq at startup is only enabling the irq of the very first mailbox instance created. The enable_irq

[PATCH v2 1/3] omap: mailbox: enable mailbox irq per instance

2012-04-13 Thread Juan Gutierrez
The machine-specific omap2_mbox_startup is called only once to initialize the whole mbox module. Enabling mbox irq at startup is only enabling the irq of the very first mailbox instance created. The enable_irq function should be called every time a new mbox instance is created, in the generic