Re: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support

2013-12-13 Thread Santosh Shilimkar
On Thursday 12 December 2013 07:43 PM, Felipe Balbi wrote: > On Thu, Dec 12, 2013 at 07:29:24PM -0500, Santosh Shilimkar wrote: >> On Thursday 12 December 2013 04:45 PM, Felipe Balbi wrote: >>> A bare-minimum PM implementation which will >>> server as building block for more complex >> s/server/ser

RE: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support

2013-12-13 Thread Kwok, WingMan
nux OMAP Mailing List > Subject: Re: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support > > On Fri, Dec 13, 2013 at 02:18:42PM -0600, Kwok, WingMan wrote: > > > > > -Original Message- > > > From: Balbi, Felipe > > > Sent: Friday, Decemb

Re: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support

2013-12-13 Thread Felipe Balbi
kgene@samsung.com; Linux ARM Kernel Mailing List; linux-samsung- > > s...@vger.kernel.org; Linux OMAP Mailing List > > Subject: Re: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support > > > > On Fri, Dec 13, 2013 at 10:04:38AM -0600, Kwok, WingMan wrote: &g

RE: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support

2013-12-13 Thread Kwok, WingMan
nux OMAP Mailing List > Subject: Re: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support > > On Fri, Dec 13, 2013 at 10:04:38AM -0600, Kwok, WingMan wrote: > > Hello > > > > > -Original Message- > > > From: Shilimkar, Santosh > > > Sent:

Re: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support

2013-12-13 Thread Felipe Balbi
x ARM Kernel > > Mailing List; linux-samsung-...@vger.kernel.org; Linux OMAP Mailing List; > > Kwok, WingMan > > Subject: Re: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support > > > > On Thursday 12 December 2013 04:45 PM, Felipe Balbi wrote: > > > A b

RE: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support

2013-12-13 Thread Kwok, WingMan
ok, WingMan > Subject: Re: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support > > On Thursday 12 December 2013 04:45 PM, Felipe Balbi wrote: > > A bare-minimum PM implementation which will server as building block > > for more complex > s/server/serve ;-) > > PM

Re: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support

2013-12-12 Thread Felipe Balbi
On Thu, Dec 12, 2013 at 07:29:24PM -0500, Santosh Shilimkar wrote: > On Thursday 12 December 2013 04:45 PM, Felipe Balbi wrote: > > A bare-minimum PM implementation which will > > server as building block for more complex > s/server/serve ;-) hah! :-) will fix in my branch. > > PM implementation

Re: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support

2013-12-12 Thread Santosh Shilimkar
On Thursday 12 December 2013 04:45 PM, Felipe Balbi wrote: > A bare-minimum PM implementation which will > server as building block for more complex s/server/serve ;-) > PM implementation in the future. > > At the least will not leave clocks on unnecessarily > when e.g. a user write mem to /sys/p

Re: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support

2013-12-12 Thread Felipe Balbi
Hi, On Thu, Dec 12, 2013 at 03:45:55PM -0600, Felipe Balbi wrote: > +static const struct dev_pm_ops kdwc3_dev_pm_ops = { > + .prepare= kdwc3_prepare, > + .complete = kdwc3_complete, > + > + SET_SYSTEM_SLEEP_PM_OPS(kdwc3_suspend, kdwc3_resume) > + SET_RUNTIME_PM_OPS(kd

[PATCH v2 1/7] usb: dwc3: keystone: add basic PM support

2013-12-12 Thread Felipe Balbi
A bare-minimum PM implementation which will server as building block for more complex PM implementation in the future. At the least will not leave clocks on unnecessarily when e.g. a user write mem to /sys/power/state. Signed-off-by: Felipe Balbi --- improve error path a little bit. drivers/