RE: [PATCH v2 2/3] ARM: OMAP2+: onenand: prepare for gpmc driver migration

2012-06-21 Thread Mohammed, Afzal
Hi Jon, On Thu, Jun 21, 2012 at 03:41:39, Hunter, Jon wrote: Ok, I see your point. So today the _set_async_mode() is really doing two things ... 1. It is calculating the timings 2. Programming the timings and setting async mode. I think that it would be best if we were to make

Re: [PATCH v2 2/3] ARM: OMAP2+: onenand: prepare for gpmc driver migration

2012-06-20 Thread Jon Hunter
Hi Afzal, On 06/19/2012 12:57 AM, Mohammed, Afzal wrote: Hi Jon, On Mon, Jun 18, 2012 at 21:31:46, Hunter, Jon wrote: @@ -95,10 +89,6 @@ static int omap2_onenand_set_async_mode(int cs, void __iomem *onenand_base) if (err) return err; - /* Ensure sync read and sync

Re: [PATCH v2 2/3] ARM: OMAP2+: onenand: prepare for gpmc driver migration

2012-06-18 Thread Jon Hunter
Hi Afzal, Thanks for sending the update. On 06/16/2012 03:03 AM, Afzal Mohammed wrote: Reorganize gpmc-onenand initialization so that changes required for gpmc driver migration can be made smooth. Ensuring sync read/write are disabled in onenand cannot be expected to work properly unless

RE: [PATCH v2 2/3] ARM: OMAP2+: onenand: prepare for gpmc driver migration

2012-06-18 Thread Mohammed, Afzal
Hi Jon, On Mon, Jun 18, 2012 at 21:31:46, Hunter, Jon wrote: @@ -95,10 +89,6 @@ static int omap2_onenand_set_async_mode(int cs, void __iomem *onenand_base) if (err) return err; - /* Ensure sync read and sync write are disabled */ - reg = readw(onenand_base +

[PATCH v2 2/3] ARM: OMAP2+: onenand: prepare for gpmc driver migration

2012-06-16 Thread Afzal Mohammed
Reorganize gpmc-onenand initialization so that changes required for gpmc driver migration can be made smooth. Ensuring sync read/write are disabled in onenand cannot be expected to work properly unless GPMC is setup, this has been removed. And invocation of set_async has been moved from set_sync