Re: [PATCH v2 2/6] rtc: omap: Add external clock enabling support

2015-08-14 Thread Alexandre Belloni
On 13/08/2015 at 20:17:23 +, Paul Walmsley wrote : > > I'd say that I don't really care. I'd say the best would be to make a > > decision based on clock-accuracy but maybe that is an information you > > don't have yet. Anyway, this could be added at a later date. > > Either the clock mux logic

Re: [PATCH v2 2/6] rtc: omap: Add external clock enabling support

2015-08-13 Thread Keerthy
On Friday 14 August 2015 01:47 AM, Paul Walmsley wrote: Hi guys On Wed, 12 Aug 2015, Alexandre Belloni wrote: On 13/08/2015 at 00:38:50 +0530, Keerthy wrote : The intent here is to switch to a higher precision clock which is the internal clock when available. Alexandre, Is dynamic switchi

Re: [PATCH v2 2/6] rtc: omap: Add external clock enabling support

2015-08-13 Thread Paul Walmsley
Hi guys On Wed, 12 Aug 2015, Alexandre Belloni wrote: > On 13/08/2015 at 00:38:50 +0530, Keerthy wrote : > > The intent here is to switch to a higher precision clock which is the > > internal clock when available. > > > > Alexandre, > > > > Is dynamic switching preferred over sticking to exter

Re: [PATCH v2 2/6] rtc: omap: Add external clock enabling support

2015-08-12 Thread Alexandre Belloni
Hi, On 13/08/2015 at 00:38:50 +0530, Keerthy wrote : > The intent here is to switch to a higher precision clock which is the > internal clock when available. > > Alexandre, > > Is dynamic switching preferred over sticking to external clock always if > present? > I'd say that I don't really ca

Re: [PATCH v2 2/6] rtc: omap: Add external clock enabling support

2015-08-12 Thread Keerthy
On Wednesday 12 August 2015 07:57 PM, Paul Walmsley wrote: On Mon, 10 Aug 2015, Keerthy wrote: Switch to external clock source during suspend and switch back to internal source on resume. This helps rtc ticking across suspend. Doesn't this type of dynamic switching make it likely that ticks

Re: [PATCH v2 2/6] rtc: omap: Add external clock enabling support

2015-08-12 Thread Paul Walmsley
On Mon, 10 Aug 2015, Keerthy wrote: > Switch to external clock source during suspend and switch back > to internal source on resume. This helps rtc ticking across suspend. Doesn't this type of dynamic switching make it likely that ticks will be lost? If the external, optional source is present,

Re: [PATCH v2 2/6] rtc: omap: Add external clock enabling support

2015-08-11 Thread Alexandre Belloni
Hi, This seems better but: On 10/08/2015 at 14:58:22 +0530, Keerthy wrote : > diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi > index d99b2ee..756819f 100644 > --- a/arch/arm/boot/dts/am4372.dtsi > +++ b/arch/arm/boot/dts/am4372.dtsi > @@ -336,6 +336,8 @@ >

[PATCH v2 2/6] rtc: omap: Add external clock enabling support

2015-08-10 Thread Keerthy
Switch to external clock source during suspend and switch back to internal source on resume. This helps rtc ticking across suspend. Signed-off-by: Keerthy --- arch/arm/boot/dts/am4372.dtsi | 2 ++ drivers/rtc/rtc-omap.c| 31 +++ 2 files changed, 33 insertions