Re: [PATCH v3 09/10] OMAP4: DSS2: HDMI: Function pointer approach to call

2011-09-06 Thread K, Mythri P
Hi, On Mon, Sep 5, 2011 at 11:03 PM, K, Mythri P mythr...@ti.com wrote: Hi, On Mon, Sep 5, 2011 at 4:31 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2011-09-02 at 16:17 +0530, mythr...@ti.com wrote: From: Mythri P K mythr...@ti.com To make the current hdmi DSS driver compatible

Re: [PATCH v3 09/10] OMAP4: DSS2: HDMI: Function pointer approach to call

2011-09-06 Thread Tomi Valkeinen
On Tue, 2011-09-06 at 11:38 +0530, K, Mythri P wrote: Did you consider how the code would look if the function pointers were just included into struct hdmi_ip_data, without any ops struct at all? I tried without ops structure , but then using it in dss_features to initialize would be a

Re: [PATCH v3 09/10] OMAP4: DSS2: HDMI: Function pointer approach to call

2011-09-06 Thread K, Mythri P
Hi, On Tue, Sep 6, 2011 at 3:47 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Tue, 2011-09-06 at 11:38 +0530, K, Mythri P wrote: Did you consider how the code would look if the function pointers were just included into struct hdmi_ip_data, without any ops struct at all? I tried

Re: [PATCH v3 09/10] OMAP4: DSS2: HDMI: Function pointer approach to call

2011-09-06 Thread Tomi Valkeinen
On Mon, 2011-09-05 at 23:03 +0530, K, Mythri P wrote: Hi, On Mon, Sep 5, 2011 at 4:31 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2011-09-02 at 16:17 +0530, mythr...@ti.com wrote: From: Mythri P K mythr...@ti.com To make the current hdmi DSS driver compatible with future

Re: [PATCH v3 09/10] OMAP4: DSS2: HDMI: Function pointer approach to call

2011-09-06 Thread K, Mythri P
Hi, On Tue, Sep 6, 2011 at 6:15 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Mon, 2011-09-05 at 23:03 +0530, K, Mythri P wrote: Hi, On Mon, Sep 5, 2011 at 4:31 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2011-09-02 at 16:17 +0530, mythr...@ti.com wrote: From: Mythri P K

Re: [PATCH v3 09/10] OMAP4: DSS2: HDMI: Function pointer approach to call

2011-09-05 Thread K, Mythri P
Hi, On Mon, Sep 5, 2011 at 4:31 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2011-09-02 at 16:17 +0530, mythr...@ti.com wrote: From: Mythri P K mythr...@ti.com To make the current hdmi DSS driver compatible with future OMAP having different IP blocks( A combination of different

Re: [PATCH v3 09/10] OMAP4: DSS2: HDMI: Function pointer approach to call

2011-09-05 Thread Tomi Valkeinen
On Fri, 2011-09-02 at 16:17 +0530, mythr...@ti.com wrote: From: Mythri P K mythr...@ti.com To make the current hdmi DSS driver compatible with future OMAP having different IP blocks( A combination of different core, PHY, PLL blocks), Add HDMI hdmi functions as a function pointer in

Re: [PATCH v3 09/10] OMAP4: DSS2: HDMI: Function pointer approach to call

2011-09-04 Thread Semwal, Sumit
On Fri, Sep 2, 2011 at 4:17 PM, mythr...@ti.com wrote: From: Mythri P K mythr...@ti.com snip +       hdmi.hdmi_data.ops-video_enable(hdmi.hdmi_data, 0); Still too much of 'hdmi' in this line - maybe you can just replace hdmi_data w/ data (like you did for hdmi_ops w/ ops)? snip -- To

[PATCH v3 09/10] OMAP4: DSS2: HDMI: Function pointer approach to call

2011-09-02 Thread mythripk
From: Mythri P K mythr...@ti.com To make the current hdmi DSS driver compatible with future OMAP having different IP blocks( A combination of different core, PHY, PLL blocks), Add HDMI hdmi functions as a function pointer in dss_features to abstract hdmi dss driver IP agnostic, hdmi dss driver