Re: [PATCH v4 1/3] staging: tidspbridge: fix mgr_enum_node_info

2010-12-06 Thread Ramirez Luna, Omar
On Fri, Nov 5, 2010 at 12:01 PM, Ionut Nicu ionut.n...@gmail.com wrote:
 From: Felipe Contreras felipe.contre...@gmail.com

 The current code was always returning a non-zero status value
 to userspace applications when this ioctl was called.

 The error code was ENODATA, which isn't actually an error,
 it's always returned by dcd_enumerate_object() when it hits the
 end of list.

 Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
 ---
  drivers/staging/tidspbridge/rmgr/mgr.c |    5 +
  1 files changed, 5 insertions(+), 0 deletions(-)


Pushed to dspbridge.

Regards,

Omar
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v4 1/3] staging: tidspbridge: fix mgr_enum_node_info

2010-11-05 Thread Ionut Nicu
From: Felipe Contreras felipe.contre...@gmail.com

The current code was always returning a non-zero status value
to userspace applications when this ioctl was called.

The error code was ENODATA, which isn't actually an error,
it's always returned by dcd_enumerate_object() when it hits the
end of list.

Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
 drivers/staging/tidspbridge/rmgr/mgr.c |5 +
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/tidspbridge/rmgr/mgr.c 
b/drivers/staging/tidspbridge/rmgr/mgr.c
index 0ea89a1..2eab6a5 100644
--- a/drivers/staging/tidspbridge/rmgr/mgr.c
+++ b/drivers/staging/tidspbridge/rmgr/mgr.c
@@ -169,6 +169,11 @@ int mgr_enum_node_info(u32 node_id, struct dsp_ndbprops 
*pndb_props,
 
}
}
+
+   /* the last status is not 0, but neither an error */
+   if (status  0)
+   status = 0;
+
if (!status) {
if (node_id  (node_index - 1)) {
status = -EINVAL;
-- 
1.7.2.3

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html