Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-04-04 Thread Dr. H. Nikolaus Schaller
Hi Pavel, Am 04.04.2015 um 10:16 schrieb Pavel Machek pa...@ucw.cz: Hi! Please propose your own code doing that so that we can test if it is better. So, how does this look? It looks to me like you have cca 0.1 Ohm resistance in your system, This is completely unknown. and are

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-04-04 Thread Pavel Machek
Hi! Please propose your own code doing that so that we can test if it is better. So, how does this look? It looks to me like you have cca 0.1 Ohm resistance in your system, This is completely unknown. and are using cca 75mA while discharging, and charge by cca 1.4A. Where

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-04-01 Thread Dr. H. Nikolaus Schaller
Hi Pavel, Am 31.03.2015 um 09:26 schrieb Pavel Machek pa...@ucw.cz: Hi! + io-channels = twl_madc 1, + twl_madc 10, + twl_madc 12; + io-channel-names = temp, +ichg, +vbat;

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-04-01 Thread Rob Herring
On Tue, Mar 10, 2015 at 4:27 PM, Marek Belisko ma...@goldelico.com wrote: Signed-off-by: Marek Belisko ma...@goldelico.com --- .../bindings/power_supply/twl4030_madc_battery.txt | 43 ++ 1 file changed, 43 insertions(+) create mode 100644

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-04-01 Thread Dr. H. Nikolaus Schaller
Hi, Am 01.04.2015 um 18:30 schrieb Rob Herring robherri...@gmail.com: On Tue, Mar 10, 2015 at 4:27 PM, Marek Belisko ma...@goldelico.com wrote: Signed-off-by: Marek Belisko ma...@goldelico.com --- .../bindings/power_supply/twl4030_madc_battery.txt | 43 ++ 1 file

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-04-01 Thread Pavel Machek
Hi! As I explained in some other mail, those tables should not be neccessary at all. They can be computed from li-ion characteristics and internal resistance, and assumed current during charge and discharge. I already explained that we do not know the charging and discharging current

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-04-01 Thread Dr. H. Nikolaus Schaller
Hi, Am 01.04.2015 um 22:16 schrieb Pavel Machek pa...@ucw.cz: Hi! As I explained in some other mail, those tables should not be neccessary at all. They can be computed from li-ion characteristics and internal resistance, and assumed current during charge and discharge. I already

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-31 Thread Pavel Machek
Hi! +io-channels = twl_madc 1, + twl_madc 10, + twl_madc 12; +io-channel-names = temp, + ichg, + vbat; +};

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-12 Thread Sebastian Reichel
Hi, On Wed, Mar 11, 2015 at 10:43:17AM -0700, Tony Lindgren wrote: No no, capacity-uah is what we should use, but you need an ack from the battery and device tree people that this is OK. Let's not add ti,capacity-uah” as that can obviously be a generic property. I'm okay with capacity-uah.

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-11 Thread Tony Lindgren
* Dr. H. Nikolaus Schaller h...@goldelico.com [150311 09:17]: Hi, Am 11.03.2015 um 16:24 schrieb Tony Lindgren t...@atomide.com: Hi, * Marek Belisko ma...@goldelico.com [150310 14:28]: Signed-off-by: Marek Belisko ma...@goldelico.com ---

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-11 Thread Tony Lindgren
Hi, * Marek Belisko ma...@goldelico.com [150310 14:28]: Signed-off-by: Marek Belisko ma...@goldelico.com --- .../bindings/power_supply/twl4030_madc_battery.txt | 43 ++ 1 file changed, 43 insertions(+) create mode 100644

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-11 Thread Dr. H. Nikolaus Schaller
Hi, Am 11.03.2015 um 16:24 schrieb Tony Lindgren t...@atomide.com: Hi, * Marek Belisko ma...@goldelico.com [150310 14:28]: Signed-off-by: Marek Belisko ma...@goldelico.com --- .../bindings/power_supply/twl4030_madc_battery.txt | 43 ++ 1 file changed, 43

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-11 Thread Dr. H. Nikolaus Schaller
Am 11.03.2015 um 17:44 schrieb Tony Lindgren t...@atomide.com: * Dr. H. Nikolaus Schaller h...@goldelico.com [150311 09:17]: Hi, Am 11.03.2015 um 16:24 schrieb Tony Lindgren t...@atomide.com: Hi, * Marek Belisko ma...@goldelico.com [150310 14:28]: Signed-off-by: Marek Belisko

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-11 Thread Tony Lindgren
* Sebastian Reichel s...@kernel.org [150311 12:37]: Hi, On Wed, Mar 11, 2015 at 10:43:17AM -0700, Tony Lindgren wrote: No no, capacity-uah is what we should use, but you need an ack from the battery and device tree people that this is OK. Let's not add ti,capacity-uah” as that can

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-11 Thread Tony Lindgren
* Dr. H. Nikolaus Schaller h...@goldelico.com [150311 10:13]: Am 11.03.2015 um 17:44 schrieb Tony Lindgren t...@atomide.com: * Dr. H. Nikolaus Schaller h...@goldelico.com [150311 09:17]: Am 11.03.2015 um 16:24 schrieb Tony Lindgren t...@atomide.com: Rather than just making platform_data

[PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-10 Thread Marek Belisko
Signed-off-by: Marek Belisko ma...@goldelico.com --- .../bindings/power_supply/twl4030_madc_battery.txt | 43 ++ 1 file changed, 43 insertions(+) create mode 100644 Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt diff --git