Re: [PATCH v5] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-08 Thread Daniel Mack
On 11/08/2013 01:02 AM, Kevin Hilman wrote: Daniel Mack zon...@gmail.com writes: +.resume_noirq = edma_pm_resume, +}; Also, I believe it was already suggested by Nishanth, but the late/early callbacks are probably more appropriate here than the noirq callbacks. Unless there's a

Re: [PATCH v5] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-08 Thread Joel Fernandes
On 11/08/2013 12:28 AM, Kevin Hilman wrote: [..] Also, I believe it was already suggested by Nishanth, but the late/early callbacks are probably more appropriate here than the noirq callbacks. Unless there's a *really* good reason to use the noirq callbacks, they should be avoided. That

Re: [PATCH v5] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-08 Thread Nishanth Menon
On 11/08/2013 10:14 AM, Joel Fernandes wrote: On 11/08/2013 12:28 AM, Kevin Hilman wrote: [..] Also, I believe it was already suggested by Nishanth, but the late/early callbacks are probably more appropriate here than the noirq callbacks. Unless there's a *really* good reason to use the noirq

Re: [PATCH v5] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-08 Thread Kevin Hilman
Joel Fernandes jo...@ti.com writes: On 11/08/2013 12:28 AM, Kevin Hilman wrote: [..] Also, I believe it was already suggested by Nishanth, but the late/early callbacks are probably more appropriate here than the noirq callbacks. Unless there's a *really* good reason to use the noirq

[PATCH v5] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Daniel Mack
This patch makes the edma driver resume correctly after suspend. Tested on an AM33xx platform with cyclic audio streams and omap_hsmmc. All information can be reconstructed by already known runtime information. As we now use some functions that were previously only used from __init context,

Re: [PATCH v5] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Kevin Hilman
Daniel Mack zon...@gmail.com writes: This patch makes the edma driver resume correctly after suspend. Tested on an AM33xx platform with cyclic audio streams and omap_hsmmc. All information can be reconstructed by already known runtime information. As we now use some functions that were

Re: [PATCH v5] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Joel Fernandes
Hi Kevin, On 11/07/2013 06:02 PM, Kevin Hilman wrote: Daniel Mack zon...@gmail.com writes: [..] +.resume_noirq = edma_pm_resume, +}; Also, I believe it was already suggested by Nishanth, but the late/early callbacks are probably more appropriate here than the noirq callbacks. Unless

Re: [PATCH v5] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Kevin Hilman
Hi Joel, On Thu, Nov 7, 2013 at 8:58 PM, Joel Fernandes jo...@ti.com wrote: On 11/07/2013 06:02 PM, Kevin Hilman wrote: Daniel Mack zon...@gmail.com writes: [..] +.resume_noirq = edma_pm_resume, +}; Also, I believe it was already suggested by Nishanth, but the late/early callbacks