Re: [PATCHv2 1/2] ads7846: OMAP3: Removal of warnings backtrace in bootup

2011-02-03 Thread Igor Grinberg
Hi, On 02/03/11 13:28, ABRAHAM, KISHON VIJAY wrote: > On Thu, Feb 3, 2011 at 4:42 PM, Igor Grinberg wrote: >> >> On 02/03/11 13:00, Poddar, Sourav wrote: >> >>> On Thu, Feb 3, 2011 at 3:47 PM, Igor Grinberg >>> wrote: if (pdata->get_pendown_state) { ts->get_pendown_state = pda

Re: [PATCHv2 1/2] ads7846: OMAP3: Removal of warnings backtrace in bootup

2011-02-03 Thread Lothar Waßmann
Hi, Igor Grinberg writes: > > > On 02/03/11 13:00, Poddar, Sourav wrote: > > > On Thu, Feb 3, 2011 at 3:47 PM, Igor Grinberg > > wrote: > >> if (pdata->get_pendown_state) { > >>ts->get_pendown_state = pdata->get_pendown_state; > >>ts->gpio_pendown = -1; > >>return 0; >

Re: [PATCHv2 1/2] ads7846: OMAP3: Removal of warnings backtrace in bootup

2011-02-03 Thread Poddar, Sourav
On Thu, Feb 3, 2011 at 5:02 PM, Lothar Waßmann wrote: > Hi, > > Igor Grinberg writes: >> >> >> On 02/03/11 13:00, Poddar, Sourav wrote: >> >> > On Thu, Feb 3, 2011 at 3:47 PM, Igor Grinberg >> > wrote: >> >> if (pdata->get_pendown_state) { >> >>        ts->get_pendown_state = pdata->get_pendown_

Re: [PATCHv2 1/2] ads7846: OMAP3: Removal of warnings backtrace in bootup

2011-02-03 Thread ABRAHAM, KISHON VIJAY
On Thu, Feb 3, 2011 at 4:42 PM, Igor Grinberg wrote: > > > On 02/03/11 13:00, Poddar, Sourav wrote: > >> On Thu, Feb 3, 2011 at 3:47 PM, Igor Grinberg >> wrote: >>> if (pdata->get_pendown_state) { >>>        ts->get_pendown_state = pdata->get_pendown_state; >>>        ts->gpio_pendown = -1; >>>

Re: [PATCHv2 1/2] ads7846: OMAP3: Removal of warnings backtrace in bootup

2011-02-03 Thread Igor Grinberg
On 02/03/11 13:00, Poddar, Sourav wrote: > On Thu, Feb 3, 2011 at 3:47 PM, Igor Grinberg wrote: >> if (pdata->get_pendown_state) { >>ts->get_pendown_state = pdata->get_pendown_state; >>ts->gpio_pendown = -1; >>return 0; >> } > Yes we can do so .I initialise it at a place

Re: [PATCHv2 1/2] ads7846: OMAP3: Removal of warnings backtrace in bootup

2011-02-03 Thread Felipe Balbi
Hi, On Thu, Feb 03, 2011 at 04:30:29PM +0530, Poddar, Sourav wrote: > I used -1 because conditional check done in probe ads7846_probe function > used this value. > > err_free_gpio: > if (ts->gpio_pendown != -1) > gpio_free(ts->gpio_pendown); you can actually change th

Re: [PATCHv2 1/2] ads7846: OMAP3: Removal of warnings backtrace in bootup

2011-02-03 Thread Poddar, Sourav
On Thu, Feb 3, 2011 at 3:47 PM, Igor Grinberg wrote: > Hi again, > > On 02/03/11 12:10, Igor Grinberg wrote: > >> Hi, >> >> On 02/03/11 11:48, Sourav Poddar wrote: >> >>> gpio_pendown in ads7846_probe is not getting initalized (defaulted to 0) >>> resulting in gpio_free to be called without a gpio

Re: [PATCHv2 1/2] ads7846: OMAP3: Removal of warnings backtrace in bootup

2011-02-03 Thread Igor Grinberg
Hi again, On 02/03/11 12:10, Igor Grinberg wrote: > Hi, > > On 02/03/11 11:48, Sourav Poddar wrote: > >> gpio_pendown in ads7846_probe is not getting initalized (defaulted to 0) >> resulting in gpio_free to be called without a gpio_request. This >> results in the following backtrace in bootup. >>

Re: [PATCHv2 1/2] ads7846: OMAP3: Removal of warnings backtrace in bootup

2011-02-03 Thread Igor Grinberg
Hi, On 02/03/11 11:48, Sourav Poddar wrote: > gpio_pendown in ads7846_probe is not getting initalized (defaulted to 0) > resulting in gpio_free to be called without a gpio_request. This > results in the following backtrace in bootup. > > [ cut here ] > WARNING: at drivers/

[PATCHv2 1/2] ads7846: OMAP3: Removal of warnings backtrace in bootup

2011-02-03 Thread Sourav Poddar
gpio_pendown in ads7846_probe is not getting initalized (defaulted to 0) resulting in gpio_free to be called without a gpio_request. This results in the following backtrace in bootup. [ cut here ] WARNING: at drivers/gpio/gpiolib.c:1258 gpio_free+0x100/0x12c() Modules linke