Re: [PATCHv5 01/31] CLK: clkdev: add support for looking up clocks from DT

2013-08-27 Thread Tony Lindgren
* Tero Kristo t-kri...@ti.com [130826 11:19]: On 08/26/2013 08:03 PM, Russell King - ARM Linux wrote: On Mon, Aug 26, 2013 at 05:36:15PM +0300, Tero Kristo wrote: On 08/03/2013 09:31 PM, Russell King - ARM Linux wrote: On Fri, Aug 02, 2013 at 07:25:20PM +0300, Tero Kristo wrote: + + if (cl)

Re: [PATCHv5 01/31] CLK: clkdev: add support for looking up clocks from DT

2013-08-26 Thread Tero Kristo
On 08/03/2013 09:31 PM, Russell King - ARM Linux wrote: On Fri, Aug 02, 2013 at 07:25:20PM +0300, Tero Kristo wrote: + + if (cl) + return cl; + + /* If clock was not found, attempt to look-up from DT */ + node = of_find_node_by_name(NULL, con_id); This is

Re: [PATCHv5 01/31] CLK: clkdev: add support for looking up clocks from DT

2013-08-26 Thread Russell King - ARM Linux
On Mon, Aug 26, 2013 at 05:36:15PM +0300, Tero Kristo wrote: On 08/03/2013 09:31 PM, Russell King - ARM Linux wrote: On Fri, Aug 02, 2013 at 07:25:20PM +0300, Tero Kristo wrote: + + if (cl) + return cl; + + /* If clock was not found, attempt to look-up from DT */ + node =

Re: [PATCHv5 01/31] CLK: clkdev: add support for looking up clocks from DT

2013-08-26 Thread Tero Kristo
On 08/26/2013 08:03 PM, Russell King - ARM Linux wrote: On Mon, Aug 26, 2013 at 05:36:15PM +0300, Tero Kristo wrote: On 08/03/2013 09:31 PM, Russell King - ARM Linux wrote: On Fri, Aug 02, 2013 at 07:25:20PM +0300, Tero Kristo wrote: + + if (cl) + return cl; + + /*

Re: [PATCHv5 01/31] CLK: clkdev: add support for looking up clocks from DT

2013-08-19 Thread Tero Kristo
Hey, (Sorry was out for a short vacation, thus late reply.) On 08/03/2013 10:04 PM, Tomasz Figa wrote: On Saturday 03 of August 2013 19:48:05 Russell King - ARM Linux wrote: On Sat, Aug 03, 2013 at 08:39:34PM +0200, Tomasz Figa wrote: Hi Russell, On Saturday 03 of August 2013 19:35:43

Re: [PATCHv5 01/31] CLK: clkdev: add support for looking up clocks from DT

2013-08-03 Thread Tomasz Figa
Hi Tero, On Friday 02 of August 2013 19:25:20 Tero Kristo wrote: clk_get_sys / clk_get can now find clocks from device-tree. If a DT clock is found, an entry is added to the clk_lookup list also for subsequent searches. Signed-off-by: Tero Kristo t-kri...@ti.com Cc: Russell King

Re: [PATCHv5 01/31] CLK: clkdev: add support for looking up clocks from DT

2013-08-03 Thread Russell King - ARM Linux
On Fri, Aug 02, 2013 at 07:25:20PM +0300, Tero Kristo wrote: + + if (cl) + return cl; + + /* If clock was not found, attempt to look-up from DT */ + node = of_find_node_by_name(NULL, con_id); This is utterly broken if you're looking up purely by a connection ID.

Re: [PATCHv5 01/31] CLK: clkdev: add support for looking up clocks from DT

2013-08-03 Thread Russell King - ARM Linux
On Sat, Aug 03, 2013 at 04:02:36PM +0200, Tomasz Figa wrote: + if (cl) + return cl; + + /* If clock was not found, attempt to look-up from DT */ + node = of_find_node_by_name(NULL, con_id); Why are we introducing the lookup by name brokenness to the yet (mostly) sane

Re: [PATCHv5 01/31] CLK: clkdev: add support for looking up clocks from DT

2013-08-03 Thread Tomasz Figa
Hi Russell, On Saturday 03 of August 2013 19:35:43 Russell King - ARM Linux wrote: On Sat, Aug 03, 2013 at 04:02:36PM +0200, Tomasz Figa wrote: + if (cl) + return cl; + + /* If clock was not found, attempt to look-up from DT */ + node = of_find_node_by_name(NULL, con_id);

Re: [PATCHv5 01/31] CLK: clkdev: add support for looking up clocks from DT

2013-08-03 Thread Russell King - ARM Linux
On Sat, Aug 03, 2013 at 08:39:34PM +0200, Tomasz Figa wrote: Hi Russell, On Saturday 03 of August 2013 19:35:43 Russell King - ARM Linux wrote: On Sat, Aug 03, 2013 at 04:02:36PM +0200, Tomasz Figa wrote: + if (cl) + return cl; + + /* If clock was

Re: [PATCHv5 01/31] CLK: clkdev: add support for looking up clocks from DT

2013-08-03 Thread Tomasz Figa
On Saturday 03 of August 2013 19:48:05 Russell King - ARM Linux wrote: On Sat, Aug 03, 2013 at 08:39:34PM +0200, Tomasz Figa wrote: Hi Russell, On Saturday 03 of August 2013 19:35:43 Russell King - ARM Linux wrote: On Sat, Aug 03, 2013 at 04:02:36PM +0200, Tomasz Figa wrote: +

[PATCHv5 01/31] CLK: clkdev: add support for looking up clocks from DT

2013-08-02 Thread Tero Kristo
clk_get_sys / clk_get can now find clocks from device-tree. If a DT clock is found, an entry is added to the clk_lookup list also for subsequent searches. Signed-off-by: Tero Kristo t-kri...@ti.com Cc: Russell King li...@arm.linux.org.uk --- drivers/clk/clkdev.c | 33