Re: [PATCHv6 1/6] regulator: core: add support for external get/set_voltage

2011-11-28 Thread Tero Kristo
On Fri, 2011-11-25 at 18:48 +, Mark Brown wrote: On Fri, Nov 25, 2011 at 07:59:03PM +0200, Tero Kristo wrote: On Fri, 2011-11-25 at 17:29 +, Mark Brown wrote: No, that's clearly going to break multi-board kernel images. If this is something board specific platform/device tree

[PATCHv6 1/6] regulator: core: add support for external get/set_voltage

2011-11-25 Thread Tero Kristo
Regulator users can now set override functions for get_voltage and set_voltage. This is required by some regulators, which have two alternate control paths. E.g., OMAP SMPS regulators can be controlled either through the I2C interface or voltage processor control path, which uses specialized

Re: [PATCHv6 1/6] regulator: core: add support for external get/set_voltage

2011-11-25 Thread Mark Brown
On Fri, Nov 25, 2011 at 06:29:17PM +0200, Tero Kristo wrote: Why is this only on the OMAP list? Always CC the relevant discussion list for the subsystem, especially when proposing changes to the subsystem! Regulator users can now set override functions for get_voltage and set_voltage. This is

Re: [PATCHv6 1/6] regulator: core: add support for external get/set_voltage

2011-11-25 Thread Tero Kristo
On Fri, 2011-11-25 at 16:52 +, Mark Brown wrote: On Fri, Nov 25, 2011 at 06:29:17PM +0200, Tero Kristo wrote: Why is this only on the OMAP list? Always CC the relevant discussion list for the subsystem, especially when proposing changes to the subsystem! Regulator users can now set

Re: [PATCHv6 1/6] regulator: core: add support for external get/set_voltage

2011-11-25 Thread Mark Brown
On Fri, Nov 25, 2011 at 07:20:32PM +0200, Tero Kristo wrote: On Fri, 2011-11-25 at 16:52 +, Mark Brown wrote: My basic reaction to this is eew, ick. Doing this with a runtime call just feels badly joined up, and there's nothing here which hands off the configuration between the

Re: [PATCHv6 1/6] regulator: core: add support for external get/set_voltage

2011-11-25 Thread Tero Kristo
On Fri, 2011-11-25 at 17:29 +, Mark Brown wrote: On Fri, Nov 25, 2011 at 07:20:32PM +0200, Tero Kristo wrote: On Fri, 2011-11-25 at 16:52 +, Mark Brown wrote: My basic reaction to this is eew, ick. Doing this with a runtime call just feels badly joined up, and there's nothing

Re: [PATCHv6 1/6] regulator: core: add support for external get/set_voltage

2011-11-25 Thread Mark Brown
On Fri, Nov 25, 2011 at 07:59:03PM +0200, Tero Kristo wrote: On Fri, 2011-11-25 at 17:29 +, Mark Brown wrote: No, that's clearly going to break multi-board kernel images. If this is something board specific platform/device tree data sounds like the way forwards. Okay, so I will