Re: [RFC 6/7] iommu/core: add fault reporting

2011-09-07 Thread Ohad Ben-Cohen
On Mon, Sep 5, 2011 at 1:00 PM, Roedel, Joerg joerg.roe...@amd.com wrote: Please add a seperate function for setting the fault-handler. It is optional, so no need to be a value of the alloc-function. Will do. Can you elaborate a bit on what the user of the api will do different between

Re: [RFC 6/7] iommu/core: add fault reporting

2011-09-05 Thread Roedel, Joerg
On Fri, Sep 02, 2011 at 01:32:35PM -0400, Ohad Ben-Cohen wrote: -struct iommu_domain *iommu_domain_alloc(void) +/** + * iommu_domain_alloc() - allocate and initialize a new iommu domain + * @handler: an optional pointer to a fault handler, or NULL if not needed + * + * Returns the new

[RFC 6/7] iommu/core: add fault reporting

2011-09-02 Thread Ohad Ben-Cohen
Add iommu fault report mechanism to the IOMMU API, so implementations could report about mmu faults (translation errors, hardware errors, etc..). Fault reports can be used in several ways: - mere logging - reset the device that accessed the faulting address (may be necessary in case the device