Re: [RFC PATCH 0/6] ARM: OMAP3+: move smartreflex-class3.c to drivers/power/avs
Hi Nishanth, On 10/25/2012 09:21 AM, Jean Pihet wrote: Hi Nishant, On Tue, Oct 23, 2012 at 11:43 PM, Nishanth Menon n...@ti.com wrote: smartreflex.c now resides in drivers/power/avs directory, but class driver is in mach-omap2. High time we move it off to drivers/power/avs. Great to see the SR fully moved to drivers/. After review of the code I am OK with the changes besides remarks sent on the patches: Acked-by: Jean Pihet j-pi...@ti.com I let Kevin comment on the VC/VP aspect though. This move looks good to me. Thanks! Just had one nit, but after that. Feel free to post without the RFC, and be sure to include Rafael and linux-pm since it's moving to drivers/power. I'll then queue it up for Rafael for v3.8. Thanks, Kevin -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 0/6] ARM: OMAP3+: move smartreflex-class3.c to drivers/power/avs
Hi Nishant, On Sat, Nov 3, 2012 at 2:14 PM, Kevin Hilman khil...@deeprootsystems.com wrote: Hi Nishanth, On 10/25/2012 09:21 AM, Jean Pihet wrote: Hi Nishant, On Tue, Oct 23, 2012 at 11:43 PM, Nishanth Menon n...@ti.com wrote: smartreflex.c now resides in drivers/power/avs directory, but class driver is in mach-omap2. High time we move it off to drivers/power/avs. Great to see the SR fully moved to drivers/. After review of the code I am OK with the changes besides remarks sent on the patches: Acked-by: Jean Pihet j-pi...@ti.com I let Kevin comment on the VC/VP aspect though. This move looks good to me. Thanks! Just had one nit, but after that. Feel free to post without the RFC, and be sure to include Rafael and linux-pm since it's moving to drivers/power. Please also include Anton, cf. http://marc.info/?l=linux-pmm=134424298230568w=2 Regards, Jean I'll then queue it up for Rafael for v3.8. Thanks, Kevin -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 0/6] ARM: OMAP3+: move smartreflex-class3.c to drivers/power/avs
Hi Nishant,
On Tue, Oct 23, 2012 at 11:43 PM, Nishanth Menon n...@ti.com wrote:
smartreflex.c now resides in drivers/power/avs directory, but class driver
is in mach-omap2. High time we move it off to drivers/power/avs.
Great to see the SR fully moved to drivers/.
After review of the code I am OK with the changes besides remarks sent
on the patches:
Acked-by: Jean Pihet j-pi...@ti.com
I let Kevin comment on the VC/VP aspect though.
This series *does not* try to fix VP/VC to be voltage regulator OR introduce
a new OMAP voltage regulator series. instead, it purely tries to do the
minimal
changes needed to move code to drivers/power/avs as a start.
Baseline: k.org v3.7-rc2
Testing: Platform: beagle XM C1 (3730)
while [ 1 ]
do
echo -n 0 /sys/kernel/debug/smartreflex/smartreflex_core/autocomp
date
echo -n 1 /sys/kernel/debug/smartreflex/smartreflex_core/autocomp
done
Screen capture after the series: on inductor L5 (VDD2 - core):
https://plus.google.com/photos/112464029509057661457/albums/5715034179943520193/5802619719180530114
RFC for a view if this is ok as an intermediate step.
Thanks!
Jean
Nishanth Menon (6):
PM / AVS / OMAP: move Kconfig definition of smartreflex to avs
directory
ARM: OMAP: voltage: remove duplicate header definitions
ARM: OMAP: voltage: move voltdm_reset to platform_data header
ARM: OMAP: SmartReflex: provide SoC integration API for VP
ARM: OMAP: SmartReflex: use pr_warn instead of pr_warning
PM / AVS / OMAP: move Smartreflex-class3 driver to power/avs
arch/arm/mach-omap2/Makefile |1 -
arch/arm/mach-omap2/sr_device.c|5
arch/arm/mach-omap2/voltage.h |4 ---
arch/arm/plat-omap/Kconfig | 31
drivers/power/avs/Kconfig | 31
drivers/power/avs/Makefile |1 +
.../power/avs}/smartreflex-class3.c| 20 +
drivers/power/avs/smartreflex.c|2 ++
include/linux/platform_data/voltage-omap.h |1 +
include/linux/power/smartreflex.h | 18
10 files changed, 73 insertions(+), 41 deletions(-)
rename {arch/arm/mach-omap2 = drivers/power/avs}/smartreflex-class3.c (75%)
Regards,
Nishanth Menon
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[RFC PATCH 0/6] ARM: OMAP3+: move smartreflex-class3.c to drivers/power/avs
smartreflex.c now resides in drivers/power/avs directory, but class driver
is in mach-omap2. High time we move it off to drivers/power/avs.
This series *does not* try to fix VP/VC to be voltage regulator OR introduce
a new OMAP voltage regulator series. instead, it purely tries to do the minimal
changes needed to move code to drivers/power/avs as a start.
Baseline: k.org v3.7-rc2
Testing: Platform: beagle XM C1 (3730)
while [ 1 ]
do
echo -n 0 /sys/kernel/debug/smartreflex/smartreflex_core/autocomp
date
echo -n 1 /sys/kernel/debug/smartreflex/smartreflex_core/autocomp
done
Screen capture after the series: on inductor L5 (VDD2 - core):
https://plus.google.com/photos/112464029509057661457/albums/5715034179943520193/5802619719180530114
RFC for a view if this is ok as an intermediate step.
Nishanth Menon (6):
PM / AVS / OMAP: move Kconfig definition of smartreflex to avs
directory
ARM: OMAP: voltage: remove duplicate header definitions
ARM: OMAP: voltage: move voltdm_reset to platform_data header
ARM: OMAP: SmartReflex: provide SoC integration API for VP
ARM: OMAP: SmartReflex: use pr_warn instead of pr_warning
PM / AVS / OMAP: move Smartreflex-class3 driver to power/avs
arch/arm/mach-omap2/Makefile |1 -
arch/arm/mach-omap2/sr_device.c|5
arch/arm/mach-omap2/voltage.h |4 ---
arch/arm/plat-omap/Kconfig | 31
drivers/power/avs/Kconfig | 31
drivers/power/avs/Makefile |1 +
.../power/avs}/smartreflex-class3.c| 20 +
drivers/power/avs/smartreflex.c|2 ++
include/linux/platform_data/voltage-omap.h |1 +
include/linux/power/smartreflex.h | 18
10 files changed, 73 insertions(+), 41 deletions(-)
rename {arch/arm/mach-omap2 = drivers/power/avs}/smartreflex-class3.c (75%)
Regards,
Nishanth Menon
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
