Re: [linux-pm] [RFC PATCH 07/11] mfd: omap: control: usb-phy: introduce the ctrl-module usb driver

2012-06-01 Thread Tony Lindgren
* Kevin Hilman [120601 07:11]: > Tony Lindgren writes: > > > * Tony Lindgren [120601 04:43]: > >> * Eduardo Valentin [120525 01:31]: > >> > +int omap4_usb_phy_power(struct device *dev, int on) > >> > +{ > >> > +u32 val; > >> > +int ret; > >> > + > >> > +if (on) { > >> >

Re: [linux-pm] [RFC PATCH 07/11] mfd: omap: control: usb-phy: introduce the ctrl-module usb driver

2012-06-01 Thread Kevin Hilman
Tony Lindgren writes: > * Tony Lindgren [120601 04:43]: >> * Eduardo Valentin [120525 01:31]: >> > +int omap4_usb_phy_power(struct device *dev, int on) >> > +{ >> > + u32 val; >> > + int ret; >> > + >> > + if (on) { >> > + ret = omap_control_readl(dev, CONTROL_DEV_CONF, &val); >> >

Re: [linux-pm] [RFC PATCH 07/11] mfd: omap: control: usb-phy: introduce the ctrl-module usb driver

2012-06-01 Thread Tony Lindgren
* Tony Lindgren [120601 04:43]: > * Eduardo Valentin [120525 01:31]: > > +int omap4_usb_phy_power(struct device *dev, int on) > > +{ > > + u32 val; > > + int ret; > > + > > + if (on) { > > + ret = omap_control_readl(dev, CONTROL_DEV_CONF, &val); > > + if (!ret && (val &

Re: [RFC PATCH 07/11] mfd: omap: control: usb-phy: introduce the ctrl-module usb driver

2012-06-01 Thread Tony Lindgren
* Eduardo Valentin [120525 01:31]: > +int omap4_usb_phy_power(struct device *dev, int on) > +{ > + u32 val; > + int ret; > + > + if (on) { > + ret = omap_control_readl(dev, CONTROL_DEV_CONF, &val); > + if (!ret && (val & PHY_PD)) { > + ret =

Re: [RFC PATCH 07/11] mfd: omap: control: usb-phy: introduce the ctrl-module usb driver

2012-05-25 Thread Cousson, Benoit
On 5/25/2012 10:25 AM, Eduardo Valentin wrote: Created a new platform driver for the platform device created by the control module mfd core, wrt usb. This driver has API's to power on/off the phy and the API's to write to musb mailbox. (p.s. the mailbox for musb in omap4 is present in system con

Re: [RFC PATCH 07/11] mfd: omap: control: usb-phy: introduce the ctrl-module usb driver

2012-05-25 Thread Shubhrajyoti Datta
Hi Edurardo, A few doubts, On Fri, May 25, 2012 at 1:55 PM, Eduardo Valentin wrote: > Created a new platform driver for the platform device created by the > control module mfd core, wrt usb. This driver has API's to power on/off > the phy and the API's to write to musb mailbox. > > (p.s. the mail

[RFC PATCH 07/11] mfd: omap: control: usb-phy: introduce the ctrl-module usb driver

2012-05-25 Thread Eduardo Valentin
Created a new platform driver for the platform device created by the control module mfd core, wrt usb. This driver has API's to power on/off the phy and the API's to write to musb mailbox. (p.s. the mailbox for musb in omap4 is present in system control module) [kis...@ti.com: wrote the original