Re: [RFC PATCH 1/3] arm: plat-omap: dmtimer: Add clock source from DT

Hi, On 10/16/2015 05:40 PM, Felipe Balbi wrote: >> +static int omap_dm_timer_of_set_source(struct omap_dm_timer *timer) >> +{ >> +int ret; >> +struct clk *parent; >> + >> +if (unlikely(!timer)) >> +return -EINVAL; > > IMO, let this crash. If this happens we have bigger

[RFC PATCH 1/3] arm: plat-omap: dmtimer: Add clock source from DT

Add a function which sets the timer source from the clocks binding on dm_timer_prepare call. In case the clocks property is not valid, it falls back to the set_source() with 32_KHZ clock as default. Suggested-by: Tony Lindgren Signed-off-by: Neil Armstrong

Re: [RFC PATCH 1/3] arm: plat-omap: dmtimer: Add clock source from DT

Hi, Neil Armstrong writes: > Add a function which sets the timer source from the clocks > binding on dm_timer_prepare call. > > In case the clocks property is not valid, it falls back to > the set_source() with 32_KHZ clock as default. > > Suggested-by: Tony Lindgren