Re: Issue with _are_all_hardreset_lines_asserted()

2012-10-09 Thread Omar Ramirez Luna
Hi, On 9 October 2012 00:38, Paul Walmsley wrote: > cc Vaibhav due to the AM33xx change > > Hi > > On Thu, 4 Oct 2012, Archit Taneja wrote: > >> I was trying out the linux-next kernel, and I noticed that DSS MODULEMODE >> bits >> are never cleared. >> >> In _omap4_disable_module(), there is a ch

RE: Issue with _are_all_hardreset_lines_asserted()

2012-10-09 Thread Hiremath, Vaibhav
On Tue, Oct 09, 2012 at 12:29:53, Paul Walmsley wrote: > On Tue, 9 Oct 2012, Archit Taneja wrote: > > > The patch looks fine to me. I tried it out for DSS(with an additional patch > > to > > not represent DSS modulemode bits as a slave clock), and modulemode is > > getting > > disabled correctly

Re: Issue with _are_all_hardreset_lines_asserted()

2012-10-09 Thread Paul Walmsley
On Tue, 9 Oct 2012, Archit Taneja wrote: > The patch looks fine to me. I tried it out for DSS(with an additional patch to > not represent DSS modulemode bits as a slave clock), and modulemode is getting > disabled correctly now. Thanks, I added your Tested-by: and also updated the patch descripti

Re: Issue with _are_all_hardreset_lines_asserted()

2012-10-08 Thread Archit Taneja
Hi, On Tuesday 09 October 2012 11:08 AM, Paul Walmsley wrote: cc Vaibhav due to the AM33xx change Hi On Thu, 4 Oct 2012, Archit Taneja wrote: I was trying out the linux-next kernel, and I noticed that DSS MODULEMODE bits are never cleared. In _omap4_disable_module(), there is a check:

Re: Issue with _are_all_hardreset_lines_asserted()

2012-10-08 Thread Paul Walmsley
cc Vaibhav due to the AM33xx change Hi On Thu, 4 Oct 2012, Archit Taneja wrote: > I was trying out the linux-next kernel, and I noticed that DSS MODULEMODE bits > are never cleared. > > In _omap4_disable_module(), there is a check: > > ... > > if (!_are_all_hardreset_lines_asserted

Issue with _are_all_hardreset_lines_asserted()

2012-10-04 Thread Archit Taneja
Hi, I was trying out the linux-next kernel, and I noticed that DSS MODULEMODE bits are never cleared. In _omap4_disable_module(), there is a check: ... if (!_are_all_hardreset_lines_asserted(oh)) return 0; /* MODULEMODE bits cleared here */ ..