RE: [PATCH] OMAP: Zoom3: Fix Zoom3 booting issue
-Original Message- From: G, Manjunath Kondaiah Sent: Wednesday, March 03, 2010 12:38 AM To: G, Manjunath Kondaiah; Aguirre, Sergio; linux-omap@vger.kernel.org Cc: Tony Lindgren; Shilimkar, Santosh; Raja, Govindraj Subject: RE: [PATCH] OMAP: Zoom3: Fix Zoom3 booting issue -Original Message- From: G, Manjunath Kondaiah Sent: Wednesday, March 03, 2010 11:31 AM To: Aguirre, Sergio; linux-omap@vger.kernel.org Cc: Tony Lindgren; Shilimkar, Santosh; Raja, Govindraj Subject: RE: [PATCH] OMAP: Zoom3: Fix Zoom3 booting issue Sergio, -Original Message- From: Aguirre, Sergio Sent: Tuesday, March 02, 2010 9:41 PM To: G, Manjunath Kondaiah; linux-omap@vger.kernel.org Cc: G, Manjunath Kondaiah; Tony Lindgren; Shilimkar, Santosh; Raja, Govindraj Subject: RE: [PATCH] OMAP: Zoom3: Fix Zoom3 booting issue Manju, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Manjunatha GK Sent: Tuesday, March 02, 2010 7:36 AM To: linux-omap@vger.kernel.org Cc: G, Manjunath Kondaiah; Tony Lindgren; Shilimkar, Santosh; Raja, Govindraj Subject: [PATCH] OMAP: Zoom3: Fix Zoom3 booting issue The commit id 5550bc33a1a9002976022cc794fe8c52ad9a0021 seems to be broken zoom3 boot which adds support for UART4 on OMAP4 and OMAP3630. But, it looks like OMAP3630 UART4 interface and functional clock nodes needs to be added for omap3630. Thus limiting no. of UART's for 3630 to 3 to prevent boot up issues until clock nodes are added for UART4 on OMAP3630. I already tried a similar patch here: http://patchwork.kernel.org/patch/81692/ But as it is really not solving anything, and Tony rejected it, I started working on the needed bits to get UART4 enabled, therefore I have came up with this patch series: - [RFC v3][PATCH 0/6] OMAP3630: UART4 startup (+ new bugfix!) [1] Also, I'm working in my spare time on a cleanup proposal [2], which I'll repost today, given some comments from Kevin. So, if you want to boot, take series [1] and [2], and then you should be able to boot with ttyS0. Sergio, did you test this combination on zoom3? It seems to be not working on zoom3 with ttyS0 and also with ttyS3. Where as, reducing number of uarts(for 3630) to 3 seems to working fine for ttyS3 on zoom3. To update further, it seems to be working on zoom3 with ttyS0 with following combination of patches: 1. [RFC,part2,v1,4/4] omap3: zoom 2/3: Change debugboard serial port id [RFC,part2,v1,3/4] omap3: 3630sdp: Explicitly enable all UARTs [RFC,part2,v1,2/4] omap3: zoom2/3 / 3630sdp: Don't init always all uarts [RFC,part2,v1,1/4] omap2/3/4: serial: rename omap_serial_init 2. [RESEND,PATCH/RFC] OMAP2: serial.c: Fix number of uarts in early_init 3. [RFC,v3,6/6] omap3: serial: Fix uart4 handling for 3630 [RFC,v3,5/6] OMAP3: PRCM: Consider UART4 for 3630 chip in prcm_setup_regs [RFC,v3,4/6] OMAP clock: Add uart4_ick/fck definitions for 3630 [RFC,v3,3/6] ARM: OMAP3630: PRCM: Add UART4 control bits [RFC,v3,2/6] omap2/3/4: serial: Remove condition for getting uart4_phys [RFC,v3,1/6] OMAP3: serial: Check for zero-based physical addr Yeah, that should be the total patchlist applied. I'm assuming you're applying from bottom to top order in your list above... Regards, Sergio -Manjunath -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] OMAP: Zoom3: Fix Zoom3 booting issue
To update further, it seems to be working on zoom3 with ttyS0 with following combination of patches: 1. [RFC,part2,v1,4/4] omap3: zoom 2/3: Change debugboard serial port id [RFC,part2,v1,3/4] omap3: 3630sdp: Explicitly enable all UARTs [RFC,part2,v1,2/4] omap3: zoom2/3 / 3630sdp: Don't init always all uarts [RFC,part2,v1,1/4] omap2/3/4: serial: rename omap_serial_init 2. [RESEND,PATCH/RFC] OMAP2: serial.c: Fix number of uarts in early_init 3. [RFC,v3,6/6] omap3: serial: Fix uart4 handling for 3630 [RFC,v3,5/6] OMAP3: PRCM: Consider UART4 for 3630 chip in prcm_setup_regs [RFC,v3,4/6] OMAP clock: Add uart4_ick/fck definitions for 3630 [RFC,v3,3/6] ARM: OMAP3630: PRCM: Add UART4 control bits [RFC,v3,2/6] omap2/3/4: serial: Remove condition for getting uart4_phys [RFC,v3,1/6] OMAP3: serial: Check for zero-based physical addr Yeah, that should be the total patchlist applied. I'm assuming you're applying from bottom to top order in your list above... Yes. But, you will be dropping v1 part2 series right? Regards, Manjunath-- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] OMAP: Zoom3: Fix Zoom3 booting issue
-Original Message- From: G, Manjunath Kondaiah Sent: Wednesday, March 03, 2010 7:39 AM To: Aguirre, Sergio; linux-omap@vger.kernel.org Cc: Tony Lindgren; Shilimkar, Santosh; Raja, Govindraj Subject: RE: [PATCH] OMAP: Zoom3: Fix Zoom3 booting issue To update further, it seems to be working on zoom3 with ttyS0 with following combination of patches: 1. [RFC,part2,v1,4/4] omap3: zoom 2/3: Change debugboard serial port id [RFC,part2,v1,3/4] omap3: 3630sdp: Explicitly enable all UARTs [RFC,part2,v1,2/4] omap3: zoom2/3 / 3630sdp: Don't init always all uarts [RFC,part2,v1,1/4] omap2/3/4: serial: rename omap_serial_init 2. [RESEND,PATCH/RFC] OMAP2: serial.c: Fix number of uarts in early_init 3. [RFC,v3,6/6] omap3: serial: Fix uart4 handling for 3630 [RFC,v3,5/6] OMAP3: PRCM: Consider UART4 for 3630 chip in prcm_setup_regs [RFC,v3,4/6] OMAP clock: Add uart4_ick/fck definitions for 3630 [RFC,v3,3/6] ARM: OMAP3630: PRCM: Add UART4 control bits [RFC,v3,2/6] omap2/3/4: serial: Remove condition for getting uart4_phys [RFC,v3,1/6] OMAP3: serial: Check for zero-based physical addr Yeah, that should be the total patchlist applied. I'm assuming you're applying from bottom to top order in your list above... Yes. But, you will be dropping v1 part2 series right? I'll just drop patch #0001 in that series, and resend. Actually, I'll group the 2 series and resend in a single batch, just to be clear on the dependency between them. Regards, Sergio Regards, Manjunath -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] OMAP: Zoom3: Fix Zoom3 booting issue
Manju,
-Original Message-
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Manjunatha GK
Sent: Tuesday, March 02, 2010 7:36 AM
To: linux-omap@vger.kernel.org
Cc: G, Manjunath Kondaiah; Tony Lindgren; Shilimkar, Santosh; Raja,
Govindraj
Subject: [PATCH] OMAP: Zoom3: Fix Zoom3 booting issue
The commit id 5550bc33a1a9002976022cc794fe8c52ad9a0021 seems to be
broken
zoom3 boot which adds support for UART4 on OMAP4 and OMAP3630.
But, it looks like OMAP3630 UART4 interface and functional clock nodes
needs
to be added for omap3630. Thus limiting no. of UART's for 3630 to 3 to
prevent
boot up issues until clock nodes are added for UART4 on OMAP3630.
I already tried a similar patch here:
http://patchwork.kernel.org/patch/81692/
But as it is really not solving anything, and Tony rejected it, I started
working on the needed bits to get UART4 enabled, therefore I have came up with
this patch series:
- [RFC v3][PATCH 0/6] OMAP3630: UART4 startup (+ new bugfix!) [1]
Also, I'm working in my spare time on a cleanup proposal [2], which I'll repost
today, given some comments from Kevin.
So, if you want to boot, take series [1] and [2], and then you should be able
to boot with ttyS0.
Regards,
Sergio
---
[1] http://marc.info/?l=linux-omapm=126730356232287w=2
[2] http://marc.info/?l=linux-omapm=126746974103007w=2
Cc: Tony Lindgren t...@atomide.com
Cc: Santosh Shilimkar santosh.shilim...@ti.com
Signed-off-by: Manjunatha GK manj...@ti.com
Signed-off-by: Govindraj R govindraj.r...@ti.com
---
arch/arm/mach-omap2/serial.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
index b79bc89..ac22a4e 100644
--- a/arch/arm/mach-omap2/serial.c
+++ b/arch/arm/mach-omap2/serial.c
@@ -764,7 +764,12 @@ void __init omap_serial_init(void)
{
int i, nr_ports;
- if (!(cpu_is_omap3630() || cpu_is_omap4430()))
+ /* Limit no.of UART ports to three for OMAP3630 since
+ * clock nodes are yet to be updated for 3630 UART4.
+ * TODO: update clock nodes for 3630 UART4 and then enable
+ * check for !(cpu_is_omap3630())
+ */
+ if (!cpu_is_omap4430())
nr_ports = 3;
else
nr_ports = ARRAY_SIZE(omap_uart);
--
1.6.0.4
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] OMAP: Zoom3: Fix Zoom3 booting issue
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Aguirre, Sergio Sent: Tuesday, March 02, 2010 10:11 AM To: G, Manjunath Kondaiah; linux-omap@vger.kernel.org Cc: G, Manjunath Kondaiah; Tony Lindgren; Shilimkar, Santosh; Raja, Govindraj Subject: RE: [PATCH] OMAP: Zoom3: Fix Zoom3 booting issue Manju, snip So, if you want to boot, take series [1] and [2], and then you should be able to boot with ttyS0. Yes I could boot the zoom3 with your patchset with console on ttyS0: Relevant Boot Log: Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled serial8250.0: ttyS0 at MMIO 0x1000 (irq = 262) is a ST16654 console [ttyS0] enabled Regards, Sergio --- [1] http://marc.info/?l=linux-omapm=126730356232287w=2 [2] http://marc.info/?l=linux-omapm=126746974103007w=2 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] OMAP: Zoom3: Fix Zoom3 booting issue
Sergio, -Original Message- From: Aguirre, Sergio Sent: Tuesday, March 02, 2010 9:41 PM To: G, Manjunath Kondaiah; linux-omap@vger.kernel.org Cc: G, Manjunath Kondaiah; Tony Lindgren; Shilimkar, Santosh; Raja, Govindraj Subject: RE: [PATCH] OMAP: Zoom3: Fix Zoom3 booting issue Manju, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Manjunatha GK Sent: Tuesday, March 02, 2010 7:36 AM To: linux-omap@vger.kernel.org Cc: G, Manjunath Kondaiah; Tony Lindgren; Shilimkar, Santosh; Raja, Govindraj Subject: [PATCH] OMAP: Zoom3: Fix Zoom3 booting issue The commit id 5550bc33a1a9002976022cc794fe8c52ad9a0021 seems to be broken zoom3 boot which adds support for UART4 on OMAP4 and OMAP3630. But, it looks like OMAP3630 UART4 interface and functional clock nodes needs to be added for omap3630. Thus limiting no. of UART's for 3630 to 3 to prevent boot up issues until clock nodes are added for UART4 on OMAP3630. I already tried a similar patch here: http://patchwork.kernel.org/patch/81692/ But as it is really not solving anything, and Tony rejected it, I started working on the needed bits to get UART4 enabled, therefore I have came up with this patch series: - [RFC v3][PATCH 0/6] OMAP3630: UART4 startup (+ new bugfix!) [1] Also, I'm working in my spare time on a cleanup proposal [2], which I'll repost today, given some comments from Kevin. So, if you want to boot, take series [1] and [2], and then you should be able to boot with ttyS0. Sergio, did you test this combination on zoom3? It seems to be not working on zoom3 with ttyS0 and also with ttyS3. Where as, reducing number of uarts(for 3630) to 3 seems to working fine for ttyS3 on zoom3. -Manjunath -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] OMAP: Zoom3: Fix Zoom3 booting issue
-Original Message- From: G, Manjunath Kondaiah Sent: Wednesday, March 03, 2010 11:31 AM To: Aguirre, Sergio; linux-omap@vger.kernel.org Cc: Tony Lindgren; Shilimkar, Santosh; Raja, Govindraj Subject: RE: [PATCH] OMAP: Zoom3: Fix Zoom3 booting issue Sergio, -Original Message- From: Aguirre, Sergio Sent: Tuesday, March 02, 2010 9:41 PM To: G, Manjunath Kondaiah; linux-omap@vger.kernel.org Cc: G, Manjunath Kondaiah; Tony Lindgren; Shilimkar, Santosh; Raja, Govindraj Subject: RE: [PATCH] OMAP: Zoom3: Fix Zoom3 booting issue Manju, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Manjunatha GK Sent: Tuesday, March 02, 2010 7:36 AM To: linux-omap@vger.kernel.org Cc: G, Manjunath Kondaiah; Tony Lindgren; Shilimkar, Santosh; Raja, Govindraj Subject: [PATCH] OMAP: Zoom3: Fix Zoom3 booting issue The commit id 5550bc33a1a9002976022cc794fe8c52ad9a0021 seems to be broken zoom3 boot which adds support for UART4 on OMAP4 and OMAP3630. But, it looks like OMAP3630 UART4 interface and functional clock nodes needs to be added for omap3630. Thus limiting no. of UART's for 3630 to 3 to prevent boot up issues until clock nodes are added for UART4 on OMAP3630. I already tried a similar patch here: http://patchwork.kernel.org/patch/81692/ But as it is really not solving anything, and Tony rejected it, I started working on the needed bits to get UART4 enabled, therefore I have came up with this patch series: - [RFC v3][PATCH 0/6] OMAP3630: UART4 startup (+ new bugfix!) [1] Also, I'm working in my spare time on a cleanup proposal [2], which I'll repost today, given some comments from Kevin. So, if you want to boot, take series [1] and [2], and then you should be able to boot with ttyS0. Sergio, did you test this combination on zoom3? It seems to be not working on zoom3 with ttyS0 and also with ttyS3. Where as, reducing number of uarts(for 3630) to 3 seems to working fine for ttyS3 on zoom3. To update further, it seems to be working on zoom3 with ttyS0 with following combination of patches: 1. [RFC,part2,v1,4/4] omap3: zoom 2/3: Change debugboard serial port id [RFC,part2,v1,3/4] omap3: 3630sdp: Explicitly enable all UARTs [RFC,part2,v1,2/4] omap3: zoom2/3 / 3630sdp: Don't init always all uarts [RFC,part2,v1,1/4] omap2/3/4: serial: rename omap_serial_init 2. [RESEND,PATCH/RFC] OMAP2: serial.c: Fix number of uarts in early_init 3. [RFC,v3,6/6] omap3: serial: Fix uart4 handling for 3630 [RFC,v3,5/6] OMAP3: PRCM: Consider UART4 for 3630 chip in prcm_setup_regs [RFC,v3,4/6] OMAP clock: Add uart4_ick/fck definitions for 3630 [RFC,v3,3/6] ARM: OMAP3630: PRCM: Add UART4 control bits [RFC,v3,2/6] omap2/3/4: serial: Remove condition for getting uart4_phys [RFC,v3,1/6] OMAP3: serial: Check for zero-based physical addr -Manjunath-- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
