RE: [PATCH 1/2] OMAP: DSS2: Introduce dss_features files

2010-09-07 Thread Taneja, Archit
Hi, Tomi Valkeinen wrote: > On Tue, 2010-09-07 at 13:31 +0200, ext Taneja, Archit wrote: >> Hi, >> >> Tomi Valkeinen wrote: >>> Hi, >>> >>> On Thu, 2010-08-26 at 14:43 +0200, ext Archit Taneja wrote: Add dss_features.c and dss_features.h for the dss_features framework Signed-off-

RE: [PATCH 1/2] OMAP: DSS2: Introduce dss_features files

2010-09-07 Thread Tomi Valkeinen
On Tue, 2010-09-07 at 13:31 +0200, ext Taneja, Archit wrote: > Hi, > > Tomi Valkeinen wrote: > > Hi, > > > > On Thu, 2010-08-26 at 14:43 +0200, ext Archit Taneja wrote: > >> Add dss_features.c and dss_features.h for the dss_features framework > >> > >> Signed-off-by: Archit Taneja > > > > Woul

RE: [PATCH 1/2] OMAP: DSS2: Introduce dss_features files

2010-09-07 Thread Taneja, Archit
Hi, Tomi Valkeinen wrote: > Hi, > > On Thu, 2010-08-26 at 14:43 +0200, ext Archit Taneja wrote: >> Add dss_features.c and dss_features.h for the dss_features framework >> >> Signed-off-by: Archit Taneja > > Would a more static approach be cleaner? I mean something like this (pseudo > code): >

RE: [PATCH 1/2] OMAP: DSS2: Introduce dss_features files

2010-09-07 Thread Tomi Valkeinen
On Tue, 2010-09-07 at 13:05 +0200, ext Taneja, Archit wrote: > Hi, > There are 2 functions in the present code: > omap_dss_get_num_overlays() > omap_dss_get_num_overlay_managers() > > They look very similar to the dss_feature functions but are required. > I will need to come up with new names for

RE: [PATCH 1/2] OMAP: DSS2: Introduce dss_features files

2010-09-07 Thread Taneja, Archit
Hi, Tomi Valkeinen wrote: > Hi, > > On Thu, 2010-08-26 at 14:43 +0200, ext Archit Taneja wrote: >> Add dss_features.c and dss_features.h for the dss_features framework >> >> Signed-off-by: Archit Taneja > > And some more comments inline > >> --- >> drivers/video/omap2/dss/dss_features.c | 1

Re: [PATCH 1/2] OMAP: DSS2: Introduce dss_features files

2010-09-07 Thread Tomi Valkeinen
Hi, On Thu, 2010-08-26 at 14:43 +0200, ext Archit Taneja wrote: > Add dss_features.c and dss_features.h for the dss_features framework > > Signed-off-by: Archit Taneja And some more comments inline > --- > drivers/video/omap2/dss/dss_features.c | 197 > > dr

Re: [PATCH 1/2] OMAP: DSS2: Introduce dss_features files

2010-09-07 Thread Tomi Valkeinen
Hi, On Thu, 2010-08-26 at 14:43 +0200, ext Archit Taneja wrote: > Add dss_features.c and dss_features.h for the dss_features framework > > Signed-off-by: Archit Taneja Would a more static approach be cleaner? I mean something like this (pseudo code): static struct omap_dss_features omap3_dss_f